From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C70C04A95 for ; Tue, 25 Oct 2022 15:41:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB3678E0002; Tue, 25 Oct 2022 11:41:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A63808E0001; Tue, 25 Oct 2022 11:41:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 952768E0002; Tue, 25 Oct 2022 11:41:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 862FD8E0001 for ; Tue, 25 Oct 2022 11:41:49 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6268CC0399 for ; Tue, 25 Oct 2022 15:41:49 +0000 (UTC) X-FDA: 80059887138.22.8989348 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf15.hostedemail.com (Postfix) with ESMTP id 6F639A000A for ; Tue, 25 Oct 2022 15:41:48 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 5313B68B05; Tue, 25 Oct 2022 17:41:43 +0200 (CEST) Date: Tue, 25 Oct 2022 17:41:43 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: Chaitanya Kulkarni , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-mm@kvack.org" , Christoph Hellwig , Greg Kroah-Hartman , Dan Williams , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell , Stephen Bates Subject: Re: [PATCH v11 3/9] iov_iter: introduce iov_iter_get_pages_[alloc_]flags() Message-ID: <20221025154143.GA25128@lst.de> References: <20221021174116.7200-1-logang@deltatee.com> <20221021174116.7200-4-logang@deltatee.com> <929ac68b-cf07-8df6-e589-49b0576a50c5@nvidia.com> <41e621bb-e836-4a86-e6db-0beed19f5ddc@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41e621bb-e836-4a86-e6db-0beed19f5ddc@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666712508; a=rsa-sha256; cv=none; b=Wsi1y4d5Fai18xPmUvxD24cb85w8/DgMmweNUxpVelDInZUe5Fk+uhyNddcuAAdwo3csXH c+89dSGvAy7owezbLRRp2vIhyprdMZMVZHMojrtLcWc8xxSMsmq5d4n4Yk/hc9mO2ArMxR xIckn1QjJ4Kqw3aBk+ZKwj6BRE/4hWA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=none (imf15.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666712508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uyWqy7uHIc7mBgvRQ500Iier3iz2OAx4o9eZyzb7XFY=; b=dPDEy3ugl07IZ5h6x3CwXvUI8q7eAEgshPUsl9Vzy2XtQHkB7Us9Dx2IaqCsGIwBWSuf1o AhZNJHxYzsdcUJ/n6zQPWSaXtUX89AmSZym1TY2PcvjPlPs/pSUqoV/3B8wSSiIMO60j6H DXiet9V9v3eU7FZYpyBhDLplV27kZ68= X-Rspamd-Queue-Id: 6F639A000A Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=none (imf15.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: uxct88gmepzkcb8zstejbum9ux6bkopc X-HE-Tag: 1666712508-271271 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > Just one minor question why not make following functions > > EXPORT_SYMBOL_GPL() ? > > > > 1. iov_iter_get_pages2() > > 2. iov_iter_get_pages_alloc2() > > They previously were not GPL, so I didn't think that should be changed > in this patch. Yes. While they should have been _GPL from the start, rocking that boat is a bit pointless now. We just need to make sure to do the right thing for the pinning variants that are going to replace them soon.