From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD864C38A2D for ; Tue, 25 Oct 2022 12:56:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27EFC8E0002; Tue, 25 Oct 2022 08:56:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22F9E8E0001; Tue, 25 Oct 2022 08:56:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11D328E0002; Tue, 25 Oct 2022 08:56:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 065858E0001 for ; Tue, 25 Oct 2022 08:56:20 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B68D58044E for ; Tue, 25 Oct 2022 12:56:19 +0000 (UTC) X-FDA: 80059470078.11.37885C8 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by imf14.hostedemail.com (Postfix) with ESMTP id 93DF810002E for ; Tue, 25 Oct 2022 12:56:18 +0000 (UTC) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id E9A215FD03; Tue, 25 Oct 2022 15:56:15 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1666702576; bh=FDJLYQVfAPEsI0KUWAF0tnbcOsSG/a/B7l7gy81zlRw=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=kMEA9K2eETrHcb7Da6vTw6wVBOBB4pY05MByklWuZiBAUiUZBe1zUZh22BtTR3Ofv w50FKjcyMJg329cOBpdaL/o0DCkpCecw52Hk93cDGlumMt3X79VeYmRg8gkZfttoJX kgO1LeX1itpA/g58WLW19+tTuELNF1tNqYmACuv6d1Qea9kpEiBQTw2ynX2HdHhLWy +lSulN6Ii3xNNswe4KGRnH25i+r/sQeBuS7g2tkrVmpqNQ8h3p5cCxfCWBAn/E22BH zU9eaqZheqIuVis1ECUda/9JZKTFHn0cxTJGHdNystPpXaGKL6UZW3BWW6OwqbUrsk rPzCbT2aiFFpQ== Received: from S-MS-EXCH02.sberdevices.ru (S-MS-EXCH02.sberdevices.ru [172.16.1.5]) by mx.sberdevices.ru (Postfix) with ESMTP; Tue, 25 Oct 2022 15:56:14 +0300 (MSK) From: Aleksey Romanov To: Sergey Senozhatsky CC: Andrew Morton , "minchan@kernel.org" , "ngupta@vflare.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , kernel Subject: Re: [PATCH v1] zram: add size class equals check into recompression Thread-Topic: [PATCH v1] zram: add size class equals check into recompression Thread-Index: AQHY56FoneIKBPF3rEq28K0jaPH8QK4eJ6gAgAADEgCAAIHKAIAABYEAgAAd1wCAAAvXAIAABQuA Date: Tue, 25 Oct 2022 12:56:08 +0000 Message-ID: <20221025125542.wenx6m624wu4vuxf@cab-wsm-0029881.lan> References: <20221024120942.13885-1-avromanov@sberdevices.ru> <20221025094859.7kbcqknlkmo4hj2y@cab-wsm-0029881.lan> <20221025115542.5o4igroslirn6cxy@cab-wsm-0029881.lan> In-Reply-To: Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/10/25 10:18:00 #20514748 X-KSMG-AntiVirus-Status: Clean, skipped ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666702579; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FDJLYQVfAPEsI0KUWAF0tnbcOsSG/a/B7l7gy81zlRw=; b=UVeDhN4psNcDsr6n8tuseEPpUX/YE2t6rMD6vrHR5IbIXda7K+KQQkT9omVFxNvhaqrZKz rpxnjjiJJR8OaZ3tMEDE/tMOzVapuVqbtwOz+kgmhuzhtW9sf81gVft+Z+8ZEA5+CdA+W4 RT+8F/PmGlR95wW3xCQyS+euUQww924= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=sberdevices.ru header.s=mail header.b=kMEA9K2e; spf=pass (imf14.hostedemail.com: domain of AVRomanov@sberdevices.ru designates 45.89.227.171 as permitted sender) smtp.mailfrom=AVRomanov@sberdevices.ru; dmarc=pass (policy=quarantine) header.from=sberdevices.ru ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666702579; a=rsa-sha256; cv=none; b=VLkemszCqchYEc6wGBketJju9bxK4bTaqfHy9eLsKz4B/5Dx2jEmD6TtW/I1XyBkdJDI8y IU53gsSsDpjryfPEjqhSoT3LS+HQ+05pbTsGuYs9BsvZMeslCN5sI1Cp/Sy4JLVTBfZzMn yECmQ3AVmFgipDdR1T1gbKepnUJiFS0= X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 93DF810002E X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=sberdevices.ru header.s=mail header.b=kMEA9K2e; spf=pass (imf14.hostedemail.com: domain of AVRomanov@sberdevices.ru designates 45.89.227.171 as permitted sender) smtp.mailfrom=AVRomanov@sberdevices.ru; dmarc=pass (policy=quarantine) header.from=sberdevices.ru X-Stat-Signature: 7x1fd9iaicbadqijfktsw6kxrgxff1q6 X-HE-Tag: 1666702578-374130 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000808, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 25, 2022 at 09:38:04PM +0900, Sergey Senozhatsky wrote: > On (22/10/25 11:55), Aleksey Romanov wrote: > > > Return: the index of the zsmalloc &size_class that hold objects of = the > > > provided size. > > >=20 > > > unsigned int zs_lookup_class_index(struct zs_pool *pool, unsigned int= size) > > > { > > > struct size_class *class =3D pool->size_class[get_size_class_= index(size)]; > > >=20 > > > return class->index; > > > } > >=20 > > Sure. I think it would be more logical, and perhaps such a function > > would be more applicable in other cases, in the future. > >=20 > > Will you fix it in your cherry-pick? >=20 > For that I probably will ask you to send out v2, if possible. Okay, I will send v2 soon. --=20 Thank you, Alexey=