From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECE9DC04A95 for ; Tue, 25 Oct 2022 11:56:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A0078E0002; Tue, 25 Oct 2022 07:56:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 828B68E0001; Tue, 25 Oct 2022 07:56:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C9A18E0002; Tue, 25 Oct 2022 07:56:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 58C238E0001 for ; Tue, 25 Oct 2022 07:56:02 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2AF67160D7D for ; Tue, 25 Oct 2022 11:56:02 +0000 (UTC) X-FDA: 80059318164.22.A2DCCBA Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by imf03.hostedemail.com (Postfix) with ESMTP id 2A5C52002D for ; Tue, 25 Oct 2022 11:56:00 +0000 (UTC) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 1B31A5FD05; Tue, 25 Oct 2022 14:55:59 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1666698959; bh=WPnpYPQkgBzWbd/TOkdLi2NUtbsya4FpNFvnUymmR3I=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=CCRRQSA7oRn0GA299GT47cMNieOAmEs2JOYGFf5Kr6+sN4QrxdpdbdUQPAxndBmX4 H04OJndsdEnCARCEGSucy8MJBqW1vModgHgsP+1rV7qW74VRCLkNQ2J9tFMFu3dhfJ YFNmuLTARi117RB3gU/0iyZ5N382zYCcD6gfuDkaEao1Rnj9g/LkQ0s4AWFR1vmARC AgsqjwyTewQPoCMF/NDAAvvM81zy8XEyam/uy4tC7DoOk8BR5yYJfSkp5njqBwP7NY j6rbpetFCUt3i6Z+GL1iHe+BMupVHXjIszJnv8093aDSq5xz/V8oc/ih6gwigGx36p irfuH/jmr5Elg== Received: from S-MS-EXCH02.sberdevices.ru (S-MS-EXCH02.sberdevices.ru [172.16.1.5]) by mx.sberdevices.ru (Postfix) with ESMTP; Tue, 25 Oct 2022 14:55:57 +0300 (MSK) From: Aleksey Romanov To: Sergey Senozhatsky CC: Andrew Morton , "minchan@kernel.org" , "ngupta@vflare.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , kernel Subject: Re: [PATCH v1] zram: add size class equals check into recompression Thread-Topic: [PATCH v1] zram: add size class equals check into recompression Thread-Index: AQHY56FoneIKBPF3rEq28K0jaPH8QK4eJ6gAgAADEgCAAIHKAIAABYEAgAAd1wA= Date: Tue, 25 Oct 2022 11:55:51 +0000 Message-ID: <20221025115542.5o4igroslirn6cxy@cab-wsm-0029881.lan> References: <20221024120942.13885-1-avromanov@sberdevices.ru> <20221025094859.7kbcqknlkmo4hj2y@cab-wsm-0029881.lan> In-Reply-To: Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-Type: text/plain; charset="us-ascii" Content-ID: <01B5ABE957561B48AAA2754E64A57C61@sberdevices.ru> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/10/25 10:18:00 #20514748 X-KSMG-AntiVirus-Status: Clean, skipped ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666698961; a=rsa-sha256; cv=none; b=pXnLfdEkfH99/+zkC/Do/MrGKAZI7MHgdslGmHayuGs0hkl5DbjJ+YLOgxyjtzXK4U8EVW dutWWGs+ZhX8KjYkFVFkvwzC93uYDNFvXWwc2J4dxaKAhryVDzeXqf967y8dTND1tDOu8W /3vtudV40mNDGvU6ilXiyijXA29rVso= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=sberdevices.ru header.s=mail header.b=CCRRQSA7; dmarc=pass (policy=quarantine) header.from=sberdevices.ru; spf=pass (imf03.hostedemail.com: domain of AVRomanov@sberdevices.ru designates 45.89.227.171 as permitted sender) smtp.mailfrom=AVRomanov@sberdevices.ru ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666698961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WPnpYPQkgBzWbd/TOkdLi2NUtbsya4FpNFvnUymmR3I=; b=uoDqe7gnguYnds+/rCbYTXTBd4cDwWKX7Sn/U0eHf7qdJ6dYOnST+5Q7ATM5tOyJIGE0HD eYHIDY2QYK81eOECbQQko7BU9ZETnHcEUyn+oqloflPYv8dVZmYiNshHmu8geQ5C+Upr+h KscIXptQbgU8dvaO9MydB9XFCqFy89g= X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=sberdevices.ru header.s=mail header.b=CCRRQSA7; dmarc=pass (policy=quarantine) header.from=sberdevices.ru; spf=pass (imf03.hostedemail.com: domain of AVRomanov@sberdevices.ru designates 45.89.227.171 as permitted sender) smtp.mailfrom=AVRomanov@sberdevices.ru X-Rspamd-Server: rspam11 X-Stat-Signature: gbkrd1ymswztz8jqyzrk5ogqmmwtchw8 X-Rspamd-Queue-Id: 2A5C52002D X-HE-Tag: 1666698960-70929 X-Bogosity: Ham, tests=bogofilter, spamicity=0.003850, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 25, 2022 at 07:08:54PM +0900, Sergey Senozhatsky wrote: > On (22/10/25 09:49), Aleksey Romanov wrote: > > On Tue, Oct 25, 2022 at 11:04:40AM +0900, Sergey Senozhatsky wrote: > > > On (22/10/25 10:53), Sergey Senozhatsky wrote: > > > > > +unsigned int zs_get_class_size(struct zs_pool *pool, unsigned in= t size) > > > > > +{ > > > > > + struct size_class *class =3D pool->size_class[get_size_class_in= dex(size)]; > > > > > + > > > > > + return class->size; > > > > > +} > > > > > +EXPORT_SYMBOL_GPL(zs_get_class_size); >=20 > I wonder if we want to return class->index instead of class->size? >=20 > Something like this (a sketch) >=20 > Return: the index of the zsmalloc &size_class that hold objects of the > provided size. >=20 > unsigned int zs_lookup_class_index(struct zs_pool *pool, unsigned int siz= e) > { > struct size_class *class =3D pool->size_class[get_size_class_inde= x(size)]; >=20 > return class->index; > } Sure. I think it would be more logical, and perhaps such a function would be more applicable in other cases, in the future. Will you fix it in your cherry-pick? --=20 Thank you, Alexey=