From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 346F8C38A2D for ; Tue, 25 Oct 2022 09:49:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F17D8E0002; Tue, 25 Oct 2022 05:49:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A1958E0001; Tue, 25 Oct 2022 05:49:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 490378E0002; Tue, 25 Oct 2022 05:49:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 39B998E0001 for ; Tue, 25 Oct 2022 05:49:33 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F294080452 for ; Tue, 25 Oct 2022 09:49:32 +0000 (UTC) X-FDA: 80058999384.08.2256154 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by imf10.hostedemail.com (Postfix) with ESMTP id DDBB9C0034 for ; Tue, 25 Oct 2022 09:49:31 +0000 (UTC) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 48A6C5FD03; Tue, 25 Oct 2022 12:49:29 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1666691369; bh=kS9Z1X/DqIKrCZgbFlzhtfGQRkZjQf1bNgDwTuLCDyQ=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=kxTRYUYLCno509qT91V4EDOdRNtkesbW9Kppo1J6BV0RJkc5RT0CTg+VIOWg0GG3g ssETNhmchTIYD/UygOYXsZH0qqbpdaHwp5KqDGuhsu368/OLCXQ7gqBMmWBBqiIr7l RW722vV3/35hRVbkSNpYbu9S+g/xuzjOZ71i1WFUQf4o9XppzUjKxGwIaoDwGwkuMZ 7fFgZJkOP8C1tYaYF051b7JDTsq0qd/NZgD6WQ1Ocx0IlLr6ykJe5aQhZjNjQXHaIQ mkcFzV74fOCterIS0U3BQhWJS5X0OQIsIQ0+yG1C9hI4jSCM2qqtv4A8riJrhu1j3W o4IZw+MmCxvSg== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Tue, 25 Oct 2022 12:49:27 +0300 (MSK) From: Aleksey Romanov To: Sergey Senozhatsky CC: Andrew Morton , "minchan@kernel.org" , "ngupta@vflare.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , kernel Subject: Re: [PATCH v1] zram: add size class equals check into recompression Thread-Topic: [PATCH v1] zram: add size class equals check into recompression Thread-Index: AQHY56FoneIKBPF3rEq28K0jaPH8QK4eJ6gAgAADEgCAAIHKAA== Date: Tue, 25 Oct 2022 09:49:22 +0000 Message-ID: <20221025094859.7kbcqknlkmo4hj2y@cab-wsm-0029881.lan> References: <20221024120942.13885-1-avromanov@sberdevices.ru> In-Reply-To: Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/10/25 05:11:00 #20514016 X-KSMG-AntiVirus-Status: Clean, skipped ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666691372; a=rsa-sha256; cv=none; b=aKrT6A02cm+CAxBH5LZC97oLEuSy+vz/IjZp6VSM2Z8Iw8jFZHgME49BgEjckRUKXMx2Ug Qmmzrvw1jxC4tqIQGV8Q6HskiphjWzEXONmONTfOo2+fuinyaWzMzNe5IyQpwha4LCuPDo GOABWul0cLGZt/loNP+Rq+uL6M8k2Is= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=sberdevices.ru header.s=mail header.b=kxTRYUYL; spf=pass (imf10.hostedemail.com: domain of AVRomanov@sberdevices.ru designates 45.89.227.171 as permitted sender) smtp.mailfrom=AVRomanov@sberdevices.ru; dmarc=pass (policy=quarantine) header.from=sberdevices.ru ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666691372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kS9Z1X/DqIKrCZgbFlzhtfGQRkZjQf1bNgDwTuLCDyQ=; b=ojuxfYfGkAAdqL2MYhcUPu+zoLI2spTU9qrxTvKzXr2XTrqELDgd0bhsfOC51W30/G4w98 aJRX0uD8acqXX/cvFoOOouY5t0nqa4yQlJWnLfXUVYqzM8+AdAa0qjfovPI8gosN/Qc70j CKqb+nYUx4EihuBLKX7JdDujLeS8NVo= X-Rspamd-Queue-Id: DDBB9C0034 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=sberdevices.ru header.s=mail header.b=kxTRYUYL; spf=pass (imf10.hostedemail.com: domain of AVRomanov@sberdevices.ru designates 45.89.227.171 as permitted sender) smtp.mailfrom=AVRomanov@sberdevices.ru; dmarc=pass (policy=quarantine) header.from=sberdevices.ru X-Rspamd-Server: rspam04 X-Stat-Signature: 7bdkx36fh85dr6nm8ttoa3u8axdzfsfq X-HE-Tag: 1666691371-686608 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000153, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 25, 2022 at 11:04:40AM +0900, Sergey Senozhatsky wrote: > On (22/10/25 10:53), Sergey Senozhatsky wrote: > > > +unsigned int zs_get_class_size(struct zs_pool *pool, unsigned int si= ze) > > > +{ > > > + struct size_class *class =3D pool->size_class[get_size_class_index(= size)]; > > > + > > > + return class->size; > > > +} > > > +EXPORT_SYMBOL_GPL(zs_get_class_size); > >=20 > > I'll kindly ask for v2. This conflicts with configurable zspage order > > patch set which I posted last night. get_size_class_index() now takes > > the pool parameter. >=20 > Oh, apparently Andrew already has a fixup patch for this. Hi! Thanks for the quick response. Do I need to submit v2 with a fix for >=3D? Also, I forgot to=20 correct the comment on the zs_get_class_size() function: > * Return: the size (in bytes) of the zsmalloc &size_class into which > * the object with specified size will be inserted. ... or already inserted. --=20 Thank you, Alexey=