From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F05C38A2D for ; Mon, 24 Oct 2022 15:00:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7967940009; Mon, 24 Oct 2022 11:00:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A02B3940007; Mon, 24 Oct 2022 11:00:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A39C940009; Mon, 24 Oct 2022 11:00:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7AC01940007 for ; Mon, 24 Oct 2022 11:00:21 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4E7B94067F for ; Mon, 24 Oct 2022 15:00:21 +0000 (UTC) X-FDA: 80056153842.28.5EE38F8 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf22.hostedemail.com (Postfix) with ESMTP id 604A1C000A for ; Mon, 24 Oct 2022 15:00:19 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 87F2B68B05; Mon, 24 Oct 2022 17:00:12 +0200 (CEST) Date: Mon, 24 Oct 2022 17:00:11 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Greg Kroah-Hartman , Dan Williams , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell , Stephen Bates Subject: Re: [PATCH v11 1/9] mm: allow multiple error returns in try_grab_page() Message-ID: <20221024150011.GA26338@lst.de> References: <20221021174116.7200-1-logang@deltatee.com> <20221021174116.7200-2-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221021174116.7200-2-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=none (imf22.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666623619; a=rsa-sha256; cv=none; b=lZWtmXytieCkUpfcJNNtRXsvB2l2ip1d/EjvLvsksWei/Bz31wFXHY9ytqLamVxqkhYT48 +61VN9wkm/VsrHMnH6jty4sTsWn4LW2KIToFs3HF3ji8HnLVEZSo0osg82HF1CP3S3+agj D0KeWPUN5s/IyrieJq1AiC7D0ezPldA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666623619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gHdxohgx99EHtkBH+aYtTknDrbPtrwJAuaizmc0RZRg=; b=0eJ/QUZmTUFkO/rmJIJ2/Zlq2iBzkqApAYDeEJm3+EueFBBorFiEHcwvZcqDgVCOSvRemD tUbdJzYGyvKA4X8ipSnK4Dzg7ZFuxKBO4x1pz2Fe8Ss+DV9hs4nwwU2VaC+XBj/jlul89F ZCG8OGXlMX8Va111yrPw2Tv8Fsjt9GM= X-Rspamd-Queue-Id: 604A1C000A X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=none; spf=none (imf22.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam11 X-Stat-Signature: daykum6wcyzj5xu3kmbg7wy13wjob9jw X-HE-Tag: 1666623619-297266 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 21, 2022 at 11:41:08AM -0600, Logan Gunthorpe wrote: > In order to add checks for P2PDMA memory into try_grab_page(), expand > the error return from a bool to an int/error code. Update all the > callsites handle change in usage. > > Also remove the WARN_ON_ONCE() call at the callsites seeing there > already is a WARN_ON_ONCE() inside the function if it fails. > > Signed-off-by: Logan Gunthorpe Looks good: Reviewed-by: Christoph Hellwig