From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E44FA3740 for ; Mon, 24 Oct 2022 20:17:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FA80940008; Mon, 24 Oct 2022 16:17:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AB24940007; Mon, 24 Oct 2022 16:17:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDC53940008; Mon, 24 Oct 2022 16:17:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DCC55940007 for ; Mon, 24 Oct 2022 16:17:09 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9C32D1A0CF5 for ; Mon, 24 Oct 2022 20:17:09 +0000 (UTC) X-FDA: 80056952178.27.63B84DD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 2AA1D100010 for ; Mon, 24 Oct 2022 20:17:08 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2031B6158D; Mon, 24 Oct 2022 20:17:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8445BC433C1; Mon, 24 Oct 2022 20:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1666642627; bh=pve3Synlkj6J6i7lSu93YkYeZZdRndbv6uz1vAXSx90=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T9EjYDwM/Ae7QhYWk18ZfQDUShXZj2tVAmRUMcw7GCIYWfPXvfAXhbguwEBsrXhI0 wsPM4qqXR81KWcOnxi51u0M+n6TRWkT3CGpttzRr8GtnOQHCzepzyWs60+otFFcc0p rjuz3SxOcz13igJ8VDFOBVeN0YX1DNxMpflHP9mo= Date: Mon, 24 Oct 2022 13:17:06 -0700 From: Andrew Morton To: Gautam Menghani Cc: rostedt@goodmis.org, mhiramat@kernel.org, zokeefe@google.com, shy828301@gmail.com, vbabka@suse.cz, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" Subject: Re: [PATCH v2] mm/khugepaged: add tracepoint to collapse_file() Message-Id: <20221024131706.3d58bd92c332684386c7df13@linux-foundation.org> In-Reply-To: <20221024173559.332324-1-gautammenghani201@gmail.com> References: <20221024173559.332324-1-gautammenghani201@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666642629; a=rsa-sha256; cv=none; b=NogVfHypg7LCbyvLMnAoeFeBOCcFXEiNPnKzqqPEEpFY3SEcCLsxxc0BvZx3XEedr5heF2 Suf/LdqhSj3rjGXuAjkW81ATXTGy+470A47fvf481/04A5I4LUgUq18Zlj+gpc8O/xEo6Z AMPl9a57M6JS/1kcGPaWNnD9+2ihNz4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=T9EjYDwM; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666642629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J8dief6RmUvmD02OG/vcLMjVH95bCM+Z/jlWfHifmfc=; b=lljfeilNC9WoKF/gLjcKBIgaU8CndpOqiv1xgY6T30LgdbrWVb0qbrR68NRl6pYXbZ5wsA BrZShiDMRbqjvsvGRgvKTN2EfDkQEQyT/rzz3qunFmgeTHmU9MB9ncB+NhfP6zraKzovCm qbbEBVJFqninS/zyAgBfzlwTzQToTjk= X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=T9EjYDwM; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam11 X-Stat-Signature: r99asqn85kd7qtiw9knqio3dgsy3y4xs X-Rspamd-Queue-Id: 2AA1D100010 X-HE-Tag: 1666642628-988795 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 24 Oct 2022 23:05:58 +0530 Gautam Menghani wrote: > In the file mm/khugepaged.c, a TODO in the function collapse_file() asks > to add tracepoints. Add the tracepoint named "mm_khugepaged_collapse_file". This isn't a very satisfying explanation for changing the kernel. Maybe the comment is stale are this tracepoint is unneeded. Please explain afresh how this addition benefits kernel users?