From: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Miaohe Lin <linmiaohe@huawei.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mm: memory-failure: make action_result() return int
Date: Mon, 24 Oct 2022 07:35:52 +0000 [thread overview]
Message-ID: <20221024073552.GA4043713@hori.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <20221024035138.99119-1-wangkefeng.wang@huawei.com>
On Mon, Oct 24, 2022 at 11:51:38AM +0800, Kefeng Wang wrote:
> Check mf_result in action_result(), only return 0 when
> MF_RECOVERED/MF_DELAYED, or return -EBUSY, which will
> simplify code a bit.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> v2:
> - MF_DELAYED is considered as success, suggested by HORIGUCHI
> - adjust order between unlock_page(head) and action_result()
> after !hwpoison_user_mappings() to clean code more in
> try_memory_failure_hugetlb()
>
Thank you for the update. The patch looks good to me.
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
next prev parent reply other threads:[~2022-10-24 7:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 8:46 [PATCH 1/3] mm: memory-failure: make put_ref_page() more useful Kefeng Wang
2022-10-21 8:46 ` [PATCH 2/3] mm: memory-failure: avoid pfn_valid() twice in soft_offline_page() Kefeng Wang
2022-10-23 23:39 ` HORIGUCHI NAOYA(堀口 直也)
2022-10-25 2:55 ` Miaohe Lin
2022-10-21 8:46 ` [PATCH 3/3] mm: memory-failure: make action_result() return int Kefeng Wang
2022-10-23 23:56 ` HORIGUCHI NAOYA(堀口 直也)
2022-10-24 1:39 ` Kefeng Wang
2022-10-24 3:51 ` [PATCH v2] " Kefeng Wang
2022-10-24 7:35 ` HORIGUCHI NAOYA(堀口 直也) [this message]
2022-10-25 3:07 ` Miaohe Lin
2022-10-23 23:38 ` [PATCH 1/3] mm: memory-failure: make put_ref_page() more useful HORIGUCHI NAOYA(堀口 直也)
2022-10-25 2:52 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024073552.GA4043713@hori.linux.bs1.fc.nec.co.jp \
--to=naoya.horiguchi@nec.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox