linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/1] mm/page_isolation: fix clang deadcode warning
@ 2022-10-21 10:15 Maria Yu
  2022-10-21 10:15 ` [PATCH v3 1/1] " Maria Yu
  0 siblings, 1 reply; 2+ messages in thread
From: Maria Yu @ 2022-10-21 10:15 UTC (permalink / raw)
  To: akpm, ziy, david, linux-kernel, linux-mm; +Cc: Maria Yu, mike.kravetz, opendmb

When !CONFIG_VM_BUG_ON, there is warning of
clang-analyzer-deadcode.DeadStores:
Value stored to 'mt' during its initialization
is never read.

Changelog
===
V3
---

Difference with previous patch is use __maybe_unused
suggested by David.

V2
---
Difference with previous patch is just to make it
new lines as it is too long for single line.

Feel free to give comments and suggestions. Thanks.

previous discussion here:
[1] https://lore.kernel.org/linux-mm/20221021030953.34925-1-quic_aiquny@quicinc.com/
[2] https://lore.kernel.org/linux-mm/20221021051936.15346-1-quic_aiquny@quicinc.com/

Maria Yu (1):
  mm/page_isolation: fix clang deadcode warning

 mm/page_isolation.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v3 1/1] mm/page_isolation: fix clang deadcode warning
  2022-10-21 10:15 [PATCH v3 0/1] mm/page_isolation: fix clang deadcode warning Maria Yu
@ 2022-10-21 10:15 ` Maria Yu
  0 siblings, 0 replies; 2+ messages in thread
From: Maria Yu @ 2022-10-21 10:15 UTC (permalink / raw)
  To: akpm, ziy, david, linux-kernel, linux-mm; +Cc: Maria Yu, mike.kravetz, opendmb

When !CONFIG_VM_BUG_ON, there is warning of
clang-analyzer-deadcode.DeadStores:
Value stored to 'mt' during its initialization
is never read.

Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>
---
 mm/page_isolation.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_isolation.c b/mm/page_isolation.c
index 04141a9bea70..47fbc1696466 100644
--- a/mm/page_isolation.c
+++ b/mm/page_isolation.c
@@ -330,7 +330,7 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags,
 				      zone->zone_start_pfn);
 
 	if (skip_isolation) {
-		int mt = get_pageblock_migratetype(pfn_to_page(isolate_pageblock));
+		int mt __maybe_unused = get_pageblock_migratetype(pfn_to_page(isolate_pageblock));
 
 		VM_BUG_ON(!is_migrate_isolate(mt));
 	} else {
-- 
2.17.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-21 10:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-21 10:15 [PATCH v3 0/1] mm/page_isolation: fix clang deadcode warning Maria Yu
2022-10-21 10:15 ` [PATCH v3 1/1] " Maria Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox