From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 261C2C4332F for ; Fri, 21 Oct 2022 05:20:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 880EF8E0003; Fri, 21 Oct 2022 01:20:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 830B48E0001; Fri, 21 Oct 2022 01:20:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F8CE8E0003; Fri, 21 Oct 2022 01:20:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 613B88E0001 for ; Fri, 21 Oct 2022 01:20:06 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 373D740BA3 for ; Fri, 21 Oct 2022 05:20:06 +0000 (UTC) X-FDA: 80043805212.27.4CD901A Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf12.hostedemail.com (Postfix) with ESMTP id D631B4002A for ; Fri, 21 Oct 2022 05:20:05 +0000 (UTC) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29L57j8i016953; Fri, 21 Oct 2022 05:20:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=6nW+WJlBFsHk7JFin27cvLWx+IgUry3lsfRoYGa70l4=; b=Dds7efkJ3W0nG9xR6l1rrrJWsyziT/q+H+YIT4fTLmemXbW6FLM6AJI99dI8gmU3eXYd Aj/nZW+rC2Gy2lFRjRFW7XsWld4wl/sjIdTpz1ecKtReKkASR72rbIP3LG5KV9+2cRay yQVA7Z+ybWv/91phzwud5muMK2oZ71FHenKVJ4bCiiyPc+Evaygdaa6V8ZzNjU2aaXBT VcWSUSV8soNShRvlEJ/CIK6/G8eoIUPdtFNzcjbMg8QVBVYtF8pipYKdLkSt9vzfgXVi JFMuxbuMKCysNDEvoFnqdPDSRcWnPJkL57YNz2ewPtmtFNsmexC7G5b/0x5okFV3TrDn 9A== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3kb5pyj6vs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Oct 2022 05:20:04 +0000 Received: from pps.filterd (NASANPPMTA01.qualcomm.com [127.0.0.1]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 29L5K3Wv009762; Fri, 21 Oct 2022 05:20:03 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NASANPPMTA01.qualcomm.com (PPS) with ESMTPS id 3kaa8crqty-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Oct 2022 05:20:03 +0000 Received: from NASANPPMTA01.qualcomm.com (NASANPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 29L5K3gM009749; Fri, 21 Oct 2022 05:20:03 GMT Received: from nasanex01a.na.qualcomm.com (corens_vlan604_snip.qualcomm.com [10.53.140.1]) by NASANPPMTA01.qualcomm.com (PPS) with ESMTPS id 29L5K3IW009747 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Oct 2022 05:20:03 +0000 Received: from aiquny2-gv.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 20 Oct 2022 22:20:01 -0700 From: Maria Yu To: , , , , CC: Maria Yu , , Subject: [PATCH v2 1/1] mm/page_isolation: fix clang deadcode warning Date: Fri, 21 Oct 2022 13:19:36 +0800 Message-ID: <20221021051936.15346-2-quic_aiquny@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221021051936.15346-1-quic_aiquny@quicinc.com> References: <20221021051936.15346-1-quic_aiquny@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: KkP45b8xa0BfHK9rPi1IOtgADjuYQA6k X-Proofpoint-ORIG-GUID: KkP45b8xa0BfHK9rPi1IOtgADjuYQA6k X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-21_01,2022-10-20_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 malwarescore=0 clxscore=1015 mlxlogscore=658 phishscore=0 bulkscore=0 mlxscore=0 adultscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210210030 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666329605; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6nW+WJlBFsHk7JFin27cvLWx+IgUry3lsfRoYGa70l4=; b=DD7sE3BDl81nqZSFmYLLS9X9BpktQ2kMO3hs5iWGFDxz8jvs1feXhSajOYjSmyjbBQMyba Z7UJBDZmBf1Ngby2yIWQpl4OVl06lKUc4iv5eViqyuXkkJIqcMv+iOcG/iopKXg40bKvSV YYJn1I5g2Bvw9P8fFtn/+ukByqVIQzM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=Dds7efkJ; spf=pass (imf12.hostedemail.com: domain of quic_aiquny@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_aiquny@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666329605; a=rsa-sha256; cv=none; b=q9fG5VKl3HJzh5VjWUoA7bcIGIcIzzNPhRP+TK9X//XSsm50PJENkmjSdDKjvXvWje59uD kiy6NBh6LSKm/sktYjY6SV93LKRS1SsA8ySsL1toyRqzCb46Ihui7yy2UM/aa2sVJaJ3ef mPWsEsBNH1PVjUAhdnfPpuCN4+YTBbQ= Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=Dds7efkJ; spf=pass (imf12.hostedemail.com: domain of quic_aiquny@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_aiquny@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D631B4002A X-Stat-Signature: few6kqwn5tkb45uo4ju1ww1w3juea6bw X-Rspam-User: X-HE-Tag: 1666329605-678253 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When !CONFIG_VM_BUG_ON, there is warning of clang-analyzer-deadcode.DeadStores: Value stored to 'mt' during its initialization is never read. Signed-off-by: Maria Yu --- mm/page_isolation.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/page_isolation.c b/mm/page_isolation.c index 04141a9bea70..a7a478a22123 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -330,9 +330,8 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags, zone->zone_start_pfn); if (skip_isolation) { - int mt = get_pageblock_migratetype(pfn_to_page(isolate_pageblock)); - - VM_BUG_ON(!is_migrate_isolate(mt)); + VM_BUG_ON(!is_migrate_isolate(get_pageblock_migratetype( + pfn_to_page(isolate_pageblock)))); } else { ret = set_migratetype_isolate(pfn_to_page(isolate_pageblock), migratetype, flags, isolate_pageblock, isolate_pageblock + pageblock_nr_pages); -- 2.17.1