From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF22C433FE for ; Fri, 21 Oct 2022 04:17:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83B178E0002; Fri, 21 Oct 2022 00:17:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EAAE8E0001; Fri, 21 Oct 2022 00:17:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D9548E0002; Fri, 21 Oct 2022 00:17:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5B7AD8E0001 for ; Fri, 21 Oct 2022 00:17:38 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2F1D7A0A0C for ; Fri, 21 Oct 2022 04:17:38 +0000 (UTC) X-FDA: 80043647796.25.19DE601 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id BEFB3C0014 for ; Fri, 21 Oct 2022 04:17:37 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1302161DA4; Fri, 21 Oct 2022 04:17:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29841C433C1; Fri, 21 Oct 2022 04:17:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1666325854; bh=pHUX7kQhg+qJZIQCthaob3/LECmst3jbCdEp9qpk9tA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GDu9CVVG8Jxiy18xdfkINdxM/4UphCMFnRgUFQkHKeG3xCR+hzR1EqLE4+TCeVcZw 30ljUr8xk9N8l2hixS5QhG+0w/nQyIm6B9aT7GCxahqS4Jxn+49OCaK1mBdaBFMqys BnYKneLphVG+Hfl1wTc0m/uT8qwMxUQhtageyPW0= Date: Thu, 20 Oct 2022 21:17:33 -0700 From: Andrew Morton To: "Aiqun(Maria) Yu" Cc: Matthew Wilcox , , , , , , Subject: Re: [PATCH] mm/page_isolation: fix clang deadcode warning Message-Id: <20221020211733.31b2ee4f81805186367304b0@linux-foundation.org> In-Reply-To: <23081249-229b-b745-50f5-53e394b623c9@quicinc.com> References: <20221021030953.34925-1-quic_aiquny@quicinc.com> <23081249-229b-b745-50f5-53e394b623c9@quicinc.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666325857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v0/0bqTdsNrLLLpA1302Fzid78rZEZQZlMOI1D8+Rwo=; b=ZiqVKFZ7zIAFdGNmsOUz9F8p6VG92IaZSFmNSCG+vFZQmLVcsRJ9rTUj4Smzffdw0tTcsl GsX31aSMTrLXCtJJTgt2N7t/7szxwKY1T832GWiXAPd5RyEhtDsBcALy0vNyu90+ZT4vz0 PHaSDrVM4mSKlL4mPx0xlySQWx5dNRk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GDu9CVVG; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666325857; a=rsa-sha256; cv=none; b=0bHjGUSYPkTt6qmZNfl7INlsJb3EgXFZUkFloGD5oAjFS2oRFx6KZ7i300Gjgjg8kx9F4H 66UHPTuJtrI8EHfkgjccH6/ZE6y4Ztd+K5XC8il82bBCfpT4CjWX3bWpYCF5CfOKvJR2aq 2+CyoM4jr8fu9GiRce4/4tKGsG2u7A8= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BEFB3C0014 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GDu9CVVG; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: wdfkw3j1xekrd1tagqe6tgx9wccyne6b X-HE-Tag: 1666325857-126849 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 21 Oct 2022 11:26:22 +0800 "Aiqun(Maria) Yu" wrote: > > Honestly, the cure is worse than the disease. I'd rather not have a > > line that's this long. > I don't like this long either. While the current Deadcode warning is > also annoying for our clang tidy check. > > will the CONFIG check can be acceptable? > like: > #ifdef CONFIG_DEBUG_VM > or > if (IS_ENABLED(CONFIG_DEBUG_VM)) > > Any good ideas? Put a newline in there? Although the shortly following lines are nearly as long...