From: Andrew Morton <akpm@linux-foundation.org>
To: "Aiqun(Maria) Yu" <quic_aiquny@quicinc.com>
Cc: Matthew Wilcox <willy@infradead.org>, <ziy@nvidia.com>,
<david@redhat.com>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <mike.kravetz@oracle.com>,
<opendmb@gmail.com>
Subject: Re: [PATCH] mm/page_isolation: fix clang deadcode warning
Date: Thu, 20 Oct 2022 21:17:33 -0700 [thread overview]
Message-ID: <20221020211733.31b2ee4f81805186367304b0@linux-foundation.org> (raw)
In-Reply-To: <23081249-229b-b745-50f5-53e394b623c9@quicinc.com>
On Fri, 21 Oct 2022 11:26:22 +0800 "Aiqun(Maria) Yu" <quic_aiquny@quicinc.com> wrote:
> > Honestly, the cure is worse than the disease. I'd rather not have a
> > line that's this long.
> I don't like this long either. While the current Deadcode warning is
> also annoying for our clang tidy check.
>
> will the CONFIG check can be acceptable?
> like:
> #ifdef CONFIG_DEBUG_VM
> or
> if (IS_ENABLED(CONFIG_DEBUG_VM))
>
> Any good ideas?
Put a newline in there?
Although the shortly following lines are nearly as long...
next prev parent reply other threads:[~2022-10-21 4:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 3:09 Maria Yu
2022-10-21 3:19 ` Matthew Wilcox
2022-10-21 3:26 ` Aiqun(Maria) Yu
2022-10-21 4:17 ` Andrew Morton [this message]
2022-10-21 5:21 ` Aiqun(Maria) Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020211733.31b2ee4f81805186367304b0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=opendmb@gmail.com \
--cc=quic_aiquny@quicinc.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox