From: Liam Howlett <liam.howlett@oracle.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Seth Jenkins <sethjenkins@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: /proc/pid/smaps_rollup: fix maple tree search
Date: Thu, 20 Oct 2022 15:31:25 +0000 [thread overview]
Message-ID: <20221020153101.425njbgquuu6ezv3@revolver> (raw)
In-Reply-To: <3011bee7-182-97a2-1083-d5f5b688e54b@google.com>
Thanks Hugh. I guess this 'optimisation' was a little more aggressive
and a little more buggy than needed.
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
* Hugh Dickins <hughd@google.com> [221018 23:18]:
> /proc/pid/smaps_rollup showed 0 kB for everything: now find first vma.
>
> Fixes: c4c84f06285e ("fs/proc/task_mmu: stop using linked list and highest_vm_end")
> Signed-off-by: Hugh Dickins <hughd@google.com>
> ---
>
> fs/proc/task_mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 6.1-rc1/fs/proc/task_mmu.c
> +++ linux/fs/proc/task_mmu.c
> @@ -902,7 +902,7 @@ static int show_smaps_rollup(struct seq_
> goto out_put_mm;
>
> hold_task_mempolicy(priv);
> - vma = mas_find(&mas, 0);
> + vma = mas_find(&mas, ULONG_MAX);
>
> if (unlikely(!vma))
> goto empty_set;
prev parent reply other threads:[~2022-10-20 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 3:18 Hugh Dickins
2022-10-20 15:31 ` Liam Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020153101.425njbgquuu6ezv3@revolver \
--to=liam.howlett@oracle.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sethjenkins@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox