From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC0BC43219 for ; Wed, 19 Oct 2022 23:32:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55BF76B0071; Wed, 19 Oct 2022 19:32:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50D8F6B0073; Wed, 19 Oct 2022 19:32:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FC6F6B0074; Wed, 19 Oct 2022 19:32:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3066E6B0071 for ; Wed, 19 Oct 2022 19:32:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0A18D1C5E15 for ; Wed, 19 Oct 2022 23:32:06 +0000 (UTC) X-FDA: 80039299452.28.5940094 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 95F65C0039 for ; Wed, 19 Oct 2022 23:32:05 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 93F456101F; Wed, 19 Oct 2022 23:32:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68C04C433B5; Wed, 19 Oct 2022 23:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1666222323; bh=n2ewGIoOoQ0xjDm3+ym1Q7RG9dkwD2HTi2Am3VIhXM0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oZohpQa1CdCHvVB31KH/zY6estnojxNW0VFQso9RRXxKytes7qPty30TQCCp9ZGZl Qpb27Ej6zTjazx8ZBF9M5KjDWbMwdxZHu2wlNp8tAbUThkYYi/kzMv+8oZFZXO1ARg e6xgXA7XZzvZnV7iw3StM4P8C877ffBTcjc2upIY= Date: Wed, 19 Oct 2022 16:32:02 -0700 From: Andrew Morton To: kernel test robot Cc: Dan Williams , kbuild-all@lists.01.org, Ammar Faizi , GNU/Weeb Mailing List , linux-kernel@vger.kernel.org, Linux Memory Management List Subject: Re: [ammarfaizi2-block:akpm/mm/mm-unstable 39/119] mm/memremap.c:521:6: warning: no previous prototype for 'zone_device_page_init' Message-Id: <20221019163202.500fd181836f47dce6bd81c1@linux-foundation.org> In-Reply-To: <202210191735.jdAY5fBg-lkp@intel.com> References: <202210191735.jdAY5fBg-lkp@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666222325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bk8jIdY/fph3xDY2nr2zlir2J49JPnqPfxEke+7jNMc=; b=z9xk5lHLcfdv8WELVmUn/L11RintBl/qtlGqVcc5TBQ+gbMgwOSssKcVTnFkzKvEcFKdWK UOXrOLINVYcmeqJdfgrZ9VQk+wtDjgwIYtOCaGz3Yw/5FXTQ+Dy6NJKDbZ9XrfgYul+agL SWBU3hum0I3sSFNpgXEdG+GewtPxQMM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oZohpQa1; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666222325; a=rsa-sha256; cv=none; b=WRkPVkiyShU5oTVnp5zEHkFJNZXl0tPGQOjVWEdg6nhfmDpo513XihvaqXfjpqRe4dDgvE bD820WKH4J76VieQ0milgnRWCru16N/UC89UgQ6ObVCXYpzXlWj8/4+pJSzFXiLPprY09G Yyb8g851Su7eqTjvfUM2F+2xdZbpG0g= X-Rspamd-Server: rspam12 X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oZohpQa1; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: 4u7yzri41j63ejzfurena9ua4i9wmajg X-Rspamd-Queue-Id: 95F65C0039 X-HE-Tag: 1666222325-386840 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 19 Oct 2022 17:17:36 +0800 kernel test robot wrote: > >> mm/memremap.c:521:6: warning: no previous prototype for 'zone_device_page_init' [-Wmissing-prototypes] > 521 | void zone_device_page_init(struct page *page) > | ^~~~~~~~~~~~~~~~~~~~~ huh, sorry, I must have fat-fingered the reject resolution on that one. --- a/mm/memremap.c~mm-memremap_pages-replace-zone_device_page_init-with-pgmap_request_folios-fix +++ a/mm/memremap.c @@ -518,18 +518,6 @@ void free_zone_device_page(struct page * put_dev_pagemap(page->pgmap); } -void zone_device_page_init(struct page *page) -{ - /* - * Drivers shouldn't be allocating pages after calling - * memunmap_pages(). - */ - WARN_ON_ONCE(!percpu_ref_tryget_live(&page->pgmap->ref)); - set_page_count(page, 1); - lock_page(page); -} -EXPORT_SYMBOL_GPL(zone_device_page_init); - static __maybe_unused bool folio_span_valid(struct dev_pagemap *pgmap, struct folio *folio, int nr_folios) _