From: Andrew Morton <akpm@linux-foundation.org>
To: kernel test robot <lkp@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
kbuild-all@lists.01.org, Ammar Faizi <ammarfaizi2@gnuweeb.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
linux-kernel@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [ammarfaizi2-block:akpm/mm/mm-unstable 39/119] mm/memremap.c:521:6: warning: no previous prototype for 'zone_device_page_init'
Date: Wed, 19 Oct 2022 16:32:02 -0700 [thread overview]
Message-ID: <20221019163202.500fd181836f47dce6bd81c1@linux-foundation.org> (raw)
In-Reply-To: <202210191735.jdAY5fBg-lkp@intel.com>
On Wed, 19 Oct 2022 17:17:36 +0800 kernel test robot <lkp@intel.com> wrote:
> >> mm/memremap.c:521:6: warning: no previous prototype for 'zone_device_page_init' [-Wmissing-prototypes]
> 521 | void zone_device_page_init(struct page *page)
> | ^~~~~~~~~~~~~~~~~~~~~
huh, sorry, I must have fat-fingered the reject resolution on that one.
--- a/mm/memremap.c~mm-memremap_pages-replace-zone_device_page_init-with-pgmap_request_folios-fix
+++ a/mm/memremap.c
@@ -518,18 +518,6 @@ void free_zone_device_page(struct page *
put_dev_pagemap(page->pgmap);
}
-void zone_device_page_init(struct page *page)
-{
- /*
- * Drivers shouldn't be allocating pages after calling
- * memunmap_pages().
- */
- WARN_ON_ONCE(!percpu_ref_tryget_live(&page->pgmap->ref));
- set_page_count(page, 1);
- lock_page(page);
-}
-EXPORT_SYMBOL_GPL(zone_device_page_init);
-
static __maybe_unused bool folio_span_valid(struct dev_pagemap *pgmap,
struct folio *folio,
int nr_folios)
_
prev parent reply other threads:[~2022-10-19 23:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 9:17 kernel test robot
2022-10-19 23:32 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019163202.500fd181836f47dce6bd81c1@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=dan.j.williams@intel.com \
--cc=gwml@vger.gnuweeb.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox