From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9688FC4332F for ; Wed, 19 Oct 2022 17:30:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD20B6B0072; Wed, 19 Oct 2022 13:30:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C82DC6B0073; Wed, 19 Oct 2022 13:30:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4B356B0074; Wed, 19 Oct 2022 13:30:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A52BF6B0072 for ; Wed, 19 Oct 2022 13:30:57 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 368001A1159 for ; Wed, 19 Oct 2022 17:30:57 +0000 (UTC) X-FDA: 80038389354.18.015C682 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf26.hostedemail.com (Postfix) with ESMTP id C98FA14003F for ; Wed, 19 Oct 2022 17:30:56 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id m6so17920728pfb.0 for ; Wed, 19 Oct 2022 10:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BFRWd7vrrVi87eI0lxP0gM69HCWszoFdIqs2so5GqDM=; b=PLA2JsXSqysIna9tFsBBdRao1dBwSMRZlrn2O4ICeRbBe5gsyCf5q5bEFsXF9vUtDX TXaCAoVe7QSjqWw121MB5fezIxVesfDN6kE6K2l9eCB6P2R3rsBFsysJJ6uhkRiwxJKQ NO7mHzl2sjp2PXwq4CHkGWD8d8/TFlfObI96g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BFRWd7vrrVi87eI0lxP0gM69HCWszoFdIqs2so5GqDM=; b=ffRyMJoYMD53NjjsO0Bg0MZdBPYjoxQ+C1AX+XyI0X1hN91+mjWvTjX7VK9OYuz1KI QpuGX828IZpHCYwwPaobLw6G8batOo0wrxwrb9zbN4No+WUNmTSzwBAHXnuDgKR21EE8 5IOk+4g+by1j53FaMQTV/gCbKkCZvi0bez/Qyyi4oB+tn2B49m7xZ7t8v/9gufnZlHRa twAjiTAywAC2Ty5fgjPkw4RDiiBqe8vpDxgiMdhj++fe4X5wq8C8byyy8SOXl2hAU/Q8 QbEZXfVjxgnE175hTeLvfNc2eu9hLMAnCsmvOA0JxuFuITZTConMfDz/Fcg6L0MGtL00 oOxQ== X-Gm-Message-State: ACrzQf2FY0c9MPfhyWEhiqpEf+K3wtKgtRuv0jp4K7KvJd8U+dYNN52p +eWAeE08akg7h47k9z64XjhChg== X-Google-Smtp-Source: AMsMyM4gAkNhkfp5Wn6ILtVnqTHzHGxHn7Atp68r74eXi9ayCN2sLc++Ufsg28bF8QWE6YPcIHPnIQ== X-Received: by 2002:a63:4a41:0:b0:452:bab5:156a with SMTP id j1-20020a634a41000000b00452bab5156amr8132651pgl.486.1666200655754; Wed, 19 Oct 2022 10:30:55 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c3-20020a170902d48300b00178b6ccc8a0sm11073833plg.51.2022.10.19.10.30.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 10:30:55 -0700 (PDT) Date: Wed, 19 Oct 2022 10:30:54 -0700 From: Kees Cook To: Alexander Potapenko Cc: Nathan Chancellor , Andrew Morton , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kasan-dev@googlegroups.com, linux-mm@kvack.org Subject: Re: -Wmacro-redefined in include/linux/fortify-string.h Message-ID: <202210191030.EC5C138E@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666200656; a=rsa-sha256; cv=none; b=QNYatFBmagDRwweK4rs1eQwK8O0ivVKyCJut9ri1SNEDFZL1CtsYDl2/+4QRZNPaXFvHYH 3sDZz9lMwK/5hLsoO/GsE9bTCpVqy6+X+qzWg6SeblHiiN+54Z7hLU9tg8DXsTNfXyPD// AwNs3HZhnS1dw2B4RX/CmrXnB5/O3AA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=PLA2JsXS; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf26.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666200656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BFRWd7vrrVi87eI0lxP0gM69HCWszoFdIqs2so5GqDM=; b=KzWbhdY3kBryvjV6ER/9mTDwFCYiB3/Tjp/Cw+J/CRRjSk+2o56ouS3llR89QxCmMxTvEY uoLaR5XPoDjJmNNXwjOr0yR+VAUKAIvZ4CNOIYwU05mH3cKELa0bf8UD8z6dGXE9JVdY1R 61kTb7FIACbqSRhTF/9L6RsIRMIC3yc= X-Stat-Signature: 58t83oywiefxok864ahiq1mm9bjd7j6g X-Rspamd-Queue-Id: C98FA14003F X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=PLA2JsXS; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf26.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Rspamd-Server: rspam11 X-HE-Tag: 1666200656-876118 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 19, 2022 at 09:48:27AM -0700, Alexander Potapenko wrote: > On Wed, Oct 19, 2022 at 8:37 AM Nathan Chancellor wrote: > > > > Hi all, > > > > I am seeing the following set of warnings when building an x86_64 > > configuration that has CONFIG_FORTIFY_SOURCE=y and CONFIG_KMSAN=y: > > I was also looking into this issue recently, because people start > running into it: https://github.com/google/kmsan/issues/89 > > I have a solution that redefines __underlying_memXXX to __msan_memXXX > under __SANITIZE_MEMORY__ in fortify-string.h and skips `#define > memXXX __msan_memXXX` in string_64.h, making KMSAN kinda work with > FORTIFY_SOURCE. Oh good! > Dunno if that's necessary though: KMSAN is a debugging tool anyway, > and supporting it in fortify-string.h sounds excessive. I'd much prefer letting them still work together. -- Kees Cook