From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBFBEC4332F for ; Wed, 19 Oct 2022 00:17:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B06B6B0074; Tue, 18 Oct 2022 20:17:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65F756B0075; Tue, 18 Oct 2022 20:17:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5275C6B0078; Tue, 18 Oct 2022 20:17:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 439256B0074 for ; Tue, 18 Oct 2022 20:17:36 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1F66A8047F for ; Wed, 19 Oct 2022 00:17:36 +0000 (UTC) X-FDA: 80035785312.21.612C165 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by imf11.hostedemail.com (Postfix) with ESMTP id 5E43440031 for ; Wed, 19 Oct 2022 00:17:35 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 609D232005D8; Tue, 18 Oct 2022 20:17:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 18 Oct 2022 20:17:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1666138651; x=1666225051; bh=Zs rr5zTY02howzem/uvI6lDyxx0n45EbNI50IgAhUQI=; b=IekZB6N9aXmmp56dDq AGYDZPjs8E8Embg0az0P7eZ9n8tRRlGNNDOXryCpMXrKYNhuBRwA4/4WPHvwh5ON jOeZ12EjTF6wds2wejtrrCTeSQaomXjL/v9gbLH10hLXyjW1iKO1j2QCT/XMkqXl GL/ugr9lYS3EMHsKjG/ztjBv67WHTbh9I6lv4VGKXsd6aH1RskzZhk6lM6VnttLW lJ0GARrdwvsWxTPQmtQG3Z5VoTbtK/7YJOy5DE4lfqn5t+Ox9rU9dwnC7oV4s+bz OyahTkuhyM6V9vBlwfH4Z81G1D3/jMsVZdKlaw6p7AmDnF2gFtOCcER541IKWOqg QTcA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666138651; x=1666225051; bh=Zsrr5zTY02howzem/uvI6lDyxx0n 45EbNI50IgAhUQI=; b=fKmR60Lv+g7sxHHF/buBNNOaiofDe5SvlSZdQqetpZY+ jJljp5xTlx5IJzTGM3i+IF74xp9EfmshbhJIAD9wMqtMgzrG2J//IBorNW3QRD6/ 3MnJ6BjchFYWPyKs1t0yUik9otojIOaqADMERKc9XcW6KtNBsBLFAqlJ4+iOgdc2 Ev/RrHTgRQRgsPPFpg0CWMOUPaPTZknk1q9pHA5rqReGJXaAyYsrcyZ1HUbOrYlq dbRqRyhfP+FLbumsJ7nOyM1caD5EA4SPc08jrTrehBEBIK7LoD/yj3La4jrEywnK tJEoZ488L6AoV6cdNcw52Afcfcuu/m9wbCZqY4kBcA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeelfedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdttddttddtvdenucfhrhhomhepfdfmihhr ihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnh grmhgvqeenucggtffrrghtthgvrhhnpefhieeghfdtfeehtdeftdehgfehuddtvdeuheet tddtheejueekjeegueeivdektdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhvrdhnrghmvg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Oct 2022 20:17:31 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id 5C2781068AD; Wed, 19 Oct 2022 03:17:28 +0300 (+03) Date: Wed, 19 Oct 2022 03:17:28 +0300 From: "Kirill A. Shutemov" To: Dave Hansen Cc: "Kirill A. Shutemov" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Alexander Potapenko , Taras Madan , Dmitry Vyukov , "H . J . Lu" , Andi Kleen , Rick Edgecombe , Bharata B Rao , Jacob Pan , Ashok Raj , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv10 10/15] x86/mm, iommu/sva: Make LAM and SVM mutually exclusive Message-ID: <20221019001728.jvjtrkoe7aqmhfww@box.shutemov.name> References: <20221018113358.7833-1-kirill.shutemov@linux.intel.com> <20221018113358.7833-11-kirill.shutemov@linux.intel.com> <20221018223341.tiyypudh6k63mnnb@box.shutemov.name> <3a0dd700-ce2e-e1ec-ee8b-74cd68c360b7@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a0dd700-ce2e-e1ec-ee8b-74cd68c360b7@intel.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666138655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zsrr5zTY02howzem/uvI6lDyxx0n45EbNI50IgAhUQI=; b=nj+cBiQNnjJHFEaMVqVWksACEGogaetFGbgSan3Bb7xOFtRk80vhLn037vuKyVa4Q6Eg0l 5Sva1sSOS4ZvpF0GZd6+WWUH1nqXEXMuZmkz226ubNa1HJGDO8ImY84Fa3PTEq2IdZQ3yt 3QIOwe0c1CqKt43+qLQAXFi/NpgfqQs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b=IekZB6N9; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=fKmR60Lv; spf=pass (imf11.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.24 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666138655; a=rsa-sha256; cv=none; b=NuPEfcF6tvSAwN80+nBBahJ42XlU5G4wHc7OCcyyLmbDHwQ2Olab+MNX6Qh0ona+exnQaN ZdkUD+xHwH19vE5YdxUX9fwLwDFQ9um9ekmNeYO5jZEWSeMP/DIsRKjZz+gyvoc88TBAfW CYEOu/VHOvNrlAU5loX+eFR96fGBmsA= X-Rspamd-Server: rspam12 X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b=IekZB6N9; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=fKmR60Lv; spf=pass (imf11.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.24 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Stat-Signature: znn1zqo4jbuk5f1rwye5bpzt9zgn9fun X-Rspamd-Queue-Id: 5E43440031 X-HE-Tag: 1666138655-408832 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 18, 2022 at 03:43:24PM -0700, Dave Hansen wrote: > On 10/18/22 15:33, Kirill A. Shutemov wrote: > >> Is this #ifdef really necessary? CONFIG_IOMMU_SVA selects IOASID, > >> without which pasid_valid() is just stubbed out to 0. > > mm->pasid is only defined for CONFIG_IOMMU_SVA=y. > > > > Do you want me to add mm_has_valid_pasid()? > > A quick grep makes it look like pasid_valid() could be *replaced* with > mm_has_pasid_valid() since all the places doing pasid_valid() do it with > mm->pasid. Almost: the second pasid_valid() in iommu_sva_alloc_pasid() called for just allocated pasid. I guess we can just opencode this case. -- Kiryl Shutsemau / Kirill A. Shutemov