From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B97C433FE for ; Tue, 18 Oct 2022 22:51:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7409E6B0071; Tue, 18 Oct 2022 18:51:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CAB36B0072; Tue, 18 Oct 2022 18:51:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 574276B0073; Tue, 18 Oct 2022 18:51:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 44DB66B0071 for ; Tue, 18 Oct 2022 18:51:40 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1FCD616037E for ; Tue, 18 Oct 2022 22:51:40 +0000 (UTC) X-FDA: 80035568760.05.E5DDA1A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id BE7F5100026 for ; Tue, 18 Oct 2022 22:51:39 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BA31261707; Tue, 18 Oct 2022 22:51:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01BB5C433C1; Tue, 18 Oct 2022 22:51:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1666133498; bh=PLolGzFjkspOWqmPEYf07SMZh4xTpXtSwabOm4Hm2xI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=reBMnFYqHw2C1ezSHVnffqGHCxVov0NPKvjwCe82d9znSjLz06dqyMmcqimENxLdx yStmP1W4fyPWdzqzxdNfxb3qU3Toj4w6Wb+U9sAmdimARcHrWFW7tW51DbJ5t6j7e/ G7AoOu2gxT1ANNtfFZ9XnXRo+XKy8kIqzkOzysZQ= Date: Tue, 18 Oct 2022 15:51:37 -0700 From: Andrew Morton To: Kees Cook Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] mempool: Use kmalloc_size_roundup() to match ksize() usage Message-Id: <20221018155137.f6898d165aade2e3a5f0b2d3@linux-foundation.org> In-Reply-To: <20221018090323.never.897-kees@kernel.org> References: <20221018090323.never.897-kees@kernel.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666133499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W/tVNKVl/uuGrzYM/yWEqs8G1phEJ6+LApOmcr1d10s=; b=0VRcbFIRq7fX4lvVMa94/hfWkuHNQ1E7sVguxGdWk4dwmIQ8CXjfQ+97zLWoCezWzJu5Ld IzjlHYOGGXy0UwPk5STIvUg+Mwvk7a48RmQjw5wiSMRDOveseB1lJ5K9Pbrpd5a73Srjja HIG6NGSZEJm0YX/1Okj46d0tgPv1Ono= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=reBMnFYq; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666133499; a=rsa-sha256; cv=none; b=wYy4EtLn6Fi/fXffX/TFEir7012skzS1QrDiQenhtOfcSlnZvmYA3bW3xwJsUaxuWXbFLo zViHkpfmHQ7h6CmDj03owbe3UdVcENn1kUAmCCIceMOqMSKhD8EtwK5kkSRI+E6sn7cEIp EzYL6AFowNJK8v2ZomZ/tjJ3QdWCRoA= Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=reBMnFYq; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BE7F5100026 X-Rspam-User: X-Stat-Signature: jofyxrc66j4u9eg8es1gp3nkop763fz5 X-HE-Tag: 1666133499-399777 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 18 Oct 2022 02:03:29 -0700 Kees Cook wrote: > Round up allocations with kmalloc_size_roundup() so that mempool's use > of ksize() is always accurate and no special handling of the memory is > needed by KASAN, UBSAN_BOUNDS, nor FORTIFY_SOURCE. Confused. If the special handling is not needed, why doesn't the patch removed the no longer needed special handling? > > diff --git a/mm/mempool.c b/mm/mempool.c > index 96488b13a1ef..0f3107b28e6b 100644 > --- a/mm/mempool.c > +++ b/mm/mempool.c > @@ -526,7 +526,7 @@ EXPORT_SYMBOL(mempool_free_slab); > */ > void *mempool_kmalloc(gfp_t gfp_mask, void *pool_data) > { > - size_t size = (size_t)pool_data; > + size_t size = kmalloc_size_roundup((size_t)pool_data); > return kmalloc(size, gfp_mask); > } > EXPORT_SYMBOL(mempool_kmalloc); > -- > 2.34.1