From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB57C433FE for ; Tue, 18 Oct 2022 20:55:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A56CD6B0072; Tue, 18 Oct 2022 16:55:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A06DB6B0075; Tue, 18 Oct 2022 16:55:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F5A86B0078; Tue, 18 Oct 2022 16:55:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7C95B6B0072 for ; Tue, 18 Oct 2022 16:55:11 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3C623C0F94 for ; Tue, 18 Oct 2022 20:55:11 +0000 (UTC) X-FDA: 80035275222.19.886C5C5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id BF3A7180034 for ; Tue, 18 Oct 2022 20:55:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C3736616B6; Tue, 18 Oct 2022 20:55:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7CE9C433D6; Tue, 18 Oct 2022 20:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1666126509; bh=/wjPaj4hMDgvB9PGYzwx7w23XxCmDgS1FeMxQ9Lnm/8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t6A6TUsmq2JbEbJPF9njM4iC/QgtcTd8Ie8guuS+lxgJow8hHqyHDECrTFzFOEIND TYh5EUoTvOkUT3id59yExMEevKehALV6PEULymcHTv+fiCRZCCe4/R+39vX/9x9hBB imwUJ1ccCDJ1WzY7UQOKdLp99XWaWAsSZzUk4d44= Date: Tue, 18 Oct 2022 13:55:08 -0700 From: Andrew Morton To: Dan Williams Cc: Nathan Chancellor , Nick Desaulniers , Tom Rix , , , , Subject: Re: [PATCH] mm/memremap: Mark folio_span_valid() as __maybe_unused Message-Id: <20221018135508.d1844e583974b03eaa9aa354@linux-foundation.org> In-Reply-To: <634ee87229a37_6be129430@dwillia2-xfh.jf.intel.com.notmuch> References: <20221018152645.3195108-1-nathan@kernel.org> <634ee87229a37_6be129430@dwillia2-xfh.jf.intel.com.notmuch> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666126510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KXHWVn5D7KLEeWt8GDCPotpavJyPou+EhVYNQ2PtOAk=; b=JZW5HDcnrljN77N4G2V1Ef9HVaDXGgYl417ajHOkG0IlZGpjmBu+OR53ru1Nhn38G89E/e PwqrEoQTTCjvIJwaYiYrhIAJ4EpiBZkxEFXpnQmI4VhNo9k7oC2q17UA/rrQWaIpWufIQT vHOjETzCUjdFzftPFbuqLJp6J7J3/hw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=t6A6TUsm; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666126510; a=rsa-sha256; cv=none; b=Oab0CdqZMpd4y+xENPV/1o4cFmRm+Zk4ViTg4+GpBQxfADG90DoOQR7AK/z+RjbeJjIKpv BP1sAOxjSj+YPE1IeDwv+VhJ6QU1KvJCLXCZ2Pj6aNaemuXPqZv/w43Jaraa4YJSri+2z1 LbW5SGieDeMBB6aj6EGDqznsZAhlBlE= Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=t6A6TUsm; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: by3t7tmahx8f8n94pzbodm7udhdd1ysy X-Rspamd-Queue-Id: BF3A7180034 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1666126510-372556 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 18 Oct 2022 10:54:58 -0700 Dan Williams wrote: > > --- > > > > I am aware the Fixes SHA is probably not stable but I figured I would > > include it anyways. > > This fix looks good to me, but I assume commit-ids are not stable until > the patch moves from mm-unstable to mm-stable. Andrew, do I have that > right? Yes, mm-unstable hashes change daily. But knowing the title of the patch which needs the fix is quite helpful.