From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E77F2C433FE for ; Tue, 18 Oct 2022 16:44:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51F7D6B0072; Tue, 18 Oct 2022 12:44:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CF8F6B0075; Tue, 18 Oct 2022 12:44:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BEC16B0078; Tue, 18 Oct 2022 12:44:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2CE9E6B0072 for ; Tue, 18 Oct 2022 12:44:19 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A69D780832 for ; Tue, 18 Oct 2022 16:44:18 +0000 (UTC) X-FDA: 80034642996.13.3A2F228 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id 14AC610003A for ; Tue, 18 Oct 2022 16:44:16 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 35B27B82045; Tue, 18 Oct 2022 16:44:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 044F4C433C1; Tue, 18 Oct 2022 16:44:10 +0000 (UTC) Date: Tue, 18 Oct 2022 12:44:12 -0400 From: Steven Rostedt To: Uladzislau Rezki Cc: Andrew Morton , kbuild-all@lists.01.org, Linux Memory Management List , LKML , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko Subject: Re: [PATCH 4/7] mm/vmalloc: Use a trace_alloc_vmap_area event Message-ID: <20221018124412.3beca846@gandalf.local.home> In-Reply-To: References: <20221017160233.16582-7-urezki@gmail.com> <202210180250.V8hzNH8X-lkp@intel.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666111457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4H10KhXdnHZBDFWxFTeA1JSBAwn92jRfrNksLaJGnY=; b=5k3tFZBBgeGvM1KyZ/NfudR7LGUND5QgpT/su+mWc4/RG7gFzICdD62etJPZvQ9bV175bJ GwxxVwSToKAvK12ZBPyBsTzm3z9w0TpB6pw1olIgRyN8fg+A4CNYDnIQbsZ64G7d8ayVPL ZvOeAKH/r8AsftPS0c39PV1+ofukBww= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=hLom=2T=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=hLom=2T=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666111457; a=rsa-sha256; cv=none; b=G0llzMuwQ12P3Td503OLCAipnTf1MRMQeZXC+b7wYwU11uO9y3TDOA8FCpCV66VnMyK8kb wZZ/YDeSds2gCGv7buGUv9QrEVaHbz9pAmoo3gzxvsWpLtitR2oI3DBMIfGwST3ef0CpZ2 AkMV9Fn6WEHDZbO9czmlXkYa0S+JC6Q= Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=hLom=2T=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=hLom=2T=goodmis.org=rostedt@kernel.org" X-Stat-Signature: 3f3mqsbs6zzgcd35etotzyy7siqozxqy X-Rspamd-Queue-Id: 14AC610003A X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1666111456-651385 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 18 Oct 2022 18:17:55 +0200 Uladzislau Rezki wrote: > Hello, Steven. > > > > > [auto build test ERROR on akpm-mm/mm-everything] > > [also build test ERROR on linus/master v6.1-rc1 next-20221017] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Uladzislau-Rezki-Sony/Add-basic-trace-events-for-vmap-vmalloc/20221018-000544 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > patch link: https://lore.kernel.org/r/20221017160233.16582-7-urezki%40gmail.com > > patch subject: [PATCH 4/7] mm/vmalloc: Use a trace_alloc_vmap_area event > > config: um-i386_defconfig > > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 > > reproduce (this is a W=1 build): > > # https://github.com/intel-lab-lkp/linux/commit/fbc853c689b29d3bb9fe250b2653fd2dd8046fc7 > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > git fetch --no-tags linux-review Uladzislau-Rezki-Sony/Add-basic-trace-events-for-vmap-vmalloc/20221018-000544 > > git checkout fbc853c689b29d3bb9fe250b2653fd2dd8046fc7 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash > > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot > > > > All errors (new ones prefixed by >>): > > > > In file included from include/trace/events/vmap.h:123, > > from mm/vmalloc.c:47: > > >> include/trace/define_trace.h:84:34: fatal error: trace/events/kernel_vmap.h: No such file or directory > > 84 | # define __TRACE_INCLUDE(system) > > | ^ > > compilation terminated. > > > I can reproduce it. It seems it happens so far only on the ARCH=um case. > For regular arm/x86 i do not see such build error. > > If i rename the TRACE_SYSTEM macro to something different then "vmap" > it compiles fine. In case of: > > #define TRACE_SYSTEM vmap > > the prefix "kernel_" is added, thus the header name becomes as kernel_vmap.h > > Steven can you give some indications? Or any thoughts about it? > > Thank you in advance! It comes from this: arch/um/Makefile:# -Dvmap=kernel_vmap prevents anything from referencing the libpcap.o symbol so arch/um/Makefile: $(ARCH_INCLUDE) $(MODE_INCLUDE) -Dvmap=kernel_vmap \ It defines "vmap" to "kernel_vmap" which will change the above TRACE_SYSTEM Define to: #define TRACE_SYSTEM kernel_vmap and that will confuse everything else. -- Steve > > -- > Uladzislau Rezki