From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC85AC43217 for ; Tue, 18 Oct 2022 00:08:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39E2C6B0072; Mon, 17 Oct 2022 20:08:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34E2B6B0075; Mon, 17 Oct 2022 20:08:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23C896B0078; Mon, 17 Oct 2022 20:08:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 165F96B0072 for ; Mon, 17 Oct 2022 20:08:49 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DF706809C7 for ; Tue, 18 Oct 2022 00:08:48 +0000 (UTC) X-FDA: 80032134336.06.D5424B9 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id 654FDC0020 for ; Tue, 18 Oct 2022 00:08:48 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 76237B81BEB; Tue, 18 Oct 2022 00:08:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E23EDC433D6; Tue, 18 Oct 2022 00:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1666051725; bh=059ej3N3LCfOk9I0E1+oeuSb34gsOMCdCbfImib7Ma4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kgcD7q1izzkWZUUI1cCZmobXfuTeE1/sxZfdWshlu4cXhKF/qR4WgvcRHz0vHYSwL wABdCfXfc8yvF9t+BKmlpLYqzxP7KBBO+78hlGMP74xYMce/hoRcNcAsk9xh5PgPTr VCWaF9vR0EsDsirW1dCJzkNSOAfKY4Jeziu2vOnI= Date: Mon, 17 Oct 2022 17:08:44 -0700 From: Andrew Morton To: Sergey Senozhatsky Cc: Minchan Kim , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv3 8/8] zram: correct typos Message-Id: <20221017170844.3284c18376b16713c09b315b@linux-foundation.org> In-Reply-To: <20221009090720.1040633-9-senozhatsky@chromium.org> References: <20221009090720.1040633-1-senozhatsky@chromium.org> <20221009090720.1040633-9-senozhatsky@chromium.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666051728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PG2R1OJqD0V+nvnIDNI0zVsYtB/uJeqeFM6aRuwDAmY=; b=nheZ54PsimNWgDiY3EMCsu1N6+Oio14p+AMnTkZqtg8Qooy00rfDZRwpPvuyBPbRx4mvlb 59iCZ3CH3bpJAtTJvZSVVoo29QFfB/j0+b/y0K52s6ih2IgEp/rCVV4wlV87x+WHAj71OQ C6Z0+XrIja01CzCPrJRu7OZVXTgqdcY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kgcD7q1i; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666051728; a=rsa-sha256; cv=none; b=hBYNFrDfFGpJg6Ym+/N0LFrWjhoUK274dU8niA/IXzWSB6Bnmw847+wzzKYnwgEj83nVT2 Oz+pUnHfkqTKLqprfkbV7/6ZKu30fiv8xtoJIUqDHnuPeooYvwM/5/ESVXkRM8yI4+a28j HYfNahaxKMESFSJMZWgO8RN6p4xo2X4= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 654FDC0020 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kgcD7q1i; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: 4rxrtytrownouojrb3qwdprgumytyijj X-HE-Tag: 1666051728-526460 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 9 Oct 2022 18:07:20 +0900 Sergey Senozhatsky wrote: > Trivial comment typos fixes. > > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -759,7 +759,7 @@ static ssize_t writeback_store(struct device *dev, > zram_slot_unlock(zram, index); > /* > * Return last IO error unless every IO were > - * not suceeded. > + * not succeeded. That's a pretty awkward sentence. Why not "unless every IO failed". If that's indeed what we're doing here. Sounds odd. What do we return if all IOs indeed failed?