From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EFE6C4332F for ; Mon, 17 Oct 2022 22:24:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6355E6B0072; Mon, 17 Oct 2022 18:24:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E5726B0075; Mon, 17 Oct 2022 18:24:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D3946B0078; Mon, 17 Oct 2022 18:24:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3FC9B6B0072 for ; Mon, 17 Oct 2022 18:24:30 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 00DCF80E76 for ; Mon, 17 Oct 2022 22:24:29 +0000 (UTC) X-FDA: 80031871500.03.8B0572E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf08.hostedemail.com (Postfix) with ESMTP id 88986160034 for ; Mon, 17 Oct 2022 22:24:28 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 79B31B819D6; Mon, 17 Oct 2022 22:24:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8A2DC433C1; Mon, 17 Oct 2022 22:24:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1666045465; bh=+x+l8r2NKIHANVqCIxgQ1cv0f2hMruT2QoeXCGRiBT0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hzzRItBdMigq+W7Qu9bd22P1K+6XDTA0aQdVxHAelY9GiIwHaYU1X4gBCW7DeYNhk wlPKRGh0vhBz7oyYmF4sT6DcSS4bLmpKyovMoC5Z9KTJPDzdh+le277juOz51DjMOL myIp96Tjhq4G+Wsk965p2FAOWp6dKO5V+NeZOHmM= Date: Mon, 17 Oct 2022 15:24:23 -0700 From: Andrew Morton To: Oleksandr Natalenko Cc: Brian Foster , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Seth Jennings , Dan Streetman , Vitaly Wool , Miaohe Lin , Matthew Wilcox Subject: Re: Panic/lockup in z3fold_zpool_free Message-Id: <20221017152423.37a126325b4330e71cf8f869@linux-foundation.org> In-Reply-To: <4433520.LvFx2qVVIh@natalenko.name> References: <6f834faddf927b6fa5a8edd8adfde63c@natalenko.name> <2650550.mvXUDI8C0e@natalenko.name> <4433520.LvFx2qVVIh@natalenko.name> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666045468; a=rsa-sha256; cv=none; b=cc7uiXEzaNzkAB9QWOZB6AXlnwQBinjefzmeiPxJGcSdtZdH+Hjyo+0jbHGaeySit+Bt83 KSy2DwoWMpJm31cFd4pAH4eAYsEch0uhkeeCQJJVtWusP/Gmw6YpCaHFfFFppUtGQzKc+B u6lHY1UcybuzmPChORBtmJLc3BayelA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=hzzRItBd; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666045468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y5CibaZYkVD1hcOftIAx6ij9QgMQR+QnrX8pLHLva3o=; b=SNSWuy5SGtlyf1p8rZRZgdaFVVvjFjlCMBgXL20qz06+n+hLnFX2NUOzJdWYcKzeNtxpQn RfL33xKvkof2IeHmXL1M4ZCdgm+nyYr3E8XZGpcIT2T7nnCuBAVshaEj8DED4PXmntPPdZ GAVh6542XoGclx7kMeFVb4dgoUm+yoo= X-Rspamd-Queue-Id: 88986160034 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=hzzRItBd; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspam-User: X-Rspamd-Server: rspam08 X-Stat-Signature: pwer9dnbsb8ofhjks7hs115qys6pjx6n X-HE-Tag: 1666045468-843960 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 17 Oct 2022 18:34:50 +0200 Oleksandr Natalenko wrote: > > > > I'll give it a try. The only problem is that for me the issue is not reproducible at will, it can take 1 day, or it can take 2 weeks before the panic is hit. > > > > > > > > > [1] https://lore.kernel.org/linux-mm/YxDyZLfBdFHK1Y1P@bfoster/ > > > > > [2] https://lore.kernel.org/linux-mm/20220906190602.1626037-1-bfoster@redhat.com/ > > > > > > So far, I haven't reproduced this issue with your patch. I haven't run the machine sufficiently long, just under a week, so this is rather to let you know that I haven't abandoned testing. > > > > > > > Thanks for the update. Is this still going well, or reached a point > > where you typically see the problem? I can still reproduce the original > > problem so I may have to ping the patch again.. > > So far, no issue observed with your patch. Thanks. It's actually unclear (to me) why Matthew's b653db77350c73 ("mm: Clear page->private when splitting or migrating a page") was considered necessary. What problem did it solve? https://lore.kernel.org/linux-mm/20220906190602.1626037-1-bfoster@redhat.com/ is a partial undoing of that change, but should we simply revert b653db77350c73?