From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1E94C43217 for ; Mon, 17 Oct 2022 20:36:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 468D56B0078; Mon, 17 Oct 2022 16:36:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4197E6B007B; Mon, 17 Oct 2022 16:36:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 309466B007D; Mon, 17 Oct 2022 16:36:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1DBB56B0078 for ; Mon, 17 Oct 2022 16:36:19 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 16E18C0660 for ; Mon, 17 Oct 2022 20:36:18 +0000 (UTC) X-FDA: 80031598836.17.159A743 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 9AB5F40046 for ; Mon, 17 Oct 2022 20:36:17 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A46746121B; Mon, 17 Oct 2022 20:36:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7AA9C433D6; Mon, 17 Oct 2022 20:36:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1666038976; bh=KKvT8SejwGPUN61J8aIsq/7MbiFb3qzppV3aenFVJCQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eTQxk4r0XcGPoKADbojUMK46eqeEndOKctk9KWD9S/zi6+FF75h7ggU489Mc4PQI8 3xn4uG0/29mFJwmujQ66CZCVKg0QXh9/dqkMdpSa2LR/9C7Wu6vrMq/Wfo/kKbuXzV 5P7uX6+/Oss4G4pKSBpqLwEuR8pnsMfI6xju6HbY= Date: Mon, 17 Oct 2022 13:36:15 -0700 From: Andrew Morton To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, willy@infradead.org, almasrymina@google.com, linmiaohe@huawei.com, minhquangbui99@gmail.com, aneesh.kumar@linux.ibm.com Subject: Re: [PATCH 6/9] mm/hugetlb: convert free_huge_page to folios Message-Id: <20221017133615.2b24099673d2ca296f9c355b@linux-foundation.org> In-Reply-To: <20221014031303.231740-7-sidhartha.kumar@oracle.com> References: <20221014031303.231740-1-sidhartha.kumar@oracle.com> <20221014031303.231740-7-sidhartha.kumar@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666038977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6t3E/uslgGtD83gb6OSt04tMHw/f2+qUwDzN3OjLrww=; b=qofG0bkoXjfTZ9KlCYGl9sIXTaJtxWAbipe14TKKYOPmT4n1OGRWnhDmItM4opeSOo9RBA vvmcPUvGXF1Oii5AZjAQgdToqZAyAMD2fXlCJefqvV1uOC0GJooBi1Xr5rten1uuj/Gpfn kMOlIZhmumo6cTi7mrl+mO66tpOATZU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eTQxk4r0; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666038977; a=rsa-sha256; cv=none; b=W264M2ZFz78NO81dUc2j5YR+KWxHeEZm1m8RFEuTA8cCBQsjbviXltGDeJ8nVALd2lhaGq M1rLLDu6ybnzj1oMFJ0d6u0dSrzPQiGsqSNwpTHvT57tCSPnxHK566SylrcSfqfX4xIXEo SFi6ETAnl6Jpp7ZX4WTsXcVt65UP+Gw= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9AB5F40046 X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eTQxk4r0; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: ijj3ia7hy5rzqeu39xqyzxucrnn1ed8c X-HE-Tag: 1666038977-738428 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 13 Oct 2022 20:13:00 -0700 Sidhartha Kumar wrote: > Use folios inside free_huge_page(), this is in preparation for converting > hugetlb_cgroup_uncharge_page() to take in a folio. I added this build fix. --- a/mm/hugetlb.c~mm-hugetlb-convert-free_huge_page-to-folios-fix +++ a/mm/hugetlb.c @@ -1704,7 +1704,7 @@ void free_huge_page(struct page *page) unsigned long flags; VM_BUG_ON_FOLIO(folio_ref_count(folio), folio); - VM_BUG_ON_PAGE(folio_mapcount(folio), folio); + VM_BUG_ON_FOLIO(folio_mapcount(folio), folio); hugetlb_set_folio_subpool(folio, NULL); if (folio_test_anon(folio)) _