From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55DE4C433FE for ; Fri, 14 Oct 2022 06:38:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AA0D6B0072; Fri, 14 Oct 2022 02:38:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 658EC6B0075; Fri, 14 Oct 2022 02:38:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 520656B0078; Fri, 14 Oct 2022 02:38:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3DB276B0072 for ; Fri, 14 Oct 2022 02:38:40 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 09C71C0A1A for ; Fri, 14 Oct 2022 06:38:40 +0000 (UTC) X-FDA: 80018601600.16.925CCDE Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by imf15.hostedemail.com (Postfix) with ESMTP id 68B8BA0027 for ; Fri, 14 Oct 2022 06:38:39 +0000 (UTC) Date: Fri, 14 Oct 2022 15:38:26 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1665729517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GVx51+wEeaxhdduiJJ9u4pDxyncQhwvaEYATQ2iOVl4=; b=XxMiNss66OkyEkiqhCvkHcicecVDn8I/Wd2LSvel1BD3vZB5t6hP2H+++JBgPiFuUZ0az2 yP1VYVFpmrcLF2Ym+5DnSN2mrBSL/xVMZjRe/N/UjKTxlaJuYL9PSi2ht/AvvVIW30XAU0 g+aQWXry5Plax1EuEkBwZrUff5cKMQE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Oscar Salvador Cc: linux-mm@kvack.org, Andrew Morton , Miaohe Lin , David Hildenbrand , Mike Kravetz , Yang Shi , Muchun Song , Jane Chu , Naoya Horiguchi , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/4] mm/hwpoison: move definitions of num_poisoned_pages_* to memory-failure.c Message-ID: <20221014063826.GA1711843@u2004> References: <20221007010706.2916472-1-naoya.horiguchi@linux.dev> <20221007010706.2916472-3-naoya.horiguchi@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665729519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GVx51+wEeaxhdduiJJ9u4pDxyncQhwvaEYATQ2iOVl4=; b=7rQOkfU3bfvzgsXVf1jjQD/BuAGFEYw/O1TNmQ/AR/AyugkPZuhy3Z1globk3zXpTGqMgJ fXqlte09S1t6ehHlEF/7hFOW5fSH5YOcxkIF4B1yQkSxO6+1TdjsuFOtnAeKYUsHQS8axb cYkybUD7ZGp6N2/Q/wkR8WJwpxMGrSs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XxMiNss6; spf=pass (imf15.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665729519; a=rsa-sha256; cv=none; b=uxu2EBVeIQwfReWccSwfiqNmOC1N1uKuO3j/kyqPFmaOYH/P2HMBeo+Lk2Kzcknki92lTh a3b2Uv6WOQD1YyXjVv5t0e4aEIo8gAp+1cJXBH1SyqBSGanoU6Rm6oOl/Vw1EMdDkCQ8fj NwX0+jEUUSuMvs848AWh4dp24hYZ9P0= X-Stat-Signature: pbpn61hmim5bufq87k1baiwzrsr8qiab X-Rspamd-Queue-Id: 68B8BA0027 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XxMiNss6; spf=pass (imf15.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1665729519-701393 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 13, 2022 at 04:31:53PM +0200, Oscar Salvador wrote: > On Fri, Oct 07, 2022 at 10:07:04AM +0900, Naoya Horiguchi wrote: > > From: Naoya Horiguchi > > > > These interfaces will be used by drivers/base/memory.c by later patch, so as a > > preparatory work move them to more common header file visible to the file. > > > > Signed-off-by: Naoya Horiguchi > > Reviewed-by: Miaohe Lin > > --- > > ChangeLog v3 -> v6: > > - remove static in definition of num_poisoned_pages_inc() to fix build error. > > > > ChangeLog v2 -> v3: > > - added declaration of num_poisoned_pages_inc() in #ifdef CONFIG_MEMORY_FAILURE > > --- > > arch/parisc/kernel/pdt.c | 3 +-- > > include/linux/mm.h | 5 +++++ > > include/linux/swapops.h | 24 ++---------------------- > > mm/memory-failure.c | 10 ++++++++++ > > 4 files changed, 18 insertions(+), 24 deletions(-) > > > > diff --git a/arch/parisc/kernel/pdt.c b/arch/parisc/kernel/pdt.c > > index e391b175f5ec..fdc880e2575a 100644 > > --- a/arch/parisc/kernel/pdt.c > > +++ b/arch/parisc/kernel/pdt.c > > @@ -18,8 +18,7 @@ > > #include > > #include > > #include > > -#include > > -#include > > +#include > > I am probably missing something. > num_poisoned_pages_* functions are in swapops.h, but why are you removing swap.h as well? This file included swap.h and swapops.h together to use num_poisoned_pages_inc() by commit 0e5a7ff6e36a ("parisc: Report bad pages as HardwareCorrupted"), so I thought these may be updated together. > > Also, reading the changelog it sounded like both functions would be in mm.h, > but actually only the _inc part is. > > ChangeLog v2 -> v3: > > - added declaration of num_poisoned_pages_inc() in #ifdef CONFIG_MEMORY_FAILURE Yeah, important part of this log is "in #ifdef CONFIG_MEMORY_FAILURE", but this might not be clear from my writing. Sorry about that, I'll care about making change log clearer from now. This change log will not included when merged to mainline, so this hopefully will not confuse anyone. > > The rest looks good to me. Thank you. - Naoya Horiguchi