Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on next-20221013] [cannot apply to shuah-kselftest/next v6.0] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/alexlzhu-fb-com/THP-Shrinker/20221013-065303 config: x86_64-randconfig-a011 compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/7b8b0daade87dcdb8158c1fcc16fcc7963a8869c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review alexlzhu-fb-com/THP-Shrinker/20221013-065303 git checkout 7b8b0daade87dcdb8158c1fcc16fcc7963a8869c # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): ld: mm/huge_memory.o: in function `add_underutilized_thp': >> mm/huge_memory.c:3033: undefined reference to `memcg_list_lru_alloc' vim +3033 mm/huge_memory.c 3010 3011 void add_underutilized_thp(struct page *page) 3012 { 3013 VM_BUG_ON_PAGE(!PageTransHuge(page), page); 3014 3015 if (PageSwapCache(page)) 3016 return; 3017 3018 /* 3019 * Need to take a reference on the page to prevent the page from getting free'd from 3020 * under us while we are adding the THP to the shrinker. 3021 */ 3022 if (!get_page_unless_zero(page)) 3023 return; 3024 3025 if (!is_anon_transparent_hugepage(page)) 3026 goto out_put; 3027 3028 if (is_huge_zero_page(page)) 3029 goto out_put; 3030 3031 lock_page(page); 3032 > 3033 if (memcg_list_lru_alloc(page_memcg(page), &huge_low_util_page_lru, GFP_KERNEL)) 3034 goto out_unlock; 3035 3036 list_lru_add_page(&huge_low_util_page_lru, page, page_underutilized_thp_list(page)); 3037 3038 out_unlock: 3039 unlock_page(page); 3040 out_put: 3041 put_page(page); 3042 } 3043 -- 0-DAY CI Kernel Test Service https://01.org/lkp