From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E2AC433FE for ; Thu, 13 Oct 2022 10:16:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB9026B0071; Thu, 13 Oct 2022 06:16:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A68C36B0073; Thu, 13 Oct 2022 06:16:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 909308E0001; Thu, 13 Oct 2022 06:16:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7A59E6B0071 for ; Thu, 13 Oct 2022 06:16:45 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 507CCC1278 for ; Thu, 13 Oct 2022 10:16:45 +0000 (UTC) X-FDA: 80015522370.23.C58CA14 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [193.142.43.52]) by imf16.hostedemail.com (Postfix) with ESMTP id D62D418001E for ; Thu, 13 Oct 2022 10:16:43 +0000 (UTC) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1oivGV-00028B-QF; Thu, 13 Oct 2022 12:16:35 +0200 Date: Thu, 13 Oct 2022 12:16:35 +0200 From: Florian Westphal To: Rolf Eike Beer Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, "Jason A. Donenfeld" , Andrew Morton , Florian Westphal , Herbert Xu , Thomas Graf , kasan-dev@googlegroups.com, Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-parisc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible Message-ID: <20221013101635.GB11818@breakpoint.cc> References: <20221010230613.1076905-1-Jason@zx2c4.com> <20221010230613.1076905-6-Jason@zx2c4.com> <3026360.ZldQQBzMgz@eto.sf-tec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3026360.ZldQQBzMgz@eto.sf-tec.de> User-Agent: Mutt/1.10.1 (2018-07-13) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665656204; a=rsa-sha256; cv=none; b=cEMl6aVrFji2n8CKCLK7+wlof2A4ndE/Pq8gGS45E+noqwsnyIYwI7v8AvBc/rmswjkMCV vNpbxpmn/b18W9wcltw/GucHDaavP9EAePqRrrkUHV2t79EzQchrbtotE0gJJZ9JoYFX1C SfMUVfKAaglom/ikrpwr4fy2ETGxTY8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of fw@strlen.de designates 193.142.43.52 as permitted sender) smtp.mailfrom=fw@strlen.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665656204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cf/mi8PiR7AOB7uAV/J+8RsCEujUPjdzXkLzGlxBC8Q=; b=axO93zNVrkwtPUoEkMsqPMqoj1c4vfM/V1eD6B36YcITUNIWGCDpnXed2YLbUb7nr/2FK4 ZeCzIw3lu27XFYayrRvrKvqfDt31LOVB9ga8S404pSZArzyaFXKZtDtCKowcFL60RM8kA+ vSXRqg5nMSbCsK/h8ud0EKvZfdr/idw= X-Stat-Signature: 6iybxebysshjb6qansfwnnefwyhw14f3 X-Rspamd-Queue-Id: D62D418001E X-Rspam-User: X-Rspamd-Server: rspam08 Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of fw@strlen.de designates 193.142.43.52 as permitted sender) smtp.mailfrom=fw@strlen.de; dmarc=none X-HE-Tag: 1665656203-582039 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000876, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Rolf Eike Beer wrote: > Florian, can you comment and maybe fix it? Can't comment, do not remember -- this was 5 years ago. > Or you wanted to move the variable before the loop and keep the random state > between the loops and only reseed when all '1' bits have been consumed. Probably. No clue, best to NOT change it to not block Jasons series and then just simplify this and remove all the useless shifts.