From: Jakub Kicinski <kuba@kernel.org>
To: Wei Wang <weiwan@google.com>, Eric Dumazet <edumazet@google.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
Shakeel Butt <shakeelb@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>
Subject: Re: [PATCH net-next] net-memcg: pass in gfp_t mask to mem_cgroup_charge_skmem()
Date: Wed, 12 Oct 2022 16:33:00 -0700 [thread overview]
Message-ID: <20221012163300.795e7b86@kernel.org> (raw)
In-Reply-To: <20210817194003.2102381-1-weiwan@google.com>
On Tue, 17 Aug 2021 12:40:03 -0700 Wei Wang wrote:
> Add gfp_t mask as an input parameter to mem_cgroup_charge_skmem(),
> to give more control to the networking stack and enable it to change
> memcg charging behavior. In the future, the networking stack may decide
> to avoid oom-kills when fallbacks are more appropriate.
>
> One behavior change in mem_cgroup_charge_skmem() by this patch is to
> avoid force charging by default and let the caller decide when and if
> force charging is needed through the presence or absence of
> __GFP_NOFAIL.
This patch is causing a little bit of pain to us, to workloads running
with just memory.max set. After this change the TCP rx path no longer
forces the charging.
Any recommendation for the fix? Setting memory.high a few MB under
memory.max seems to remove the failures.
next prev parent reply other threads:[~2022-10-12 23:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 19:40 Wei Wang
2021-08-18 10:50 ` patchwork-bot+netdevbpf
2022-10-12 23:33 ` Jakub Kicinski [this message]
2022-10-13 0:17 ` Shakeel Butt
2022-10-13 0:38 ` Jakub Kicinski
2022-10-13 0:54 ` Shakeel Butt
2022-10-13 1:40 ` Jakub Kicinski
2022-10-13 3:16 ` Jakub Kicinski
2022-10-13 3:34 ` Wei Wang
2022-10-13 3:49 ` Jakub Kicinski
2022-10-13 4:04 ` Wei Wang
2022-10-13 4:18 ` Shakeel Butt
2022-10-13 21:49 ` Jakub Kicinski
2022-10-13 22:02 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221012163300.795e7b86@kernel.org \
--to=kuba@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox