From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EA34C433F5 for ; Tue, 11 Oct 2022 18:59:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A486A6B0071; Tue, 11 Oct 2022 14:59:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F77D6B0073; Tue, 11 Oct 2022 14:59:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8991D6B0074; Tue, 11 Oct 2022 14:59:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 74E576B0071 for ; Tue, 11 Oct 2022 14:59:11 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3493AAB028 for ; Tue, 11 Oct 2022 18:59:11 +0000 (UTC) X-FDA: 80009581302.14.FC3BBBA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id D16B44001D for ; Tue, 11 Oct 2022 18:59:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DE86761244; Tue, 11 Oct 2022 18:59:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03FECC433D6; Tue, 11 Oct 2022 18:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665514749; bh=Gkvc3jF/zL7iEIbkbjwzKsWG2kmu39r873TdMLwuCLE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nu+hI5SvjmsS9pEvu4gLOa/dluQAqzudZOSl1IMVCFtDjquRFMbutpCmtwtKn8J7I xU37FZnBeXgtT7a3y0dOHfCOF6C9h3P/RJr7Qq6932wernuchOkOBrNTksbK5/epAs s+0WO9xwWDzNqWL++wQsYINBlB5F7pD0WY1nOZ1z5RuYSSv+ChjhoNtmG9f5GXzZ7o lSTniXJ2dC1eiymCvfwkdvrB47MU/pgt6tZdaxvzU1k03f3Tteo7I/b4DSz8i2Sdcf /aba1ii5xRNPjmQMxfVIZU+Tkpy61GylHkm0/CD+9NmbDkVy0yU/N/RtYjgPIp4Vrr aqo/pTwZg3miA== Date: Tue, 11 Oct 2022 11:59:07 -0700 From: Josh Poimboeuf To: Peter Zijlstra Cc: Linus Torvalds , Andrew Morton , Alexander Potapenko , Andrey Konovalov , mm-commits@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] MM updates for 6.1-rc1 Message-ID: <20221011185907.s3kakdlrxcqr6boh@treble> References: <20221008132113.919b9b894426297de78ac00f@linux-foundation.org> <20221011184444.npthr2pmzqb32x6z@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221011184444.npthr2pmzqb32x6z@treble> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665514750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mMyrZO/7Am5qUFEkRx/C/OZW5BDXi1UGtma6+pXrXRA=; b=Bm+GaKSQ5VkaNCgCVWcVOU5WCMarWDsEvpJYHcPJPL5oM9zhD1Hj9/lUQLCQjPm2T2hWCU +eqoLWoFAnuDuCSUaeRsH1IGcTxWTbLm3lgCLNmwQ1U0keWEAmPVX6JGaC5NpNOTh9IESP 1M3B3h6jhH2z8UDYL7it8us7ISDlORg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nu+hI5Sv; spf=pass (imf04.hostedemail.com: domain of jpoimboe@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jpoimboe@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665514750; a=rsa-sha256; cv=none; b=3Yh7Up8GWt2kwoNRGjrOOqJ5ONxAh6rKaH9/LTB77F6A3QgPrbcgsysfp4dt356Gd91CXx 5jsV7/tNEDsD1iAOF8/APrR/ZTIXVXjm7S7qZCMjxqyLLvmXUkVf/jJub5sIocBPa3iA7r rBsI1B9Fyui8Jqmu3Gtyomp9r8eqxAE= X-Rspam-User: X-Rspamd-Server: rspam11 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nu+hI5Sv; spf=pass (imf04.hostedemail.com: domain of jpoimboe@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jpoimboe@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: g9tr5jib3ecmzqgtm5gxkuj1rjtowwsf X-Rspamd-Queue-Id: D16B44001D X-HE-Tag: 1665514750-415254 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 11, 2022 at 11:44:46AM -0700, Josh Poimboeuf wrote: > On Tue, Oct 11, 2022 at 10:24:27AM +0200, Peter Zijlstra wrote: > > On Mon, Oct 10, 2022 at 06:20:00PM -0700, Linus Torvalds wrote: > > > The other thing I notice from just doing a build is that I now get > > > > > > vmlinux.o: warning: objtool: kasan_report+0x12: call to > > > stackleak_track_stack() with UACCESS enabled > > > > So kasan_report() is already marked as being special; and it does the > > mandatory user_access_save() / user_access_restore() things to fix it > > up. > > > > But it looks like kasan code itself is now getting instrumented by the > > stackleak stuff and that inserts a call outside of the > > user_access_save()/restore() thing, and *that* is getting flagged. > > > > Looking at mm/kasan/Makefile it disables a lot of the instrumentation, > > but perhaps not enough? > > I can recreate, but weirdly the below doesn't seem to fix it. Duh, because kmsan != stackleak, obviously... > > diff --git a/mm/kasan/Makefile b/mm/kasan/Makefile > index d4837bff3b60..a41cf1235032 100644 > --- a/mm/kasan/Makefile > +++ b/mm/kasan/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > KASAN_SANITIZE := n > +KMSAN_SANITIZE := n > UBSAN_SANITIZE := n > KCOV_INSTRUMENT := n > > -- Josh