linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexander Potapenko <glider@google.com>,
	Andrey Konovalov <andreyknvl@google.com>,
	mm-commits@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] MM updates for 6.1-rc1
Date: Tue, 11 Oct 2022 11:44:44 -0700	[thread overview]
Message-ID: <20221011184444.npthr2pmzqb32x6z@treble> (raw)
In-Reply-To: <Y0UoO2+NsJjbZtaf@hirez.programming.kicks-ass.net>

On Tue, Oct 11, 2022 at 10:24:27AM +0200, Peter Zijlstra wrote:
> On Mon, Oct 10, 2022 at 06:20:00PM -0700, Linus Torvalds wrote:
> > The other thing I notice from just doing a build is that I now get
> > 
> >    vmlinux.o: warning: objtool: kasan_report+0x12: call to
> > stackleak_track_stack() with UACCESS enabled
> 
> So kasan_report() is already marked as being special; and it does the
> mandatory user_access_save() / user_access_restore() things to fix it
> up.
> 
> But it looks like kasan code itself is now getting instrumented by the
> stackleak stuff and that inserts a call outside of the
> user_access_save()/restore() thing, and *that* is getting flagged.
> 
> Looking at mm/kasan/Makefile it disables a lot of the instrumentation,
> but perhaps not enough?

I can recreate, but weirdly the below doesn't seem to fix it.

diff --git a/mm/kasan/Makefile b/mm/kasan/Makefile
index d4837bff3b60..a41cf1235032 100644
--- a/mm/kasan/Makefile
+++ b/mm/kasan/Makefile
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 KASAN_SANITIZE := n
+KMSAN_SANITIZE := n
 UBSAN_SANITIZE := n
 KCOV_INSTRUMENT := n
 



  parent reply	other threads:[~2022-10-11 18:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-08 20:21 Andrew Morton
2022-10-11  1:20 ` Linus Torvalds
2022-10-11  8:24   ` Peter Zijlstra
2022-10-11 17:08     ` Linus Torvalds
2022-10-11 18:44     ` Josh Poimboeuf [this message]
2022-10-11 18:59       ` Josh Poimboeuf
2022-10-11 19:05         ` [PATCH] kasan: disable stackleak plugin in report code Josh Poimboeuf
2022-10-11 22:00           ` Linus Torvalds
2022-10-11  9:02   ` [GIT PULL] MM updates for 6.1-rc1 Alexander Potapenko
2022-10-11 17:11     ` Linus Torvalds
2022-10-11  1:23 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221011184444.npthr2pmzqb32x6z@treble \
    --to=jpoimboe@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=glider@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox