linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Liam Howlett <liam.howlett@oracle.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux-MM <linux-mm@kvack.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
	Matthew Wilcox <willy@infradead.org>
Subject: Re: Observed recent memory leak in __anon_vma_prepare
Date: Tue, 11 Oct 2022 15:50:59 +0000	[thread overview]
Message-ID: <20221011155051.qgwfbbeeshvoaotj@revolver> (raw)
In-Reply-To: <CAKXUXMzmfeF9K4SkUcR2i6T+ZqEXvwod4hOzCPfQowMJULy7eg@mail.gmail.com>

* Lukas Bulwahn <lukas.bulwahn@gmail.com> [221011 12:35]:
> Dear Liam, dear Matthew, dear all,
> 
> The reproducer for the 'memory leak in __anon_vma_prepare' bug (see
> https://elisa-builder-00.iol.unh.edu/syzkaller-next/report?id=3113810b9abd3dfeb581759df93d3171d1a90f18)
> is reproducible, it is triggering the memory leak on the current
> mainline (commit 60bb8154d1d7), and it was not triggering on v6.0. My
> build config is a x86_64 defconfig.
> 
> My git bisection showed that:
> 
> 524e00b36e8c547f5582eef3fb645a8d9fc5e3df is the first bad commit
> commit 524e00b36e8c547f5582eef3fb645a8d9fc5e3df
> Author: Liam R. Howlett <Liam.Howlett@Oracle.com>
> Date:   Tue Sep 6 19:48:48 2022 +0000
> 
> The git bisect log is below, note that the commits 7fdbd37da5c6,
> d0cf3dd47f0d and 0c563f148043 are marked good in the git bisect as
> they caused bugs "BUG: Bad rss-counter state mm: ... type:MM_ANONPAGES
> val:2". This bug report might have overshadowed the actual issue, and
> hence the bug might have been introduced earlier, but was only visible
> once the Bad rss-counter state bug disappeared.
> 
> 

...

> # first bad commit: [524e00b36e8c547f5582eef3fb645a8d9fc5e3df] mm:
> remove rb tree.
> 
> 
> If there is more information needed or other bisection to be done,
> please let me know.


Lukas,

Thanks for the report.  I am trying to reproduce this issue and have not
been able to trigger a memory leak.  So far I have built using the
defconfig from arch/x86/configs/x86_64_defconfig and run the C code from
the end of your report above.  It also produces some output that is not
captured in your report.  Are you sure it's the defconfig being used?

------
# ./repro
write to /proc/sys/kernel/hung_task_check_interval_secs failed: No such
file or directory
write to /proc/sys/net/core/bpf_jit_kallsyms failed: No such file or
directory
write to /proc/sys/net/core/bpf_jit_harden failed: No such file or
directory
write to /proc/sys/kernel/softlockup_all_cpu_backtrace failed: No such
file or directory
------

Note your output does not mention softlockup or hung_task issues.  This
is on 6.0.0-rc3-00207-g524e00b36e8c.  It is also worth noting that the
resulting kernel does not have /sys/kernel/debug/kmemleak.

I have also tested your reproducer with my own config which does have
the kmemleak debug file, but it did not trigger a memory leak either.  I
suspect I am missing a config option?  Are you using gcc or clang?

Thanks,
Liam

  reply	other threads:[~2022-10-11 15:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11 10:35 Lukas Bulwahn
2022-10-11 15:50 ` Liam Howlett [this message]
2022-10-11 16:11   ` Lukas Bulwahn
2022-10-11 19:04     ` Liam Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221011155051.qgwfbbeeshvoaotj@revolver \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=maple-tree@lists.infradead.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox