From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30D1EC433FE for ; Mon, 10 Oct 2022 08:36:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B98176B0071; Mon, 10 Oct 2022 04:36:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B46756B0073; Mon, 10 Oct 2022 04:36:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0F176B0074; Mon, 10 Oct 2022 04:36:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8BA6D6B0071 for ; Mon, 10 Oct 2022 04:36:03 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4B8B3140E02 for ; Mon, 10 Oct 2022 08:36:03 +0000 (UTC) X-FDA: 80004382206.10.30FAFE0 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf03.hostedemail.com (Postfix) with ESMTP id B08DD20018 for ; Mon, 10 Oct 2022 08:36:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665390962; x=1696926962; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=RGybB6W0aj8JXJpoXUjKNcVo6czdIa5pC/Wiclkx0F8=; b=Ovyba0kjsFsEaUYt6oUDeRzKqy9PrO2uw55+QN/RG87gAQo4LjivAyYa Tqq/WsjUPEkEDESSs5HZhjy2ekHFqY12/KK+u3i66OJFoulRORwoLYj7u cLYY7PANZZpIRT0qJiyYQu4PA2koqag5snHUmWRt4blOliT7hSAoQNu5o VNawgXWg+15sRPY39HiVQXgm412uIQZT/oE0mksapweVfrOBjcXQfvHKI rtvtxhR1NvkMd2Mcvk5l5xI5cyBNhPcIIkMgdHg07Wkvn/XeD6Nj65n3S VTXcJmJ5H4TIJ+CPURdfLuulrj1t+NXLpu6oDtVATODiCUZfSbnch6Eqn g==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="368312518" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="368312518" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 01:35:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="656854721" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="656854721" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by orsmga008.jf.intel.com with ESMTP; 10 Oct 2022 01:35:37 -0700 Date: Mon, 10 Oct 2022 16:31:04 +0800 From: Chao Peng To: Jarkko Sakkinen Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song , wei.w.wang@intel.com Subject: Re: [PATCH v8 8/8] KVM: Enable and expose KVM_MEM_PRIVATE Message-ID: <20221010083104.GA3145236@chaop.bj.intel.com> Reply-To: Chao Peng References: <20220915142913.2213336-1-chao.p.peng@linux.intel.com> <20220915142913.2213336-9-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665390963; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8emri8Asj7tFaAxi8GZjkBCsueg7rhR3Q6m0FKrNej4=; b=Sr9K8X/PkHn9qRWo9i5yb9d9mfbS/18GQF/SD8hROih/CVn8tE11AUVCqHHpruqjc8nxWS IvIqvKRUoWwNo4X4VuL/jrYgHWfr0KOvFJ72AQem/JAt4hQSWJLUmGhi6+Sb3odzbPBU4I 12Pfap1Hj+mlBxTjSVXwLMGAqAJn47I= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Ovyba0kj; spf=none (imf03.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665390963; a=rsa-sha256; cv=none; b=drenGcbdVK8mwxadRlu9NMdnT/7zlNo5GFR7pyyS0Fv2dHg1zmxKZ8zuSiUpHECIqeEURd jwXWOSXjJl3lHPf8hoa+y8SOnfgAKjMFqrjKhDxrNxAfPrI9slqdk4tNCrPNhBGgjZ4x+K d2ElmwB/01/SEPJYNUjCFrthMbU/L74= Authentication-Results: imf03.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Ovyba0kj; spf=none (imf03.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9uzickasx5g3okcik4nshewbpw5w75c6 X-Rspamd-Queue-Id: B08DD20018 X-HE-Tag: 1665390962-12310 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 04, 2022 at 05:55:28PM +0300, Jarkko Sakkinen wrote: > On Thu, Sep 15, 2022 at 10:29:13PM +0800, Chao Peng wrote: > > Expose KVM_MEM_PRIVATE and memslot fields private_fd/offset to > > userspace. KVM will register/unregister private memslot to fd-based > > memory backing store and response to invalidation event from > > inaccessible_notifier to zap the existing memory mappings in the > > secondary page table. > > > > Whether KVM_MEM_PRIVATE is actually exposed to userspace is determined > > by architecture code which can turn on it by overriding the default > > kvm_arch_has_private_mem(). > > > > A 'kvm' reference is added in memslot structure since in > > inaccessible_notifier callback we can only obtain a memslot reference > > but 'kvm' is needed to do the zapping. > > > > Co-developed-by: Yu Zhang > > Signed-off-by: Yu Zhang > > Signed-off-by: Chao Peng > > ld: arch/x86/../../virt/kvm/kvm_main.o: in function `kvm_free_memslot': > kvm_main.c:(.text+0x1385): undefined reference to `inaccessible_unregister_notifier' > ld: arch/x86/../../virt/kvm/kvm_main.o: in function `kvm_set_memslot': > kvm_main.c:(.text+0x1b86): undefined reference to `inaccessible_register_notifier' > ld: kvm_main.c:(.text+0x1c85): undefined reference to `inaccessible_unregister_notifier' > ld: arch/x86/kvm/mmu/mmu.o: in function `kvm_faultin_pfn': > mmu.c:(.text+0x1e38): undefined reference to `inaccessible_get_pfn' > ld: arch/x86/kvm/mmu/mmu.o: in function `direct_page_fault': > mmu.c:(.text+0x67ca): undefined reference to `inaccessible_put_pfn' > make: *** [Makefile:1169: vmlinux] Error 1 > > I attached kernel config for reproduction. > > The problem is that CONFIG_MEMFD_CREATE does not get enabled: > > mm/Makefile:obj-$(CONFIG_MEMFD_CREATE) += memfd.o memfd_inaccessible.o Thanks for reporting. Yes there is a dependency issue needs to fix. Chao