From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F41C433FE for ; Mon, 10 Oct 2022 06:44:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7C796B0071; Mon, 10 Oct 2022 02:44:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B05D76B0073; Mon, 10 Oct 2022 02:44:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97E356B0074; Mon, 10 Oct 2022 02:44:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7F9226B0071 for ; Mon, 10 Oct 2022 02:44:54 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3D9BE1C6620 for ; Mon, 10 Oct 2022 06:44:54 +0000 (UTC) X-FDA: 80004102108.05.7F980B9 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf20.hostedemail.com (Postfix) with ESMTP id CFF021C0031 for ; Mon, 10 Oct 2022 06:44:53 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id a13so14611145edj.0 for ; Sun, 09 Oct 2022 23:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hhF3pQ+2VdUPQo/ju9+6AJvNfKq2pinmfODI3yuV3/4=; b=Wgg9ecH74Z0xjZh+GiM//Kd5NBfwaU+uDi9fNyXD/LFcU6PDt1tlUpCHNIPcZMs3ux cLkoi/449g2HhHMpUU9S+QIU9j57lwCEh7ZJUmycBR+/69R/Dn4ryfUoy6YH4vKogcl3 Czl/ga1PwhORoGJbocJG+JpKUq/ljFHtMbOzffCgVTxD/FqStfN3dCVKZMbgVmQh3g2R nkIpkFNS1yWbpkjTOOG8e1PPAtdie0mZ17CfvVMOJonRGCySsrDeXEmhgeByfwt/YViP tDffB1e4UQh6QWh9fnl31nRIIl46LgnAb9KbSmaaR7J7BV1pgqk1uxydr/GWBTwvF6hA WEKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hhF3pQ+2VdUPQo/ju9+6AJvNfKq2pinmfODI3yuV3/4=; b=4ZhCVE8JLNOdmFYCwIBqmqxYmjp3E4+EbcV936warpdEgNsI3asd/t4sbrBzo1pmdX +I1t4+Yhsr+z3bYZj5hHRWoN148YgcLLjNP+XTnPZUlPaKH1ajdxkCEdMCNs2tzhdUIm 28FJmJudScb9NU9kQdAgFlGsRIi8ywh6X2MVIIf0eJXsHGmloJeZ/ZhdgpV4R7q0rkpt SeC1EXWyJGhtKZTPKotwjBuYzJYK6hbXgMI1ZmIDpxjALkbUyK7rix+6rgRYl1whTNOH sUzY85SJSBvHop9N+gA3Ip3XN+NRRFcWOL1r6hd9F9/hRtI3Amgf/uPq34Mq7U0XxcUd b3sA== X-Gm-Message-State: ACrzQf2gmRlDkfKu3AxdkFgqsIgCSSwb7BYUZhamhOL1neV8jrxfhdsa 6+WkwYm9waiHqIMUD8QfMBEdhA== X-Google-Smtp-Source: AMsMyM4HcPsuGh3NsvSeHEV8muouqTqVF6sWZ9YMomHH8Zt34NTluj1h0hFH2tqdXrBbtjjuJoaP8A== X-Received: by 2002:a05:6402:26cf:b0:459:d119:5728 with SMTP id x15-20020a05640226cf00b00459d1195728mr16238615edd.424.1665384292568; Sun, 09 Oct 2022 23:44:52 -0700 (PDT) Received: from localhost (cst2-173-61.cust.vodafone.cz. [31.30.173.61]) by smtp.gmail.com with ESMTPSA id 18-20020a170906219200b0073a20469f31sm4853612eju.41.2022.10.09.23.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Oct 2022 23:44:52 -0700 (PDT) Date: Mon, 10 Oct 2022 08:44:50 +0200 From: Andrew Jones To: Vernon Yang Cc: lkp@intel.com, anup@brainfault.org, atishp@rivosinc.com, conor.dooley@microchip.com, kbuild-all@lists.01.org, linux-mm@kvack.org Subject: Re: [PATCH] RISC-V: KVM: fixup undefined reference to riscv_cbom_block_size Message-ID: <20221010064450.p4vooa5niynhnz6n@kamzik> References: <202210091222.xuZquaM9-lkp@intel.com> <20221010013329.199167-1-vernon2gm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221010013329.199167-1-vernon2gm@gmail.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665384294; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hhF3pQ+2VdUPQo/ju9+6AJvNfKq2pinmfODI3yuV3/4=; b=LAvImZeG+Iyh25ioH28h56GfHDnGNG00Mw8wumuYdkGhrKbo/0Jl4iSwgDl/0VYDVFD9y0 LiIpmzzAMqNZyRtTaV4RR7H0eA0uhryCbKq/zGOotBswB+2hYqcmbx5eC46wzlvBOnyTfC tBcuBbMFnrYUrcEexjmmeGn2h/Vs26E= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=Wgg9ecH7; dmarc=none; spf=pass (imf20.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665384294; a=rsa-sha256; cv=none; b=8ktABYzkAfbY2cRlbsgdqBt3WHc6WkGzp8QWpqp6dmC2wV4C+ZNUlMGl1JXZfThVOie6RW whjboU5+bXZKnZ/FCHGI579iNqB20IjOYx9jY5W+Ac6UQpt8/LTlgawqUA8aSAH3zl92OS X9IW8qPcHWW4ImsU9d+NB32SwJcAjGw= Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=Wgg9ecH7; dmarc=none; spf=pass (imf20.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com X-Stat-Signature: 1wygc5ak3nzt7rpxiz8x1dshfydyg9at X-Rspamd-Queue-Id: CFF021C0031 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1665384293-601454 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 10, 2022 at 09:33:29AM +0800, Vernon Yang wrote: > When some RISC-V compilers do not support the Zicbom extension, > the build system auto disable the CONFIG_RISCV_ISA_ZICBOM, so the > source code of the relevant function is not compiled, resulting > in the definition of the riscv_cbom_block_size variable cannot > be found > > So add conditional compilation to fix it > > Reported-by: kernel test robot > Signed-off-by: Vernon Yang > --- > arch/riscv/kvm/vcpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/kvm/vcpu.c b/arch/riscv/kvm/vcpu.c > index a032c4f0d600..08a6c3cb695d 100644 > --- a/arch/riscv/kvm/vcpu.c > +++ b/arch/riscv/kvm/vcpu.c > @@ -256,7 +256,7 @@ static int kvm_riscv_vcpu_get_reg_config(struct kvm_vcpu *vcpu, > unsigned long reg_num = reg->id & ~(KVM_REG_ARCH_MASK | > KVM_REG_SIZE_MASK | > KVM_REG_RISCV_CONFIG); > - unsigned long reg_val; > + unsigned long reg_val = 0; > > if (KVM_REG_SIZE(reg->id) != sizeof(unsigned long)) > return -EINVAL; > @@ -268,7 +268,9 @@ static int kvm_riscv_vcpu_get_reg_config(struct kvm_vcpu *vcpu, > case KVM_REG_RISCV_CONFIG_REG(zicbom_block_size): > if (!riscv_isa_extension_available(vcpu->arch.isa, ZICBOM)) > return -EINVAL; > +#ifdef CONFIG_RISCV_ISA_ZICBOM > reg_val = riscv_cbom_block_size; > +#endif > break; Thanks Vernon, I sent a fixup to Anup last week for this, which is similar to your patch, but #ifdef's out the entire case. Thanks, drew > default: > return -EINVAL; > -- > 2.25.1 >