From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4029C433F5 for ; Sun, 9 Oct 2022 21:26:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E515A6B0072; Sun, 9 Oct 2022 17:26:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD82F6B0073; Sun, 9 Oct 2022 17:26:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2B906B0074; Sun, 9 Oct 2022 17:26:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A90F96B0072 for ; Sun, 9 Oct 2022 17:26:27 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 70C85C077D for ; Sun, 9 Oct 2022 21:26:27 +0000 (UTC) X-FDA: 80002694814.12.683B595 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf30.hostedemail.com (Postfix) with ESMTP id 9960D8001F for ; Sun, 9 Oct 2022 21:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665350785; x=1696886785; h=date:from:to:cc:subject:message-id:mime-version; bh=rtZvhWGH0FxbGNDc9vmxU2IKS9gUIUrWUMy41GcFU7E=; b=KS8bWCDpLqh8SsoErnJwtLiM4l1mJd0OSL4KdwoLjQ8OtnEnZGvPkzFQ CFEs8SHNyonlnnLIIeB8pyEXKCQFaWVywp/dubc7ewcvETVyRqiZ/7HdT QH0EVXOL9ThmbKeUvJmX0rrI8ebF5PxeVAeBZh5HRAKMSp5Q8HuJWpYwF oKyPZPJ6mYqU7h5figk7jyByI0/n5Cob48mrT3EOiB7R+QV55o3kqgccO tikCdcys5EkJs38r7ACEnhRdLgaEe6Af4matDWjtSktJKuby2cH0dzPWi X/0g7qNXhA2SK9U7ef2ni/bGNLwkeQvMDkycMuodjPyy+9nmIXj4/FIqA g==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="330559061" X-IronPort-AV: E=Sophos;i="5.95,172,1661842800"; d="scan'208";a="330559061" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2022 14:26:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="688567975" X-IronPort-AV: E=Sophos;i="5.95,172,1661842800"; d="scan'208";a="688567975" Received: from lkp-server01.sh.intel.com (HELO 2af0a69ca4e0) ([10.239.97.150]) by fmsmga008.fm.intel.com with ESMTP; 09 Oct 2022 14:26:22 -0700 Received: from kbuild by 2af0a69ca4e0 with local (Exim 4.96) (envelope-from ) id 1ohdoT-0001IW-1K; Sun, 09 Oct 2022 21:26:21 +0000 Date: Mon, 10 Oct 2022 05:26:01 +0800 From: kernel test robot To: Ira Weiny Cc: kbuild-all@lists.01.org, Ammar Faizi , GNU/Weeb Mailing List , linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: [ammarfaizi2-block:akpm/mm/mm-unstable 63/63] mm/highmem.c:164:7: warning: Local variable 'i' shadows outer variable [shadowVariable] Message-ID: <202210100514.zx4LHq0Y-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=KS8bWCDp; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665350786; a=rsa-sha256; cv=none; b=HucVSkY2f/GEnjnGdJUyAJTTGMnpNfglkPc0STOdekTfeND2D8fR8NUY8g7dmTp9cuwNjz 8guyRppvoFv6htBBq3I3y5+snKJhJRTT/xk3URrP4/jpdmaUp7MTZy+hey88AyScd7TDIC R00fTojBk4XgrbplMWGUWDCVjYQsEAo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665350786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=TzrSdiM9gM9WpEFbjIZMuAP/VzsMFjb8xkph+GuTQE8=; b=tJz1rZDP7rSQHCnMh7RagXBfcZxedle9hwVyTUPZbhDCyMo30TQbPUthkqdN/4B8PYBA+J Fg9xzIdtycj/1fACteJaVbfqJ06F40PY1cgc+2+NeMGIriP1RS3iZPpguCWvl99LUBOPux lb/sJ9yqldhRwcOOt+lPb9zh+T2UV2k= X-Rspamd-Queue-Id: 9960D8001F X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=KS8bWCDp; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam10 X-Stat-Signature: tx6jdd9eufmiypcf88g4c7kcpbo3qm73 X-HE-Tag: 1665350785-567592 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://github.com/ammarfaizi2/linux-block akpm/mm/mm-unstable head: 977bde1f5ffd252e0d4c270bc5c9489280686788 commit: 977bde1f5ffd252e0d4c270bc5c9489280686788 [63/63] highmem: fix kmap_to_page() for kmap_local_page() addresses compiler: nios2-linux-gcc (GCC) 12.1.0 reproduce (cppcheck warning): # apt-get install cppcheck git checkout 977bde1f5ffd252e0d4c270bc5c9489280686788 cppcheck --quiet --enable=style,performance,portability --template=gcc FILE If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot cppcheck warnings: (new ones prefixed by >>) >> mm/highmem.c:164:7: warning: Local variable 'i' shadows outer variable [shadowVariable] int i = PKMAP_NR(addr); ^ mm/highmem.c:159:6: note: Shadowed declaration int i; ^ mm/highmem.c:164:7: note: Shadow variable int i = PKMAP_NR(addr); ^ cppcheck possible warnings: (new ones prefixed by >>, may not real problems) mm/highmem.c:759:13: warning: Uninitialized variable: pam->page [uninitvar] if (pam->page == page) { ^ mm/highmem.c:796:13: warning: Uninitialized variable: pam->page [uninitvar] if (pam->page == page) { ^ vim +/i +164 mm/highmem.c 3297e760776af1 Nicolas Pitre 2009-03-04 153 13f876ba77ebd5 Thomas Gleixner 2020-11-03 154 struct page *__kmap_to_page(void *vaddr) 5a178119b0fbe3 Mel Gorman 2012-07-31 155 { 977bde1f5ffd25 Ira Weiny 2022-10-05 156 unsigned long base = (unsigned long) vaddr & PAGE_MASK; 977bde1f5ffd25 Ira Weiny 2022-10-05 157 struct kmap_ctrl *kctrl = ¤t->kmap_ctrl; 5a178119b0fbe3 Mel Gorman 2012-07-31 158 unsigned long addr = (unsigned long)vaddr; 977bde1f5ffd25 Ira Weiny 2022-10-05 159 int i; 5a178119b0fbe3 Mel Gorman 2012-07-31 160 977bde1f5ffd25 Ira Weiny 2022-10-05 161 /* kmap() mappings */ 977bde1f5ffd25 Ira Weiny 2022-10-05 162 if (WARN_ON_ONCE(addr >= PKMAP_ADDR(0) && 977bde1f5ffd25 Ira Weiny 2022-10-05 163 addr < PKMAP_ADDR(LAST_PKMAP))) { 4de22c0584fb05 Joonsoo Kim 2012-12-11 @164 int i = PKMAP_NR(addr); 9727688dbf7ea9 songqiang 2021-05-04 165 5a178119b0fbe3 Mel Gorman 2012-07-31 166 return pte_page(pkmap_page_table[i]); 5a178119b0fbe3 Mel Gorman 2012-07-31 167 } 5a178119b0fbe3 Mel Gorman 2012-07-31 168 977bde1f5ffd25 Ira Weiny 2022-10-05 169 /* kmap_local_page() mappings */ 977bde1f5ffd25 Ira Weiny 2022-10-05 170 if (WARN_ON_ONCE(base >= __fix_to_virt(FIX_KMAP_END) && 977bde1f5ffd25 Ira Weiny 2022-10-05 171 base < __fix_to_virt(FIX_KMAP_BEGIN))) { 977bde1f5ffd25 Ira Weiny 2022-10-05 172 for (i = 0; i < kctrl->idx; i++) { 977bde1f5ffd25 Ira Weiny 2022-10-05 173 unsigned long base_addr; 977bde1f5ffd25 Ira Weiny 2022-10-05 174 int idx; 977bde1f5ffd25 Ira Weiny 2022-10-05 175 977bde1f5ffd25 Ira Weiny 2022-10-05 176 idx = arch_kmap_local_map_idx(i, pte_pfn(pteval)); 977bde1f5ffd25 Ira Weiny 2022-10-05 177 base_addr = __fix_to_virt(FIX_KMAP_BEGIN + idx); 977bde1f5ffd25 Ira Weiny 2022-10-05 178 977bde1f5ffd25 Ira Weiny 2022-10-05 179 if (base_addr == base) 977bde1f5ffd25 Ira Weiny 2022-10-05 180 return pte_page(kctrl->pteval[i]); 977bde1f5ffd25 Ira Weiny 2022-10-05 181 } 977bde1f5ffd25 Ira Weiny 2022-10-05 182 } 977bde1f5ffd25 Ira Weiny 2022-10-05 183 259ecb34e2cd73 Linus Walleij 2022-06-30 184 return virt_to_page(vaddr); 5a178119b0fbe3 Mel Gorman 2012-07-31 185 } 13f876ba77ebd5 Thomas Gleixner 2020-11-03 186 EXPORT_SYMBOL(__kmap_to_page); 5a178119b0fbe3 Mel Gorman 2012-07-31 187 :::::: The code at line 164 was first introduced by commit :::::: 4de22c0584fb0566487b2cba5cdfbce346b18402 mm, highmem: use PKMAP_NR() to calculate an index of pkmap :::::: TO: Joonsoo Kim :::::: CC: Linus Torvalds -- 0-DAY CI Kernel Test Service https://01.org/lkp