From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D9F8C433F5 for ; Sun, 9 Oct 2022 03:42:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97BC06B0071; Sat, 8 Oct 2022 23:42:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 904746B0073; Sat, 8 Oct 2022 23:42:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CC346B0074; Sat, 8 Oct 2022 23:42:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6526A6B0071 for ; Sat, 8 Oct 2022 23:42:44 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2C3F81208A6 for ; Sun, 9 Oct 2022 03:42:44 +0000 (UTC) X-FDA: 80000014248.25.0C9439B Received: from mail.nfschina.com (mail.nfschina.com [124.16.136.209]) by imf27.hostedemail.com (Postfix) with ESMTP id ED60B40021 for ; Sun, 9 Oct 2022 03:42:42 +0000 (UTC) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 5ABC81E80CE4; Sun, 9 Oct 2022 11:36:41 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5QaQ9NT3s5V9; Sun, 9 Oct 2022 11:36:38 +0800 (CST) Received: from localhost.localdomain.localdomain (unknown [219.141.250.2]) (Authenticated sender: xupengfei@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id B43F41E80CAE; Sun, 9 Oct 2022 11:36:38 +0800 (CST) From: XU pengfei To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, XU pengfei Subject: [PATCH 1/1] mm/mmap_lock: Remove unnecessary 'NULL' values from Pointer Date: Sun, 9 Oct 2022 11:41:54 +0800 Message-Id: <20221009034153.4418-1-xupengfei@nfschina.com> X-Mailer: git-send-email 2.18.2 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665286963; a=rsa-sha256; cv=none; b=eCKgkgBZA79hTIT09to28ovm9PlyQona3uWiCVvdCS/VAvT6G73MJBFWp+bf1gcVplBaRA dCAtxPWlIBge3F1LJWCslq88NL+pD44YpO5mCJhoFMkWG8q8s8vznnG+Cif2yHkjBSKMNj +hqFS5Un/Y9pK1558w957Y5UBDe337I= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=none (imf27.hostedemail.com: domain of xupengfei@nfschina.com has no SPF policy when checking 124.16.136.209) smtp.mailfrom=xupengfei@nfschina.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665286963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=pncFDHR/53nLX9CvxxTgloZ99ZEqHVxLEEsHa3BhjGs=; b=nLaU4jXdzhknPBC0V7RYaocpEZrip0UbiDAY10vqyndeErvgswVU9UR6eQ+QiAIGKWjJhz Fu4NkVGpoLd5iDYynEitWNjbetpTQ5viYSSyi9WOxRRctznVw32zVz0JsT62CjCbsbbYsD ofngJ3mxn5MtPo/Ct/WUmfdtLbPDRfg= Authentication-Results: imf27.hostedemail.com; dkim=none; spf=none (imf27.hostedemail.com: domain of xupengfei@nfschina.com has no SPF policy when checking 124.16.136.209) smtp.mailfrom=xupengfei@nfschina.com; dmarc=none X-Stat-Signature: 34dsgi6ue4za5i7nrpedb15b536uo6yu X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ED60B40021 X-Rspam-User: X-HE-Tag: 1665286962-492822 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Remove unnecessary 'NULL' values from Pointer and goto statement Signed-off-by: XU pengfei --- mm/mmap_lock.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/mm/mmap_lock.c b/mm/mmap_lock.c index 1854850b4b89..d0c2a5eae341 100644 --- a/mm/mmap_lock.c +++ b/mm/mmap_lock.c @@ -198,23 +198,24 @@ void trace_mmap_lock_unreg(void) */ static const char *get_mm_memcg_path(struct mm_struct *mm) { - char *buf = NULL; + char *buf; struct mem_cgroup *memcg = get_mem_cgroup_from_mm(mm); if (memcg == NULL) - goto out; - if (unlikely(memcg->css.cgroup == NULL)) - goto out_put; + return NULL; + if (unlikely(memcg->css.cgroup == NULL)) { + css_put(&memcg->css); + return NULL; + } buf = get_memcg_path_buf(); - if (buf == NULL) - goto out_put; + if (buf == NULL) { + css_put(&memcg->css); + return NULL; + } cgroup_path(memcg->css.cgroup, buf, MEMCG_PATH_BUF_SIZE); -out_put: - css_put(&memcg->css); -out: return buf; } -- 2.18.2