From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 708F6C433F5 for ; Thu, 6 Oct 2022 16:25:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05F8D6B0072; Thu, 6 Oct 2022 12:25:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00FA96B0073; Thu, 6 Oct 2022 12:25:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF33D6B0074; Thu, 6 Oct 2022 12:25:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CBB6D6B0072 for ; Thu, 6 Oct 2022 12:25:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7FD4D81114 for ; Thu, 6 Oct 2022 16:25:49 +0000 (UTC) X-FDA: 79991050818.01.D886F9C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id A50D9C0011 for ; Thu, 6 Oct 2022 16:25:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2FBBB218E0; Thu, 6 Oct 2022 16:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1665073547; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XCQ01W/Zak7b1/Z15iSFiNNO+LnDKjRUCwgq9owN358=; b=BuCJHwpPWmPIMX1bCVa8JvF5Z7d74n/yJTO58u9Flcub7+SsSH8xi8XlpREVi0km3sCU9I n49kVMdngxh5xHUcQ7JaAcHnUNwcTFTbcX666mAdObWVWWOiQa+NDqw9MObg2XVpG17TSv v1FutPp1yNGHL7WKXiiXO6EFByUMvOk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1665073547; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XCQ01W/Zak7b1/Z15iSFiNNO+LnDKjRUCwgq9owN358=; b=SBbeuIQGR7WWo1BYruUMTbe52g3YJZXPJmGbNwSK0jCwlB3l1oeiG8qTbAyyKKzsNlfKnK YUPXB99RMPIak5BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E0B0413AC8; Thu, 6 Oct 2022 16:25:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UOdXNooBP2OJIwAAMHmgww (envelope-from ); Thu, 06 Oct 2022 16:25:46 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 30DD3A06E9; Thu, 6 Oct 2022 18:25:46 +0200 (CEST) Date: Thu, 6 Oct 2022 18:25:46 +0200 From: Jan Kara To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andreas Noever , Andrew Morton , Andy Shevchenko , Borislav Petkov , Christoph =?utf-8?Q?B=C3=B6hmwalder?= , Christoph Hellwig , Daniel Borkmann , Dave Airlie , Dave Hansen , "David S . Miller" , Eric Dumazet , Florian Westphal , Greg Kroah-Hartman , "H . Peter Anvin" , Herbert Xu , Hugh Dickins , Jakub Kicinski , "James E . J . Bottomley" , Jan Kara , Jason Gunthorpe , Jens Axboe , Johannes Berg , Jonathan Corbet , Jozsef Kadlecsik , KP Singh , Kees Cook , Marco Elver , Mauro Carvalho Chehab , Michael Ellerman , Pablo Neira Ayuso , Paolo Abeni , Theodore Ts'o , Thomas Gleixner , Thomas Graf , Ulf Hansson , Vignesh Raghavendra , Yury Norov , dri-devel@lists.freedesktop.org, kasan-dev@googlegroups.com, kernel-janitors@vger.kernel.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 3/5] treewide: use get_random_u32() when possible Message-ID: <20221006162546.hgkrftnsk5p3sug7@quack3> References: <20221006132510.23374-1-Jason@zx2c4.com> <20221006132510.23374-4-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221006132510.23374-4-Jason@zx2c4.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665073549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XCQ01W/Zak7b1/Z15iSFiNNO+LnDKjRUCwgq9owN358=; b=tMI7BwZsuJ+A0PSk2lVv+RYQPPpfbZASao0dVVYkd/n5P+np80n0TO4nBsjaf14z6uxcot KEhCJGSSoW+5zUEvM6XCZvdfE6WMJeOd3P23x7lCIEwuphuK/hexqmYrmnwKsBgHEJIvfd mJkVmPhuKiATdy2d2hnpDmPAiQwN8Yg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BuCJHwpP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SBbeuIQG; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665073549; a=rsa-sha256; cv=none; b=AeKhrS3wrCLJPf76mKgtog0Sef5Lwzny/Awu0ZgW8Us/D0YRH8ZiHewDechsjQHNd2uW1a 5TOFKennOQEmrFex9v4/mO9jZlgh93DRc3vCk20yZ0FOwZbwkIJYFmNRvk6/Cq9Rvlqf/j HgHZL7it0eOPzu1dME/XwJ+btpynufA= X-Rspamd-Queue-Id: A50D9C0011 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BuCJHwpP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SBbeuIQG; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none X-Rspamd-Server: rspam06 X-Rspam-User: X-Stat-Signature: dzja9sbuqm75h47ziyniowfbcqt4k9xr X-HE-Tag: 1665073548-860796 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 06-10-22 07:25:08, Jason A. Donenfeld wrote: > The prandom_u32() function has been a deprecated inline wrapper around > get_random_u32() for several releases now, and compiles down to the > exact same code. Replace the deprecated wrapper with a direct call to > the real function. > > Reviewed-by: Kees Cook > Signed-off-by: Jason A. Donenfeld Looks good. Feel free to add: Reviewed-by: Jan Kara for the ext4 bits. Honza -- Jan Kara SUSE Labs, CR