From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C90CCC433F5 for ; Thu, 6 Oct 2022 02:07:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE5516B0071; Wed, 5 Oct 2022 22:07:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D93816B0073; Wed, 5 Oct 2022 22:07:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5AF06B0074; Wed, 5 Oct 2022 22:07:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AFD126B0071 for ; Wed, 5 Oct 2022 22:07:41 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 770EC140430 for ; Thu, 6 Oct 2022 02:07:41 +0000 (UTC) X-FDA: 79988888322.03.81D1637 Received: from mail3-164.sinamail.sina.com.cn (mail3-164.sinamail.sina.com.cn [202.108.3.164]) by imf29.hostedemail.com (Postfix) with ESMTP id 3226412001B for ; Thu, 6 Oct 2022 02:07:38 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([114.249.60.223]) by sina.com (172.16.97.35) with ESMTP id 633E380400003E96; Thu, 6 Oct 2022 10:05:58 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 45888615073639 From: Hillf Danton To: Valentin Schneider Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lai Jiangshan , Peter Zijlstra , Frederic Weisbecker , Marcelo Tosatti Subject: Re: [PATCH v4 4/4] workqueue: Unbind workers before sending them to exit() Date: Thu, 6 Oct 2022 10:07:25 +0800 Message-Id: <20221006020725.1757-1-hdanton@sina.com> In-Reply-To: References: <20221004150521.822266-1-vschneid@redhat.com> <20221005010832.1934-1-hdanton@sina.com> <20221005145022.1695-1-hdanton@sina.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665022061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u95QeRQ8pI84hzkplttBAirrt7saMkvsBJfHWllNkYs=; b=Y5wBn/Cl1be1VuR+Qowt6tWxUiouYh62uHSCZ5lA5WBT1s3fnYywdlDwoBul6q9k8+UtAM 1lEvoLCpJlxBf7L6/e9BqdcqHftoDVGo5F6UgeGN3iqkKECF/ab1GwLLz6mIxSA4sGPGdU QjX/I1d3YdheeeaZYZWto8APobdEYJs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.164 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665022061; a=rsa-sha256; cv=none; b=dIu8MgV3cUn8VeTmXY2KJD7+Vwbeypciv5JQhOPOvmN5XU3IegL2EDRTvxVS9mHXoCZrPo v1qB89k2tl2BdaQWyLP6mB+Tox50r9C4c5mo8a5tjd/L07OZqoJSQ3R8VIoelI1CKnqApn jY84SPYgAfa0dmt1xBJguidXkfDIwIA= X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.164 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none X-Stat-Signature: hx934u9fy4ijzxuk8uoz3wrq8t6ifmq7 X-Rspamd-Queue-Id: 3226412001B X-Rspamd-Server: rspam02 X-HE-Tag: 1665022058-806255 X-Bogosity: Ham, tests=bogofilter, spamicity=0.006315, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05 Oct 2022 17:14:17 +0100 Valentin Schneider > > The proper interface to play with that cpumask is set_cpus_allowed_ptr(), > which requires a sleepable context, hence the whole series. Given "nohz_full is a gimmick that shouldn't be used outside of very specific cases. Regular nohz otoh is used by everybody always." [1], I will take another look at this series next week. [1] https://lore.kernel.org/lkml/YzXGdEzkiw+5X8pC@hirez.programming.kicks-ass.net/