From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05286C433FE for ; Mon, 3 Oct 2022 23:53:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 377CD6B0072; Mon, 3 Oct 2022 19:53:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 328BA6B0073; Mon, 3 Oct 2022 19:53:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F1536B0074; Mon, 3 Oct 2022 19:53:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 09BC46B0072 for ; Mon, 3 Oct 2022 19:53:14 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C4E19A04BF for ; Mon, 3 Oct 2022 23:53:13 +0000 (UTC) X-FDA: 79981291866.06.F6CD104 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf29.hostedemail.com (Postfix) with ESMTP id DEB9F12001A for ; Mon, 3 Oct 2022 23:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664841192; x=1696377192; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XsbQqB1kOV5HDsgsc4ONdzxsJU1pLr3Pc/WAWDj/ozo=; b=nRPEqYmVaE0MM0Ksv7Q55Z32YUCsu5AGy1PuPLcRRvM2Tb4fKqko0j5z QFrHXgJmhWTCNSMvXl0vIGEz2csaqMX/vf/k/ecibZeexVXa3Wd8/63r0 69o7gYYP+9c8A2NjUfot0OpL6tpGRuWNCFSxtUzV12Q3V427Itpsa2PjI YNeESS3tOpPqiZm1Qq7ThsviLl0SOnZreH8vwo/8Ec9chI7s0Pmm31jzI 3WXwUsG1vRVNEGLtM86odAq5L2ICxBom2CpOY1zrBHfGhDSEU50icqWho b5n2q1+QO5Y5e8mbkPMwFwJHAc2fZao1WqqP8CRf6XMTie7+asLWpF2kL g==; X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="304331591" X-IronPort-AV: E=Sophos;i="5.93,366,1654585200"; d="scan'208";a="304331591" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2022 16:53:11 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="749189186" X-IronPort-AV: E=Sophos;i="5.93,366,1654585200"; d="scan'208";a="749189186" Received: from bandrei-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.37.219]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2022 16:53:03 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 319D8104CE4; Tue, 4 Oct 2022 02:53:00 +0300 (+03) Date: Tue, 4 Oct 2022 02:53:00 +0300 From: "Kirill A . Shutemov" To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V . Shankar" , Weijiang Yang , joao.moreira@intel.com, John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, Yu-cheng Yu Subject: Re: [PATCH v2 16/39] x86/mm: Update maybe_mkwrite() for shadow stack Message-ID: <20221003235300.zkf6lfemd7kyl47z@box.shutemov.name> References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-17-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220929222936.14584-17-rick.p.edgecombe@intel.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664841193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3q++8wCYsHAJwCqlE3FugCt33Ln5kkLpxe2fyPzpKGo=; b=PgU6GZxmN6Z2lU1HVN1eoWDvGx9sJY2NyLV3P1Q5Y0HpkhP8Va6hytuedtpC8K/t2lji55 yhzsUl9yglRbzUB3JlXdIDdykRtAlHtM2LLu0zcGcaZ8PTq3KKnAnO07KrjrwIFQOjcR9d eYjeN0vixxWuXZBdZDE94dcCryfKmeA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=nRPEqYmV; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none); spf=none (imf29.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664841193; a=rsa-sha256; cv=none; b=JWQyZ+qbSdo4C1gMW0UR7QzsgKM07Vn48Sdl6fBmn2LzaJZWsF58j1eFUULTjKsS0p37sA bHRJOrWaAWyok1OWPMoy0XOOy2TMJgEL+DIVvfJAwewDm/eWnNksnruPmEgMg7AQ2l9iz7 jg0MT8jlB1ATXAnYjA/0ppcyQnhxeBM= X-Rspam-User: X-Stat-Signature: u8xzsp91hpbnqoqnqmy8yc9npgwdn1yf X-Rspamd-Queue-Id: DEB9F12001A Authentication-Results: imf29.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=nRPEqYmV; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none); spf=none (imf29.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=kirill.shutemov@linux.intel.com X-Rspamd-Server: rspam01 X-HE-Tag: 1664841192-241872 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 29, 2022 at 03:29:13PM -0700, Rick Edgecombe wrote: > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 8cd413c5a329..fef14ab3abcb 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -981,13 +981,25 @@ void free_compound_page(struct page *page); > * servicing faults for write access. In the normal case, do always want > * pte_mkwrite. But get_user_pages can cause write faults for mappings > * that do not have writing enabled, when used by access_process_vm. > + * > + * If a vma is shadow stack (a type of writable memory), mark the pte shadow > + * stack. > */ > +#ifndef maybe_mkwrite > static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) > { > - if (likely(vma->vm_flags & VM_WRITE)) > + if (!(vma->vm_flags & VM_WRITE)) > + goto out; > + > + if (vma->vm_flags & VM_SHADOW_STACK) > + pte = pte_mkwrite_shstk(pte); > + else > pte = pte_mkwrite(pte); > + > +out: > return pte; > } > +#endif Maybe take opportunity to move it to ? It is really not a place for the helper. -- Kiryl Shutsemau / Kirill A. Shutemov