From: SeongJae Park <sj@kernel.org>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
linux-mm@kvack.org, akpm@linux-foundation.org,
damon@lists.linux.dev
Subject: Re: DAMON KUNIT test failure in latest mm-everything
Date: Mon, 3 Oct 2022 16:48:45 +0000 [thread overview]
Message-ID: <20221003164845.52332-1-sj@kernel.org> (raw)
In-Reply-To: <YzqDHs56va/NgHFy@hyeyoo>
On Mon, 3 Oct 2022 15:37:18 +0900 Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote:
> On Sun, Oct 02, 2022 at 07:36:56PM +0000, SeongJae Park wrote:
> > Hi Hyeonggon,
> >
> > On Sun, 2 Oct 2022 16:24:29 +0900 Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote:
> >
> > > On Sun, Oct 02, 2022 at 01:24:23PM +0900, Hyeonggon Yoo wrote:
> > > > Hi guys, yesterday I just built and booted latest mm-everything,
> > > > and I got following report from KUNIT test.
> > > >
> > > > Environment:
> > > > - x86_64, gcc 11.2.0
> > > > - mm-everything (tag: mm-everything-2022-10-01-01-55)
> > > > - config attached
> > > >
> > > > Report (stacktrace decoded):
> > >
> > > FYI, below is the bad commit from git bisection ;)
> > >
> > > Thanks!
> > >
> > > 065530b966a42d63f214ba40427dc8d00345f573 is the first bad commit
> > > commit 065530b966a42d63f214ba40427dc8d00345f573
> > > Author: SeongJae Park <sj@kernel.org>
> > > Date: Fri Sep 9 20:28:57 2022 +0000
> > >
> > > mm/damon/core-test: test damon_set_regions
> > >
> > > Preceding commit fixes a bug in 'damon_set_regions()', which allows holes
> > > in the new monitoring target ranges. This commit adds a kunit test case
> > > for the problem to avoid any regression.
> >
> > Thank you so much for this kind report! I just sent a patch[1] for this. It
> > should fix this issue.
>
> You're welcome! Thank you for quickly fixing this.
No problem, all owing to your grateful report!
>
> > BTW, please note that the real issue was there even
> > before the kunit commit, but the kunit commit was the first commit that
> > triggers the issue.
>
> Yeah, makes sense.
> Hmm.. Do you think it would be worth to backport to -stable?
IMHO, this is not stronly required for -stable, as the kunit test is the only
one case that could trigger the issue, to my understanding. If there is any
code that could trigger the issue in stable, of course it would be need to be
backported.
Thanks,
SJ
>
> > [1] https://lore.kernel.org/damon/20221002193130.8227-1-sj@kernel.org/
> >
> --
> Thanks,
> Hyeonggon
prev parent reply other threads:[~2022-10-03 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 4:24 Hyeonggon Yoo
2022-10-02 7:24 ` Hyeonggon Yoo
2022-10-02 19:36 ` SeongJae Park
2022-10-03 6:37 ` Hyeonggon Yoo
2022-10-03 16:48 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221003164845.52332-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox