From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E71C433FE for ; Mon, 3 Oct 2022 18:20:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 925F26B0071; Mon, 3 Oct 2022 14:20:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D3896B0073; Mon, 3 Oct 2022 14:20:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 774CE8E0001; Mon, 3 Oct 2022 14:20:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5E3556B0071 for ; Mon, 3 Oct 2022 14:20:27 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2E541140257 for ; Mon, 3 Oct 2022 18:20:27 +0000 (UTC) X-FDA: 79980453294.29.699F766 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf11.hostedemail.com (Postfix) with ESMTP id C689B40017 for ; Mon, 3 Oct 2022 18:20:26 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id b2so5515179plc.7 for ; Mon, 03 Oct 2022 11:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=UZjgWmpiJJffFVjLQAt9q1L84jCMCF8CBXS/nSLes6g=; b=hqz30n5kbVp2iZDtB7QPuCfGGOM134GF8OOn7Ux1URxpi8i/d4qkARtrNBTBahCeTt hKe7nKCzs+JCRPt8kPIUIqX8zEhUnnpcK4k/6arDQ3qVQYeVVQJt7ucuwYeFvzeRxb9v g55WTzhBzjO2XhZ0AhuPfc04gPLQ5at4fMdfs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=UZjgWmpiJJffFVjLQAt9q1L84jCMCF8CBXS/nSLes6g=; b=4/w17UJQNydAtY33O3+CIE/gxqrKrz69vNlv4vKIbGd3NhrdseePf/j4uTXZD4ydLb jsG9xVQblW6SRdVDC2lQUSy8cN9JxkD3LJ7PznTS09uBSucgvNtxg4nuh8dyFJLRwqtw AbG34q6/oMbhTDrLdv1Xssv6rcXa/auxEp6dgCU3QXHvIRlLRf/Q/UB4NTZDKw/tqWhc P5vMyd/wi/DCgtf8XQUignCsMamKhqq+CHmRtFFB/ge1SxQb8upYMi5vknHpTPa32EU9 dabQwW8z2egtXvizwGy8myIrlKZU6GwMLZHDIfTLIwN+3ad4LLBgvFftuyPPHbASteyo 5pNQ== X-Gm-Message-State: ACrzQf0E19XU3z8/gj9mRxHghbiYBxpXZEWC23to2KBZrSHSyLSGDpfm Bg1qrtvdlUMXMUuufZL8LXbaHQ== X-Google-Smtp-Source: AMsMyM4iuggdVHvNKE+hcPJKVm+/Awmgm1n7+g/dZTw1HMBGUSC0F63k6senCKPiMOgNcH5U1XeTYQ== X-Received: by 2002:a17:902:a511:b0:178:9702:7199 with SMTP id s17-20020a170902a51100b0017897027199mr22496151plq.155.1664821225428; Mon, 03 Oct 2022 11:20:25 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u4-20020a17090a518400b00200a85fa777sm10516489pjh.1.2022.10.03.11.20.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 11:20:24 -0700 (PDT) Date: Mon, 3 Oct 2022 11:20:23 -0700 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V . Shankar" , Weijiang Yang , "Kirill A . Shutemov" , joao.moreira@intel.com, John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, Yu-cheng Yu Subject: Re: [PATCH v2 15/39] x86/mm: Check Shadow Stack page fault errors Message-ID: <202210031120.5B6D7BBAC@keescook> References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-16-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220929222936.14584-16-rick.p.edgecombe@intel.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664821226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UZjgWmpiJJffFVjLQAt9q1L84jCMCF8CBXS/nSLes6g=; b=iu4oc2ZqUvV/N5p0JY5Icl3acy4Wxhrf/+axNjPAtQghlKhxU/wNxjuaeFlrw6DYY1x/oz 6neHfqrsrE75LjabeIBnUxPq3zGAdRUcLLoWyc121GeaJpZqIGFMxCerdDq5MSFR8pgfmN skRvUrbpS8nmC9a4P/3bh+nrrDRnGnc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hqz30n5k; spf=pass (imf11.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664821226; a=rsa-sha256; cv=none; b=gBwS8ElUI4yzmuGAc7jW4Q0G9amjYiX/kFz+gi3DH4G9BOyjBWBM+I9rfpGkRXHhnIAUf7 hRWbxTyooEAVHooBmVYK0lProEl/EJ9+VuPwlZeXPxlXSCDiPOPp/C8IuSP+lGfPuNmBYL kte069PJC6yLWnvl54YGQyoCVZCHJHs= X-Rspamd-Queue-Id: C689B40017 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hqz30n5k; spf=pass (imf11.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam06 X-Rspam-User: X-Stat-Signature: gnyrqz4xe8xkeqgdnh99nxyyq57463ux X-HE-Tag: 1664821226-902085 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 29, 2022 at 03:29:12PM -0700, Rick Edgecombe wrote: > From: Yu-cheng Yu > > The CPU performs "shadow stack accesses" when it expects to encounter > shadow stack mappings. These accesses can be implicit (via CALL/RET > instructions) or explicit (instructions like WRSS). > > Shadow stacks accesses to shadow-stack mappings can see faults in normal, > valid operation just like regular accesses to regular mappings. Shadow > stacks need some of the same features like delayed allocation, swap and > copy-on-write. The kernel needs to use faults to implement those features. > > The architecture has concepts of both shadow stack reads and shadow stack > writes. Any shadow stack access to non-shadow stack memory will generate > a fault with the shadow stack error code bit set. > > This means that, unlike normal write protection, the fault handler needs > to create a type of memory that can be written to (with instructions that > generate shadow stack writes), even to fulfill a read access. So in the > case of COW memory, the COW needs to take place even with a shadow stack > read. Otherwise the page will be left (shadow stack) writable in > userspace. So to trigger the appropriate behavior, set FAULT_FLAG_WRITE > for shadow stack accesses, even if the access was a shadow stack read. > > Shadow stack accesses can also result in errors, such as when a shadow > stack overflows, or if a shadow stack access occurs to a non-shadow-stack > mapping. Also, generate the errors for invalid shadow stack accesses. > > Signed-off-by: Yu-cheng Yu Reviewed-by: Kees Cook -- Kees Cook