From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 049BBC433F5 for ; Mon, 3 Oct 2022 18:06:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85C598E0001; Mon, 3 Oct 2022 14:06:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E3D66B0073; Mon, 3 Oct 2022 14:06:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6361F8E0001; Mon, 3 Oct 2022 14:06:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4D33E6B0071 for ; Mon, 3 Oct 2022 14:06:23 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0D11080924 for ; Mon, 3 Oct 2022 18:06:23 +0000 (UTC) X-FDA: 79980417846.01.9C6BD44 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf10.hostedemail.com (Postfix) with ESMTP id AAA96C0011 for ; Mon, 3 Oct 2022 18:06:22 +0000 (UTC) Received: by mail-pf1-f169.google.com with SMTP id 83so3875895pfw.10 for ; Mon, 03 Oct 2022 11:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=pIzTmQpobMdvo8GfKaRW2/roCkTNS3D5pBPTXA+12i8=; b=SXA4C8zlP/H6XYd9Wus6gRGtSyRucd9T6u9HfOHffXz/P69o11Ry2w00sgWnrMs5Xk wyVtfRqObDML4/alrBwbIuF3aYbADtN6HUCQ5qukqpvVWDlU7j9zT9EIV5AApI/1J1QH 83iN0ga1Tm78Y3rGKi7ExlccIx4e25wNLa/oc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=pIzTmQpobMdvo8GfKaRW2/roCkTNS3D5pBPTXA+12i8=; b=pZqwGnlBBWZcE6EeYqcaRtn4gN2UEu3vBW6DWr9nHgYrfiqW3MKROXmIJ9qLZXdSV/ AxBAlgakgp8BD/U7ImBA2NeJTUOrnT/AYXm3wOCxMhN0nckorAzDYR47UeOexVAWfYoU qKEHdzJGGJ2xwIr1/AdagLawIO0hnLCLEg2uziA4FpQym3RJB7vD01odzdmW+uH56J/S n1DgONkLE0qhyvMCaYWOk3lRwyAjLitJ6ENRSzUXNVkfrrsDXaKYryF5+zPlJ0MRtBkP JrTzJ7z4F6TcJvTgCvBKQObLBpGGBqoiRIYGNhjOxF+gqvv3+TpnYk6DaRXMyjraRZ4W uzXQ== X-Gm-Message-State: ACrzQf3sRorZ8iu0i5+HC4XWNWpRaLw3RakVT6pkbANNL3Ky78RPYxmn 1oZZP8SrJeb+MirKugDi0ZrCkg== X-Google-Smtp-Source: AMsMyM5neqQ02uhM3tW616MWu61HS4Vdqno2CVR6UnaXvvhzpp2blmFWahTxoonexAZ1EXGCH3aHSg== X-Received: by 2002:a05:6a00:4c11:b0:53e:4f07:fce9 with SMTP id ea17-20020a056a004c1100b0053e4f07fce9mr24392025pfb.66.1664820381761; Mon, 03 Oct 2022 11:06:21 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x2-20020aa79562000000b0053dec787698sm4474742pfq.175.2022.10.03.11.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 11:06:20 -0700 (PDT) Date: Mon, 3 Oct 2022 11:06:19 -0700 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V . Shankar" , Weijiang Yang , "Kirill A . Shutemov" , joao.moreira@intel.com, John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, Yu-cheng Yu Subject: Re: [PATCH v2 09/39] x86/mm: Move pmd_write(), pud_write() up in the file Message-ID: <202210031105.39AA8FE@keescook> References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-10-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220929222936.14584-10-rick.p.edgecombe@intel.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664820382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pIzTmQpobMdvo8GfKaRW2/roCkTNS3D5pBPTXA+12i8=; b=EGGVUpF6GM19BnpJZz+yxJmZxjkMyJLXj+0l8E8UMxdfg8OcvdZtYncCH//7GxSX6s0BLF iCUloyNYv5BcJdAwmLAws/AyZAv0FnOFkkDJ7iSD4Uexl5ayaBJqNBxlbwziKfXP7Kuo+B X2e44oHUN2gtdHeLanpZ3YPSEGy24TQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=SXA4C8zl; spf=pass (imf10.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.169 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664820382; a=rsa-sha256; cv=none; b=ikiYdQ0pif6GmkcWb/PWBPwpSJIdRRb/8gPoR8Yr5FtyZNCJhiPfHvnxHCBS8iapdMFjQo /Bzv/IsheTV/6TEby9pWugVe6+Zt9H4sL46T52QwQN5+bZUzhYOaxTet+HXhdE4/ub+4kR zw3v2sIn6yXx32JBFq21k8ZxEtjs6UU= Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=SXA4C8zl; spf=pass (imf10.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.169 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: AAA96C0011 X-Rspam-User: X-Stat-Signature: 8gggxt1h7od8smwzx74h61hwt4t5m1fx X-HE-Tag: 1664820382-927326 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 29, 2022 at 03:29:06PM -0700, Rick Edgecombe wrote: > From: Yu-cheng Yu > > To prepare the introduction of _PAGE_COW, move pmd_write() and > pud_write() up in the file, so that they can be used by other > helpers below. No functional changes. > > Signed-off-by: Yu-cheng Yu Hey, a PTE patch I'm able to review! ;) Reviewed-by: Kees Cook -- Kees Cook