From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76137C433FE for ; Mon, 3 Oct 2022 17:31:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F05356B0071; Mon, 3 Oct 2022 13:31:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8D396B0073; Mon, 3 Oct 2022 13:31:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB8B88E0001; Mon, 3 Oct 2022 13:31:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B2A196B0071 for ; Mon, 3 Oct 2022 13:31:48 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 86915A8059 for ; Mon, 3 Oct 2022 17:31:48 +0000 (UTC) X-FDA: 79980330696.25.0442B93 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf15.hostedemail.com (Postfix) with ESMTP id 2A622A0016 for ; Mon, 3 Oct 2022 17:31:47 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id u24so3306073plq.12 for ; Mon, 03 Oct 2022 10:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=brOcpUsUebGaNnS9rr/mt+efWwjd5MMft3vidAloMCk=; b=GpXJl7r64TNCgnOm/rwzqm9/zk7r5bZs1M5dug+kDOLMHf5hbIymxV51Z69U+kH4ec Xh+SzqohGNj3VGnNBOgqyJHMF0dIC9NSQLfJh1llp1R+BxRxZ/qIGnDPQdSLmPX14uio of8Xxx4zz2IGzaRCl+H1y+LAFkYlycpJPRqBs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=brOcpUsUebGaNnS9rr/mt+efWwjd5MMft3vidAloMCk=; b=twgt1+kPETjLzJCwH5mcNdUeU3zByisp+tab4ts/4d4EzK3K26U83GsYS5CTbtWL4K 9I2OI6CF0XhUFJznhpgZMR5gVim2H1HU9/4MxgYmQETNZiVDHKaYYKgTpQ9swY+KCTcR gZ1b/AGhIFD95IyJGmPjG6ukxTfxW4IBUcW31vyslSo+r2SS2gK9Wknz6ckFENg7vQes PdsBHRPX/OjyKfwqY9CzDyhvuZT+J+Mo9JorsxosQ0cGpwo6/yHHF5ttq6/yzRDRMM+s qlbcCHCaKE9dmGjR6e1n/cmU52GkOmTv7FU1TSYwxl3QaUA5ho5I8Ll71/Okli8tsayi jlyg== X-Gm-Message-State: ACrzQf2m7JrM9YT1As5ML3wii3eZGjtcuZBICSRiALpRtZTFvarD9GgX ARFFqI4oGgDEIgZfZGgbdx8UlQ== X-Google-Smtp-Source: AMsMyM57IJgx9Y5p5pOQkLFB+rSBDgUxwSCSiOSFplteoE6b0dUVolrJ3ykqvwSNZ198SqBVgt1Gug== X-Received: by 2002:a17:902:7081:b0:178:6154:9d79 with SMTP id z1-20020a170902708100b0017861549d79mr23572512plk.79.1664818307148; Mon, 03 Oct 2022 10:31:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y23-20020a17090264d700b00176e2fa216csm7562816pli.52.2022.10.03.10.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 10:31:46 -0700 (PDT) Date: Mon, 3 Oct 2022 10:31:45 -0700 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V . Shankar" , Weijiang Yang , "Kirill A . Shutemov" , joao.moreira@intel.com, John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, Yu-cheng Yu Subject: Re: [PATCH v2 04/39] x86/cpufeatures: Enable CET CR4 bit for shadow stack Message-ID: <202210031031.E2942B66@keescook> References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-5-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220929222936.14584-5-rick.p.edgecombe@intel.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664818308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=brOcpUsUebGaNnS9rr/mt+efWwjd5MMft3vidAloMCk=; b=RE0H5gKq8seaVS5ss8oWA2L8+GfKczP8dlP87PCsLtseHSMYOUU7aJT9urJayicbUGGt4Z GcltjMJwfwpx9tcmduzww2U7GEtc+i9BMbBxztQWBryFYFq/iO5mLxE4BcrsS2oUK9AIwl y2WneV5TeKQGHGfALtySUpReORgGOG8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GpXJl7r6; spf=pass (imf15.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664818308; a=rsa-sha256; cv=none; b=p6MANrrEyyqKMiz2O3Y0nAlALaCGSEyNvFs4RgNkNabzHWfj53W2oioM4HaDwn/FjFzAD4 0AG2H/Jg36GsYaHrL6b46gP44vhP397Bs2rR2lRU4g+V6cMsQXo83Fb509ubIlciCkYShS NMEJ7DmxcAqQIOcQqLATOfu/Ly+yrww= X-Stat-Signature: k1r3h7s5j18hdp77zbd8gxs9jgpsptdr X-Rspamd-Queue-Id: 2A622A0016 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GpXJl7r6; spf=pass (imf15.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1664818307-984513 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 29, 2022 at 03:29:01PM -0700, Rick Edgecombe wrote: > From: Yu-cheng Yu > > Utilizing CET features requires a CR4 bit to be enabled as well as bits > to be set in CET MSRs. Setting the CR4 bit does two things: > 1. Enables the usage of WRUSS instruction, which the kernel can use to > write to userspace shadow stacks. > 2. Allows those individual aspects of CET to be enabled later via the MSR. > 3. Allows CET to be enabled in guests > > While future patches will allow the MSR values to be saved and restored > per task, the CR4 bit will allow for WRUSS to be used regardless of if a > tasks CET MSRs have been restored. > > Kernel IBT already enables the CET CR4 bit when it detects IBT HW support > and is configured with kernel IBT. However future patches that enable > userspace shadow stack support will need the bit set as well. So change > the logic to enable it in either case. > > Clear MSR_IA32_U_CET in cet_disable() so that it can't live to see > userspace in a new kexec-ed kernel that has CR4.CET set from kernel IBT. > > Signed-off-by: Yu-cheng Yu > Co-developed-by: Rick Edgecombe > Signed-off-by: Rick Edgecombe > Cc: Kees Cook Reviewed-by: Kees Cook -- Kees Cook