From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AECB7C4332F for ; Sat, 1 Oct 2022 01:14:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 171428D0001; Fri, 30 Sep 2022 21:14:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 120F26B0072; Fri, 30 Sep 2022 21:14:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2A528D0001; Fri, 30 Sep 2022 21:14:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E145E6B0071 for ; Fri, 30 Sep 2022 21:14:18 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AB6F2C0425 for ; Sat, 1 Oct 2022 01:14:18 +0000 (UTC) X-FDA: 79970609796.03.6B4E1F3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 3AD1040006 for ; Sat, 1 Oct 2022 01:14:18 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2CCE16114B; Sat, 1 Oct 2022 01:14:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DC3AC433C1; Sat, 1 Oct 2022 01:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1664586857; bh=T6idAHXFh9n2+pRJNc6hWHfwxSGKHbWDBaMjbK/JeJI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T7GBC70DwGcTrKRy3+wZrhNzEhzQFDvJzxDwhO9phpL81Mgusz/yxpkc6YixzJazB 819FcfOHkM2L/83Nm1zh3J5CACwhdlKJaLPthgbJRqlCb5CJQfxkFML/KFdcpKfnHi Q4uC9d0S70ToxxulU0st1kaYfDef7erbTujUVH9w= Date: Fri, 30 Sep 2022 18:14:15 -0700 From: Andrew Morton To: Peter Xu Cc: syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Edward Liaw , Axel Rasmussen , Liu Shixin , Brian Geffon , Mike Kravetz Subject: Re: [syzbot] WARNING in change_protection Message-Id: <20220930181415.31c2ee66166d4e1c6c0eac64@linux-foundation.org> In-Reply-To: References: <00000000000046580505e9dea8e4@google.com> <20220930164211.b8215770d44e1a3803f1e660@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=T7GBC70D; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664586858; a=rsa-sha256; cv=none; b=aidW+oEOE960QRuDKCn0diEseb3sRHNysu//gfYgdKaXYCIWKb1uSjDRr2nR/JG87/4sbp JXnJsevd4JVHpdc1TIiVFBFVVJn0pYJCBHrIE0Kb0R44fjE+brs6XpGdB0AEPbi18cEPYI vH6jUU6KZ0Z0N7H/6/j/msNszdtCOaw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664586858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GNucnsoSE4p5GCXwFODOekbtYRWP3LmGm8rIll/puEI=; b=S06VCx2NDFf5neK1CXckEyF9xQChY6lTXpdvEIxcjMHZ57lX2u+IXVbZLvTLKEjt7DGwmP OtNhJ8zNr3W6SNG8L18/eZk+SaQe8wvoehHfHo95d0QONP61m6bbaM/FcDnNPq9btB9sgB tQsnroSqp+Y8ouWJTxlB34KU8065yCU= X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3AD1040006 X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=T7GBC70D; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: cq7a49ztkrjws3wubhjzy49z89fubxs8 X-HE-Tag: 1664586858-491100 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 30 Sep 2022 21:03:53 -0400 Peter Xu wrote: > When PTE_MARKER_UFFD_WP not configured, it's still possible to reach pte > marker code and trigger an warning. Add a few CONFIG_PTE_MARKER_UFFD_WP > ifdefs to make sure the code won't be reached when not compiled in. Thanks. Is 679d10331910180 ("mm: introduce PTE_MARKER swap entry") the appropriate Fixes: target? Should we backport to -stable? The inlined ifdefs are unpleasing. Let's go with this for now, but some future cleanup would be nice.