From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A39C4332F for ; Fri, 30 Sep 2022 10:27:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 380D48D0002; Fri, 30 Sep 2022 06:27:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 330556B0074; Fri, 30 Sep 2022 06:27:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F77B8D0002; Fri, 30 Sep 2022 06:27:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0CFFE6B0073 for ; Fri, 30 Sep 2022 06:27:18 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C5D69ABC0D for ; Fri, 30 Sep 2022 10:27:17 +0000 (UTC) X-FDA: 79968374514.07.12010E2 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf12.hostedemail.com (Postfix) with ESMTP id 495AD4000B for ; Fri, 30 Sep 2022 10:27:17 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id k10so6207561lfm.4 for ; Fri, 30 Sep 2022 03:27:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=opcYLHBFYUInTSSKrfc+T85BEqPL++kCd/mhT+P9K8Q=; b=Zunqaf42yRazlVaCz+p3FTJw+yxM7vvPb2+BMvxh0Q8/k83DtM7V24lwooufy4hpI2 Jg2mhNK0GC/we7ogEZ52w5v8j3jyCQVFh3AZsGmitjMLqEJeYHE4PBceRO1V5czE6tKO FvLLpRIX2Hh0GgEn6obNCVGgmlw+YRKJuqe5I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=opcYLHBFYUInTSSKrfc+T85BEqPL++kCd/mhT+P9K8Q=; b=Kg6OetN0gmvL9lLpZhoaC+NRzzTlH4Opxqocw8j6q9uRHmloPmGlfKw1z1JY8EH+NE Kp9JwOcEkOyvbAaKxHwukxVIEo0EIXQGGlYKUei4QJ83QjJlehaBJhFh4QkVoXh2D5CW QSwik3KvdHQDgRr1PvAsN7g2g8TOvYtEW0A5pycBFekn2ZCzmZbEAJWAdMCgbEOaJBVx rpjGlISgeKSjFhx6wiyP57T9WpX+MNElhA0WZwNoQn9zqwuInshfhXsBfk/1rwJ7ST5a qAnD89uBATGKwTVwXbjILYIY1/Y1aJomnCsIsIq1s6uNR5UELHVJCfIRyzC0JfaOfK3Z 4IYQ== X-Gm-Message-State: ACrzQf1G/Aw2piZOjsl7YT5kSci0V0NhkqF41C0dIZm6tTEKqQbrBVyT jYMPzY6h3iUDUj78bNfjd6gUIg== X-Google-Smtp-Source: AMsMyM5oMvmtmMosdWbrf3EOZ7Uo8V6qQYNRWBirQkE+RDrLDHiggbRv79iYim+nY7NSRwtLHk6jiw== X-Received: by 2002:a05:6512:c13:b0:49f:9a2f:8b86 with SMTP id z19-20020a0565120c1300b0049f9a2f8b86mr3002980lfu.413.1664533635506; Fri, 30 Sep 2022 03:27:15 -0700 (PDT) Received: from prevas-ravi.prevas.se ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id g12-20020a05651222cc00b00498f23c249dsm254543lfu.74.2022.09.30.03.27.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 03:27:14 -0700 (PDT) From: Rasmus Villemoes To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Rasmus Villemoes , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: slub: make slab_sysfs_init() a late_initcall Date: Fri, 30 Sep 2022 12:27:12 +0200 Message-Id: <20220930102712.789755-1-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=rasmusvillemoes.dk header.s=google header.b=Zunqaf42; spf=pass (imf12.hostedemail.com: domain of linux@rasmusvillemoes.dk designates 209.85.167.53 as permitted sender) smtp.mailfrom=linux@rasmusvillemoes.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664533637; a=rsa-sha256; cv=none; b=YWRGQKHq1/vFFTcMQW5nsUAIZvTkrbcq/lQmhhay1IxYm6WoKTES9EDTOqhQWmQbdKUWOX UKpigBZH4IYojdkNzV0S8fqm6oBaDRsMr2zCDoXSGSwC31nxBmp4Zkdi3rZlC7xg+2JAuz fMxElfWc0EA8WBhbG6oM15nH99TMt9s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664533637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=opcYLHBFYUInTSSKrfc+T85BEqPL++kCd/mhT+P9K8Q=; b=o1hlmaYRkfjbX8pxZmUtkRJRC0Z6zvW2i92p/0flg+elKF855qVypJXSDlXgavs/q4RvfK l6ymtPLQZnauHHRyB46yrSRYMh3rn8Iyq+km6XHYScLUAW33sSaXdfUvgbqD93zMRaCzys qIyWrWLX+mh25QP7qUMl2UEBulxZDNY= X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 495AD4000B X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=rasmusvillemoes.dk header.s=google header.b=Zunqaf42; spf=pass (imf12.hostedemail.com: domain of linux@rasmusvillemoes.dk designates 209.85.167.53 as permitted sender) smtp.mailfrom=linux@rasmusvillemoes.dk; dmarc=none X-Stat-Signature: 167hocsxoe3ucsg1njrerp6qwy6ddfts X-HE-Tag: 1664533637-82387 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently, slab_sysfs_init() is an __initcall aka device_initcall. It is rather time-consuming; on my board it takes around 11ms. That's about 1% of the time budget I have from U-Boot letting go and until linux must assume responsibility of keeping the external watchdog happy. There's no particular reason this would need to run at device_initcall time, so instead make it a late_initcall to allow vital functionality to get started a bit sooner. This actually ends up winning more than just those 11ms, because the slab caches that get created during other device_initcalls (and before my watchdog device gets probed) now don't end up doing the somewhat expensive sysfs_slab_add() themselves. Some example lines (with initcall_debug set) before/after: initcall ext4_init_fs+0x0/0x1ac returned 0 after 1386 usecs initcall journal_init+0x0/0x138 returned 0 after 517 usecs initcall init_fat_fs+0x0/0x68 returned 0 after 294 usecs initcall ext4_init_fs+0x0/0x1ac returned 0 after 240 usecs initcall journal_init+0x0/0x138 returned 0 after 32 usecs initcall init_fat_fs+0x0/0x68 returned 0 after 18 usecs Altogether, this means I now get to petting the watchdog around 17ms sooner. [Of course, the time the other initcalls save is instead spent in slab_sysfs_init(), which goes from 11ms to 16ms, so there's no overall change in boot time.] Signed-off-by: Rasmus Villemoes --- The numbers certainly suggest that someone might want to look into making sysfs/kobject/kset perform better. But that would be way more complicated than this patch, and could not possibly achieve the same win as getting the sysfs_slab_add() overhead completely out of the way. mm/slub.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 4b98dff9be8e..dade5c84a7bb 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -6070,8 +6070,7 @@ static int __init slab_sysfs_init(void) mutex_unlock(&slab_mutex); return 0; } - -__initcall(slab_sysfs_init); +late_initcall(slab_sysfs_init); #endif /* CONFIG_SYSFS */ #if defined(CONFIG_SLUB_DEBUG) && defined(CONFIG_DEBUG_FS) -- 2.37.2