* [PATCH] binfmt: remove taso from linux_binprm struct
@ 2022-09-29 20:39 Lukas Bulwahn
2022-09-29 22:17 ` Eric W. Biederman
2022-09-29 23:42 ` Kees Cook
0 siblings, 2 replies; 6+ messages in thread
From: Lukas Bulwahn @ 2022-09-29 20:39 UTC (permalink / raw)
To: Eric Biederman, Kees Cook, linux-mm
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the
use of the special taso flag for alpha architectures in the linux_binprm
struct is gone.
Remove the definition of taso in the linux_binprm struct.
No functional change.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Kees, please pick this patch on top of the commit above.
include/linux/binfmts.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
index 3dc20c4f394c..8d51f69f9f5e 100644
--- a/include/linux/binfmts.h
+++ b/include/linux/binfmts.h
@@ -43,9 +43,6 @@ struct linux_binprm {
* original userspace.
*/
point_of_no_return:1;
-#ifdef __alpha__
- unsigned int taso:1;
-#endif
struct file *executable; /* Executable to pass to the interpreter */
struct file *interpreter;
struct file *file;
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] binfmt: remove taso from linux_binprm struct
2022-09-29 20:39 [PATCH] binfmt: remove taso from linux_binprm struct Lukas Bulwahn
@ 2022-09-29 22:17 ` Eric W. Biederman
2022-09-29 23:36 ` Kees Cook
2022-09-29 23:39 ` Kees Cook
2022-09-29 23:42 ` Kees Cook
1 sibling, 2 replies; 6+ messages in thread
From: Eric W. Biederman @ 2022-09-29 22:17 UTC (permalink / raw)
To: Lukas Bulwahn; +Cc: Kees Cook, linux-mm, kernel-janitors, linux-kernel
Lukas Bulwahn <lukas.bulwahn@gmail.com> writes:
> With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the
> use of the special taso flag for alpha architectures in the linux_binprm
> struct is gone.
>
> Remove the definition of taso in the linux_binprm struct.
>
> No functional change.
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
Alphas binfmt_loader is the only use I can find of that variable
so let's kill it as well.
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Kees, please pick this patch on top of the commit above.
>
> include/linux/binfmts.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
> index 3dc20c4f394c..8d51f69f9f5e 100644
> --- a/include/linux/binfmts.h
> +++ b/include/linux/binfmts.h
> @@ -43,9 +43,6 @@ struct linux_binprm {
> * original userspace.
> */
> point_of_no_return:1;
> -#ifdef __alpha__
> - unsigned int taso:1;
> -#endif
> struct file *executable; /* Executable to pass to the interpreter */
> struct file *interpreter;
> struct file *file;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] binfmt: remove taso from linux_binprm struct
2022-09-29 22:17 ` Eric W. Biederman
@ 2022-09-29 23:36 ` Kees Cook
2022-09-29 23:39 ` Kees Cook
1 sibling, 0 replies; 6+ messages in thread
From: Kees Cook @ 2022-09-29 23:36 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: Lukas Bulwahn, linux-mm, kernel-janitors, linux-kernel
On Thu, Sep 29, 2022 at 05:17:28PM -0500, Eric W. Biederman wrote:
> Lukas Bulwahn <lukas.bulwahn@gmail.com> writes:
>
> > With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the
> > use of the special taso flag for alpha architectures in the linux_binprm
> > struct is gone.
> >
> > Remove the definition of taso in the linux_binprm struct.
> >
> > No functional change.
>
> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> Alphas binfmt_loader is the only use I can find of that variable
> so let's kill it as well.
I can't find anything using "taso". Where are you looking?
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] binfmt: remove taso from linux_binprm struct
2022-09-29 22:17 ` Eric W. Biederman
2022-09-29 23:36 ` Kees Cook
@ 2022-09-29 23:39 ` Kees Cook
2022-09-30 16:35 ` Eric W. Biederman
1 sibling, 1 reply; 6+ messages in thread
From: Kees Cook @ 2022-09-29 23:39 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: Lukas Bulwahn, linux-mm, kernel-janitors, linux-kernel
On Thu, Sep 29, 2022 at 05:17:28PM -0500, Eric W. Biederman wrote:
> Lukas Bulwahn <lukas.bulwahn@gmail.com> writes:
>
> > With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the
> > use of the special taso flag for alpha architectures in the linux_binprm
> > struct is gone.
> >
> > Remove the definition of taso in the linux_binprm struct.
> >
> > No functional change.
>
> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> Alphas binfmt_loader is the only use I can find of that variable
> so let's kill it as well.
Ah, sorry, misparsed this -- you mean, alpha's use (now removed) was the
only place it was accessed. Agreed. :)
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] binfmt: remove taso from linux_binprm struct
2022-09-29 23:39 ` Kees Cook
@ 2022-09-30 16:35 ` Eric W. Biederman
0 siblings, 0 replies; 6+ messages in thread
From: Eric W. Biederman @ 2022-09-30 16:35 UTC (permalink / raw)
To: Kees Cook; +Cc: Lukas Bulwahn, linux-mm, kernel-janitors, linux-kernel
Kees Cook <keescook@chromium.org> writes:
> On Thu, Sep 29, 2022 at 05:17:28PM -0500, Eric W. Biederman wrote:
>> Lukas Bulwahn <lukas.bulwahn@gmail.com> writes:
>>
>> > With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the
>> > use of the special taso flag for alpha architectures in the linux_binprm
>> > struct is gone.
>> >
>> > Remove the definition of taso in the linux_binprm struct.
>> >
>> > No functional change.
>>
>> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
>>
>> Alphas binfmt_loader is the only use I can find of that variable
>> so let's kill it as well.
>
> Ah, sorry, misparsed this -- you mean, alpha's use (now removed) was the
> only place it was accessed. Agreed. :)
Yes. I was looking in a tree without my previous change merged.
The code in binfmt_loader (which is removed in the my change) was the
only user of that variable I could find.
Eric
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] binfmt: remove taso from linux_binprm struct
2022-09-29 20:39 [PATCH] binfmt: remove taso from linux_binprm struct Lukas Bulwahn
2022-09-29 22:17 ` Eric W. Biederman
@ 2022-09-29 23:42 ` Kees Cook
1 sibling, 0 replies; 6+ messages in thread
From: Kees Cook @ 2022-09-29 23:42 UTC (permalink / raw)
To: linux-mm, lukas.bulwahn, ebiederm
Cc: Kees Cook, linux-kernel, kernel-janitors
On Thu, 29 Sep 2022 22:39:03 +0200, Lukas Bulwahn wrote:
> With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the
> use of the special taso flag for alpha architectures in the linux_binprm
> struct is gone.
>
> Remove the definition of taso in the linux_binprm struct.
>
> No functional change.
>
> [...]
Applied to for-next/execve, thanks!
[1/1] binfmt: remove taso from linux_binprm struct
https://git.kernel.org/kees/c/9f4beead610c
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-30 16:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29 20:39 [PATCH] binfmt: remove taso from linux_binprm struct Lukas Bulwahn
2022-09-29 22:17 ` Eric W. Biederman
2022-09-29 23:36 ` Kees Cook
2022-09-29 23:39 ` Kees Cook
2022-09-30 16:35 ` Eric W. Biederman
2022-09-29 23:42 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox