From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28766C433FE for ; Thu, 29 Sep 2022 23:39:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E1836B0074; Thu, 29 Sep 2022 19:39:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 991476B0075; Thu, 29 Sep 2022 19:39:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 858288D0001; Thu, 29 Sep 2022 19:39:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 766956B0074 for ; Thu, 29 Sep 2022 19:39:22 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4B20012096B for ; Thu, 29 Sep 2022 23:39:22 +0000 (UTC) X-FDA: 79966741764.11.C7488B6 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf03.hostedemail.com (Postfix) with ESMTP id DFC0B20009 for ; Thu, 29 Sep 2022 23:39:21 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id c6-20020a17090a4d0600b0020958fcd9acso1484708pjg.4 for ; Thu, 29 Sep 2022 16:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=406PHi1E3zQxmMChBF9K8IG+zjCzhZM2d2hHmY4Q4BA=; b=cgJgHsUAGCFMQ3CFDi3AgcrQiOvlEV35DecVLMmwLMl3Mdex18zzkKu24C3g+oYUwQ ukCPFcotbaV/BQzlbkBhRM+bc9mGQ6dyCFZWcSLWR25OPAR8PrOXVwhT+RUET4sjXMF0 nw7RCJvzf1x3Ti9JDeG3d3bCcjISPfBUfs/vU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=406PHi1E3zQxmMChBF9K8IG+zjCzhZM2d2hHmY4Q4BA=; b=q5IQU7Zj2NlWpN843JoLG7X0FLKa7A/cmbBdedOSV1xOPOHjsBJNIK4iFUKlTN+FF4 BD48piCz/K+oYcupDYR5baggIWSNiQY2zrFG8dXgtD7rviqtqEbyLY8Lv9aSk03frVrT AMaicucuJ1u0woLczbBC1T9Qdven2s8Krv2qot/izRGQVDCVx50q0S791oCFAVCp8Pwe Qa0UXdoqZVYNkB1i+OZfd9aSr+FLyCSQP6B+twiM8MFYNh9/y+iCbZ6nGIR9jw58WbGu KvxaVzd0joXs1v2ltgkbTxcU93m8a+cdJrm6z9EURNT13FnX7c3QzwE46ki+eEA8QkL9 nGcQ== X-Gm-Message-State: ACrzQf3p0TfC7UGfo3eDZhO9pfeOivaSclqozv+Yydiz5SyV4a3YxRkW ZOMascsyMaDRrGy+REIJW/APjA== X-Google-Smtp-Source: AMsMyM4zpLGflr4v7oe8USvwOdE1CTEZ8QnadhucyD+2vGwk217VqucBLy0urdyL+4oHeHdsyaYTrg== X-Received: by 2002:a17:902:a606:b0:178:57e4:a0c1 with SMTP id u6-20020a170902a60600b0017857e4a0c1mr5805722plq.83.1664494760865; Thu, 29 Sep 2022 16:39:20 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s13-20020a17090302cd00b00172dc6e1916sm427601plk.220.2022.09.29.16.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 16:39:20 -0700 (PDT) Date: Thu, 29 Sep 2022 16:39:19 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: Lukas Bulwahn , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] binfmt: remove taso from linux_binprm struct Message-ID: <202209291638.BD0B8639@keescook> References: <20220929203903.9475-1-lukas.bulwahn@gmail.com> <87tu4p3jwn.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tu4p3jwn.fsf@email.froward.int.ebiederm.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664494761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=406PHi1E3zQxmMChBF9K8IG+zjCzhZM2d2hHmY4Q4BA=; b=R2dcSR27SlBJAnersVeT6CCiyGTRNrUl4auvF1nffYaIaZzGweXpoAmARwuenIdBz2D5DN 1xNlvdBd4uDhFwWYA+6/zFVgf904IgD5IezvXtm7R66Xte1W8i2FzLtDCTYfV6PMHxK6ub P9CJZ+sEIMAzGm/S21rZ/dd3NPTRw6s= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=cgJgHsUA; spf=pass (imf03.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664494761; a=rsa-sha256; cv=none; b=RC9CP4U19plO1BjT0+oF9fZqEaqkTHzTdKy1WEgrsgQfWX8LnpH0Iof6sSZ9Rp8SrpukBM +12UqhoRCO9WKjTwVoXzQw2QbE1QbpZifrHWxmS2/v5NW6tB2mrOTmovgoFY/8R1y/cTLT bJ2YocaEZQIN9JAFZaGFFV+gpQYPd1U= Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=cgJgHsUA; spf=pass (imf03.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Stat-Signature: 9d1p5frizygj4hj6ixny31cuueg69dbr X-Rspamd-Queue-Id: DFC0B20009 X-Rspamd-Server: rspam08 X-HE-Tag: 1664494761-576175 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 29, 2022 at 05:17:28PM -0500, Eric W. Biederman wrote: > Lukas Bulwahn writes: > > > With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the > > use of the special taso flag for alpha architectures in the linux_binprm > > struct is gone. > > > > Remove the definition of taso in the linux_binprm struct. > > > > No functional change. > > Reviewed-by: "Eric W. Biederman" > > Alphas binfmt_loader is the only use I can find of that variable > so let's kill it as well. Ah, sorry, misparsed this -- you mean, alpha's use (now removed) was the only place it was accessed. Agreed. :) -- Kees Cook