From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C03CC433FE for ; Thu, 29 Sep 2022 23:36:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9921C6B0078; Thu, 29 Sep 2022 19:36:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9418D8D0001; Thu, 29 Sep 2022 19:36:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 808D26B007D; Thu, 29 Sep 2022 19:36:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6F7236B0078 for ; Thu, 29 Sep 2022 19:36:31 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 503A8C0281 for ; Thu, 29 Sep 2022 23:36:31 +0000 (UTC) X-FDA: 79966734582.01.CF778E2 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf22.hostedemail.com (Postfix) with ESMTP id E42A0C0004 for ; Thu, 29 Sep 2022 23:36:30 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id a29so2772700pfk.5 for ; Thu, 29 Sep 2022 16:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=Xbz67oZK82CtGclYCJkU8C5apLwvJO6ocDW2GQnKsP0=; b=AUn3kZDM5lNvy5m2+3Ts9Kl9mS+Bt4VFAtsVryc4ezGL1WMAmzOAlrP87i9nHVp7A5 VZZypx1I4Z/tOJTTDsGmlHyxag27HLBJi+gMYjZEt7Tg9PggmlXUdJpR0sRwSOp2Ab7O cqN4IvhgOSoj5j1zwMctOnj01LrTNiFVO6lJo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=Xbz67oZK82CtGclYCJkU8C5apLwvJO6ocDW2GQnKsP0=; b=LlbmGt5CM31cK1UcVF0lVkddINJJtQLFK6zsIX2P5s6RGR2w/iQ6YAVf5qvMNYSiga Oqqwdfq52OKgEpggtKWD8xCNBT0QtgO58lvYILwobHSeKri1O7nzQ3PRotu69IkgOv68 7NMatzsLBBpxZu1jJkdIirurkqnRTgtyfPFqAJiKltyP42h/w+s08e8L/kSQetjW+XER jwCAWKvWT0N30OrKAfL3ReZ3AQ70gpaBZKPtNR8xSgB77WWVStoiyJjcYJ52bLvIJDGY Iifr9zhZvmC9FwRdHB8aOHVXS5R3g3YaQb85hKE/exQlXJEav2F5YsL+ays4beKRF6u+ Oecg== X-Gm-Message-State: ACrzQf1wYfL15K35DNaj32iF5l6+XbMB1q92q18/RPfIw7T629Qh6V4M a6OfaWiAcglH6JShUi7Ox616TQ== X-Google-Smtp-Source: AMsMyM5unEH1nAScJeckvDRNethcxnyDUrHMMmmroXgAknht8ekkwWtouSRGGxJA4MKsFbroz9alPw== X-Received: by 2002:a63:f518:0:b0:43c:403:9833 with SMTP id w24-20020a63f518000000b0043c04039833mr4829720pgh.461.1664494589889; Thu, 29 Sep 2022 16:36:29 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id ij28-20020a170902ab5c00b00178af82a000sm452969plb.122.2022.09.29.16.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 16:36:29 -0700 (PDT) Date: Thu, 29 Sep 2022 16:36:28 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: Lukas Bulwahn , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] binfmt: remove taso from linux_binprm struct Message-ID: <202209291635.EA24FCEA@keescook> References: <20220929203903.9475-1-lukas.bulwahn@gmail.com> <87tu4p3jwn.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tu4p3jwn.fsf@email.froward.int.ebiederm.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664494591; a=rsa-sha256; cv=none; b=znYtEuB7pWHO8kAy24YjYni3NpH9F5HIsD0o8GvGVDfmvLrQ7EZlC2uy8w4UFbjJu6m2qU +lbYBJ9LtHTk0PjXgBKTI4L5//cTDHg/t3ulGnvnu0nfJYEalOj3xZvscOMyWz23MlpomA Zn4phzTb4A8skcxP06q3vP8U/Eu/W30= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=AUn3kZDM; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.173 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664494591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xbz67oZK82CtGclYCJkU8C5apLwvJO6ocDW2GQnKsP0=; b=O0shu/YCEfLwcYkTYg+2NrIcZq9e42eaXSrm+GzpdLO/bn/SaNLwC7e73iPNzR+3xUTNxU FaC6EDfGV+M6RberxhRO4IxM34X4S3hUlaXWphRf5T6oFWL0y+cyzuVWLfbVpRt1tQoaT/ RV8Fb/KpXr3u5CMX6Sgzvfm/X39GvaE= X-Stat-Signature: dsxcpskt589ebqxa9w718jnqo8cwwnse X-Rspamd-Queue-Id: E42A0C0004 X-Rspamd-Server: rspam04 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=AUn3kZDM; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.173 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Rspam-User: X-HE-Tag: 1664494590-413138 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 29, 2022 at 05:17:28PM -0500, Eric W. Biederman wrote: > Lukas Bulwahn writes: > > > With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the > > use of the special taso flag for alpha architectures in the linux_binprm > > struct is gone. > > > > Remove the definition of taso in the linux_binprm struct. > > > > No functional change. > > Reviewed-by: "Eric W. Biederman" > > Alphas binfmt_loader is the only use I can find of that variable > so let's kill it as well. I can't find anything using "taso". Where are you looking? -- Kees Cook