From: xu xin <xu.xin.sc@gmail.com>
To: david@redhat.com
Cc: akpm@linux-foundation.org, imbrenda@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
xu.xin.sc@gmail.com, xu.xin16@zte.com.cn
Subject: Reply:[PATCH 0/3] ksm: fix incorrect count of merged pages when enabling use_zero_pages
Date: Thu, 29 Sep 2022 11:13:15 +0000 [thread overview]
Message-ID: <20220929111315.284133-1-xu.xin16@zte.com.cn> (raw)
In-Reply-To: <4a3daba6-18f9-d252-697c-197f65578c44@redhat.com>
>> We need to add the count of empty pages to let users know how many empty
>> pages are merged with kernel zero page(s).
>>
>> Please see the subsequent patches for details.
> Just raising the topic here because it's related to the KSM usage of the
> shared zero-page:
> MADV_UNMERGEABLE and other ways to trigger unsharing will *not* unshare
> the shared zeropage as placed by KSM (which is against the
> MADV_UNMERGEABLE documentation at least). It will only unshare actual
> KSM pages. We might not want want to blindly unshare all shared
> zeropages in applicable VMAs ... using a dedicated shared zero (KSM)
> page -- instead of the generic zero page -- might be one way to handle
> this cleaner.
> Would that also fix some of the issues you describe above?
Glad to see your reply. I think it depends.
The way you said solves the issue you post, but maybe not help to solve the issue
I post.
The key lies in whether appending zeropage's rmap_items to stable tree. If
appending their rmap_items to the stable tree, the issue I pointed can be fixed but
that will degrade the performance of use_zero_pages. If not appending their rmap_items
to the stable tree, we have to choose this patches set (but I found some bugs now, later
I will send v2 to fix it).
next prev parent reply other threads:[~2022-09-29 11:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 2:52 [PATCH " xu.xin.sc
2022-09-29 2:59 ` [PATCH 1/3] ksm: abstract the function try_to_get_old_rmap_item xu.xin.sc
2022-09-29 3:00 ` [PATCH 2/3] ksm: add the accounting of zero pages merged by use_zero_pages xu.xin.sc
2022-09-29 3:00 ` [PATCH 3/3] ksm: add zero_pages_sharing in Documentation xu.xin.sc
2022-09-29 9:21 ` [PATCH 0/3] ksm: fix incorrect count of merged pages when enabling use_zero_pages David Hildenbrand
2022-09-29 10:36 ` Claudio Imbrenda
2022-09-29 11:12 ` David Hildenbrand
2022-09-29 12:05 ` Claudio Imbrenda
2022-09-29 17:53 ` David Hildenbrand
2022-09-30 9:30 ` Claudio Imbrenda
2022-09-30 9:40 ` David Hildenbrand
2022-09-29 11:13 ` xu xin [this message]
2022-09-29 10:42 ` Claudio Imbrenda
2022-09-29 11:34 ` David Hildenbrand
2022-09-29 11:51 ` Claudio Imbrenda
2022-09-30 2:00 ` Reply:[PATCH " xu xin
2022-09-30 9:41 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929111315.284133-1-xu.xin16@zte.com.cn \
--to=xu.xin.sc@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=imbrenda@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xu.xin16@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox