linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: xu.xin.sc@gmail.com
To: akpm@linux-foundation.org, david@redhat.com, imbrenda@linux.vnet.ibm.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	xu xin <xu.xin16@zte.com.cn>,
	Xiaokai Ran <ran.xiaokai@zte.com.cn>,
	Yang Yang <yang.yang29@zte.com.cn>,
	Jiang Xuexin <jiang.xuexin@zte.com.cn>,
	xu xin <xu.xin.sc@gmail.com>
Subject: [PATCH 3/3] ksm: add zero_pages_sharing in Documentation
Date: Thu, 29 Sep 2022 03:00:43 +0000	[thread overview]
Message-ID: <20220929030043.281441-1-xu.xin16@zte.com.cn> (raw)
In-Reply-To: <20220929025206.280970-1-xu.xin16@zte.com.cn>

From: xu xin <xu.xin16@zte.com.cn>

When enabling use_zero_pages, pages_sharing cannot represent how
much memory saved indeed. zero_pages_sharing + pages_sharing does.
add the description of zero_pages_sharing.

Signed-off-by: xu xin <xu.xin16@zte.com.cn>
Cc: Xiaokai Ran <ran.xiaokai@zte.com.cn>
Cc: Yang Yang <yang.yang29@zte.com.cn>
Cc: Jiang Xuexin <jiang.xuexin@zte.com.cn>
Signed-off-by: xu xin <xu.xin.sc@gmail.com>
---
 Documentation/admin-guide/mm/ksm.rst | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst
index fb6ba2002a4b..484665aa7418 100644
--- a/Documentation/admin-guide/mm/ksm.rst
+++ b/Documentation/admin-guide/mm/ksm.rst
@@ -162,7 +162,7 @@ The effectiveness of KSM and MADV_MERGEABLE is shown in ``/sys/kernel/mm/ksm/``:
 pages_shared
         how many shared pages are being used
 pages_sharing
-        how many more sites are sharing them i.e. how much saved
+        how many more sites are sharing them
 pages_unshared
         how many pages unique but repeatedly checked for merging
 pages_volatile
@@ -173,6 +173,14 @@ stable_node_chains
         the number of KSM pages that hit the ``max_page_sharing`` limit
 stable_node_dups
         number of duplicated KSM pages
+zero_pages_sharing
+        how many empty pages are sharing kernel zero page(s) instead of
+        with each other as it would happen normally. only effective when
+        enabling ``use_zero_pages`` knob.
+
+If ``use_zero_pages`` is 0, only ``pages_sharing`` can represents how
+much saved. Otherwise, ``pages_sharing`` + ``zero_pages_sharing``
+represents how much saved actually.
 
 A high ratio of ``pages_sharing`` to ``pages_shared`` indicates good
 sharing, but a high ratio of ``pages_unshared`` to ``pages_sharing``
-- 
2.25.1



  parent reply	other threads:[~2022-09-29  3:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29  2:52 [PATCH 0/3] ksm: fix incorrect count of merged pages when enabling use_zero_pages xu.xin.sc
2022-09-29  2:59 ` [PATCH 1/3] ksm: abstract the function try_to_get_old_rmap_item xu.xin.sc
2022-09-29  3:00 ` [PATCH 2/3] ksm: add the accounting of zero pages merged by use_zero_pages xu.xin.sc
2022-09-29  3:00 ` xu.xin.sc [this message]
2022-09-29  9:21 ` [PATCH 0/3] ksm: fix incorrect count of merged pages when enabling use_zero_pages David Hildenbrand
2022-09-29 10:36   ` Claudio Imbrenda
2022-09-29 11:12     ` David Hildenbrand
2022-09-29 12:05       ` Claudio Imbrenda
2022-09-29 17:53         ` David Hildenbrand
2022-09-30  9:30           ` Claudio Imbrenda
2022-09-30  9:40             ` David Hildenbrand
2022-09-29 11:13   ` Reply:[PATCH " xu xin
2022-09-29 10:42 ` [PATCH " Claudio Imbrenda
2022-09-29 11:34   ` David Hildenbrand
2022-09-29 11:51     ` Claudio Imbrenda
2022-09-30  2:00       ` Reply:[PATCH " xu xin
2022-09-30  9:41         ` Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220929030043.281441-1-xu.xin16@zte.com.cn \
    --to=xu.xin.sc@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=imbrenda@linux.vnet.ibm.com \
    --cc=jiang.xuexin@zte.com.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ran.xiaokai@zte.com.cn \
    --cc=xu.xin16@zte.com.cn \
    --cc=yang.yang29@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox