From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E092BC54EE9 for ; Tue, 27 Sep 2022 12:31:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFE7E8E00CF; Tue, 27 Sep 2022 08:31:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D86BB8E00C1; Tue, 27 Sep 2022 08:31:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C27758E00CF; Tue, 27 Sep 2022 08:31:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B042F8E00C1 for ; Tue, 27 Sep 2022 08:31:35 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 72FAEC085F for ; Tue, 27 Sep 2022 12:31:35 +0000 (UTC) X-FDA: 79957801350.25.6C24844 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf21.hostedemail.com (Postfix) with ESMTP id CCC9E1C0017 for ; Tue, 27 Sep 2022 12:31:34 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id AFF0868AFE; Tue, 27 Sep 2022 14:31:30 +0200 (CEST) Date: Tue, 27 Sep 2022 14:31:30 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Christoph Hellwig , Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kefeng Wang Subject: Re: [PATCH v5 2/5] Revert "frontswap: simplify frontswap_register_ops" Message-ID: <20220927123130.GA5549@lst.de> References: <20220915035003.3347466-1-liushixin2@huawei.com> <20220915035003.3347466-3-liushixin2@huawei.com> <20220920121305.GA4237@lst.de> <2b469a5c-7960-ca6a-9360-c7d3aa26e8ae@huawei.com> <20220927072754.GB16710@lst.de> <986efc9f-0deb-f705-dff1-f4d5992c2b8d@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <986efc9f-0deb-f705-dff1-f4d5992c2b8d@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=none (imf21.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664281895; a=rsa-sha256; cv=none; b=wUtBHMSUlMufnve+Fo1V0BDv9Jcvw68J24LEGH4T44W7CGbxgG4VKEl/B3nO6Hwh9OyXfV jKuMgTTfFokLwmd7zy6KBx4xr17jxIK7vu1/CkYrHvDEY+cQDouS+JXgWz0GWSHMkJPzUZ z0DVwa6kDFO/4vHb3dsyh0PSj0QllxA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664281895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yVHW0yWvGrjjQAAvgwp/z0jQIf7u4pf8n1V+7zmn+d0=; b=FUel2xXCQbPtpHCngvQiqO6H130VvfbGehdrAj+az5RgXrbqB9c9kvh5ajhVacQAjZSscB kO/NKn+VeulGl4++Pyui3o4m1ADN52tuWW6YBw4m/+D/0oay6oBC+3h3rkD0nIWmkGY0DA wM+51/4ifm9WSeHxcF7cYOT1yeKTIcE= X-Stat-Signature: w9kbwgnedejdr16mo58u7oghe3c5eua7 X-Rspamd-Queue-Id: CCC9E1C0017 Authentication-Results: imf21.hostedemail.com; dkim=none; spf=none (imf21.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1664281894-730771 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 27, 2022 at 07:12:58PM +0800, Liu Shixin wrote: > If not do this, while some user enable swap device first and then enable zswap, > zswap will not take effect. The user need to re-enable the swap device which is > inconvenient. So load the module before swapping on, just like you'd load any driver before you expect to use it.