From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A47C6FA83 for ; Tue, 27 Sep 2022 07:28:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA0228E00B1; Tue, 27 Sep 2022 03:27:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C29CB8E00AF; Tue, 27 Sep 2022 03:27:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACAF48E00B1; Tue, 27 Sep 2022 03:27:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 98C1B8E00AF for ; Tue, 27 Sep 2022 03:27:59 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 507141C5E74 for ; Tue, 27 Sep 2022 07:27:59 +0000 (UTC) X-FDA: 79957036278.16.5D63BA0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf30.hostedemail.com (Postfix) with ESMTP id D1EA88000C for ; Tue, 27 Sep 2022 07:27:58 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 1020E68AA6; Tue, 27 Sep 2022 09:27:55 +0200 (CEST) Date: Tue, 27 Sep 2022 09:27:54 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Christoph Hellwig , Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kefeng Wang Subject: Re: [PATCH v5 2/5] Revert "frontswap: simplify frontswap_register_ops" Message-ID: <20220927072754.GB16710@lst.de> References: <20220915035003.3347466-1-liushixin2@huawei.com> <20220915035003.3347466-3-liushixin2@huawei.com> <20220920121305.GA4237@lst.de> <2b469a5c-7960-ca6a-9360-c7d3aa26e8ae@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b469a5c-7960-ca6a-9360-c7d3aa26e8ae@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=none (imf30.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664263679; a=rsa-sha256; cv=none; b=plaJUlCjAgqCO08T+PFQZ6boJVp7JNyGHRKrq86qLz6WMSoESolFkhX8nuMWpHZah3WnTz +50lRizzxxFFFYaRFYWuQWewAMWVelbcA8yAO93jmWKZfKCIaVQEnVSDYuLuDXhlo+9tHG /5/Nkw5olvQJjZqADzL95V1vEarcT8U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664263679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fliMS2i4TTVifSt+TYzGSe+JnrQYlRyNCEBzpd98wDg=; b=PxdRguMgMFVuVat+0niqNj3snrXk6N8iI/nW13PV9KdALSwYDOQlFlR8e5XsEDnGTZlLHI ZhNhwaaY0HDCAnCG8jWmavCfjFAIpiOi4liJFZ/EvDiu7UobV2TZtRjXQGNI6adgH3IcK2 OXDl5XE69Ha5rEmmr29q0blWDs+8mf0= X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=none; spf=none (imf30.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam01 X-Stat-Signature: pakn8jmthciiukayp7k39xxt6rfypc95 X-Rspamd-Queue-Id: D1EA88000C X-HE-Tag: 1664263678-571890 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 21, 2022 at 09:42:41AM +0800, Liu Shixin wrote: > This revert makes code complicated, but I think it's necessary. When > enable zswap, I expect it to work for all swap devices as much as > possible. But why would expect something to work on a device that has been swapped on before? That's not usually how things work.