From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B24BC07E9D for ; Mon, 26 Sep 2022 16:23:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D99778E0070; Mon, 26 Sep 2022 12:23:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D48F28E0066; Mon, 26 Sep 2022 12:23:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C10958E0070; Mon, 26 Sep 2022 12:23:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B10B28E0066 for ; Mon, 26 Sep 2022 12:23:30 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7FDAEC0A92 for ; Mon, 26 Sep 2022 16:23:30 +0000 (UTC) X-FDA: 79954756980.29.5288080 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 1D358160019 for ; Mon, 26 Sep 2022 16:23:29 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 30BFE60F88; Mon, 26 Sep 2022 16:23:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12BB4C433D7; Mon, 26 Sep 2022 16:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664209408; bh=3NryUWgV4wNFcxmk/xIXBo2lc6PqLNsFir7j/J5ql+M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B9VxvHOWkGdHyuAUNDqCqlOxg64J4VVjtASjH5BQowJtyDWQK04xux3uC2Lnn5h/b PrDHkRjm3biuNgaFNpRDLtC0LGOHMXy2LsFtz7uO0XdOqRb+Eh4ivOmptA/35CS9AE 97gPV8P4XpmwkyFJwfaaTnPJGVJAGhX3Jt9lGsGaH0vIyxp426Yp0DFXZ1V6CjQq0T Th3Il54+19a9FLERiAON15iosTLwqWxoAYdJNf1gGmlbBYPj7NHlZ8EjnvVJX5kywR +fugilr2jLjXoD9mxnrbzQyvT57xD9145ZkkEUXa1cuHN5TUZy/GvncTnsQsxcuBG7 SC+gT25qjxAFA== From: SeongJae Park To: SeongJae Park Cc: akpm@linux-foundation.org, ppbuk5246@gmail.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v4] damon/sysfs: Fix possible memleak on damon_sysfs_add_target. Date: Mon, 26 Sep 2022 16:23:26 +0000 Message-Id: <20220926162326.49013-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926160611.48536-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664209410; a=rsa-sha256; cv=none; b=eWjxBg8xv7/5M7ZxBYQ+XP9a+ooj3J98Z6sHTFA47A3rnlxJil3DEwxTfv72I+7/ELluGn V73JRgnUpoR4Or7B3xSb/+CKA8IyXKKmsDiRM2sWkSysGV+Nt7jqFGmO56OlUWY0oh0u6o vKdg8JLbRWc22pqm2JWynKM0dBVHnDg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B9VxvHOW; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664209410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rTL3iYi4F7f9DBOx3idAOZty80MSHsP/AWEyCiw3sCY=; b=r4AeN2Y2J/0PvdvBYjsORlJDnrrXOKzZJNfy3R6/atJlMbPYBXeZ3xDugMweTnh+aaDMGO Ku2Qdp1S2BGl5rLtKRGXGJ4R3MSJa5F2//GYM2WqfSxNpwFrKqjFW3PWWPc5aNX5IJH6ak dqJb6EvvsoKbRGSRHX3km2cM8pyXrH0= X-Rspamd-Server: rspam03 X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B9VxvHOW; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org X-Stat-Signature: j8amyst3gkuch7bce3yssrjqs8itjg7r X-Rspamd-Queue-Id: 1D358160019 X-HE-Tag: 1664209409-774785 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I forgot removing the closing dot of the subject and making the subject lower-case. On Mon, 26 Sep 2022 16:06:11 +0000 SeongJae Park wrote: > From: Levi Yun > > When damon_sysfs_add_target couldn't find proper task, > New allocated damon_target structure isn't registered yet, > So, it's impossible to free new allocated one by > damon_sysfs_destroy_targets. > > By calling daemon_add_target as soon as allocating new target, Fix this Also we should s/daemon/damon/ I will revise and send v5. > possible memory leak. > > Fixes: a61ea561c871 ("mm/damon/sysfs: link DAMON for virtual address spaces monitoring") > Cc: # 5.17.x > Signed-off-by: Levi Yun > Reviewed-by: SeongJae Park > Signed-off-by: SeongJae Park > --- > > Changes from v3 > (https://lore.kernel.org/damon/20220925234327.26345-1-ppbuk5246@gmail.com/) > - Fix Fixes: tag > - Add patch changelog > > Changes from v2 > (https://lore.kernel.org/damon/20220925234053.26090-1-ppbuk5246@gmail.com/) > - Add Fixes: and Cc: stable > > Changes from v1 > (https://lore.kernel.org/damon/20220925140257.23431-1-ppbuk5246@gmail.com/) > - Do damon_add_target() earlier instead of explicitly freeing the object > > mm/damon/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index 455215a5c059..9f1219a67e3f 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -2172,12 +2172,12 @@ static int damon_sysfs_add_target(struct damon_sysfs_target *sys_target, > > if (!t) > return -ENOMEM; > + damon_add_target(ctx, t); > if (damon_target_has_pid(ctx)) { > t->pid = find_get_pid(sys_target->pid); > if (!t->pid) > goto destroy_targets_out; > } > - damon_add_target(ctx, t); > err = damon_sysfs_set_regions(t, sys_target->regions); > if (err) > goto destroy_targets_out; > -- > 2.25.1